From: Christoffer Dall <christoffer.dall@linaro.org> To: Eric Auger <eric.auger@linaro.org> Cc: eric.auger@st.com, marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, alex.williamson@redhat.com, joel.schopp@amd.com, kim.phillips@freescale.com, paulus@samba.org, gleb@kernel.org, pbonzini@redhat.com, linux-kernel@vger.kernel.org, patches@linaro.org, will.deacon@arm.com, a.motakis@virtualopensystems.com, a.rigo@virtualopensystems.com, john.liuli@huawei.com Subject: Re: [RFC v2 5/9] KVM: KVM-VFIO: update user API to program forwarded IRQ Date: Thu, 11 Sep 2014 19:08:13 +0200 [thread overview] Message-ID: <20140911170813.GC5535@lvm> (raw) In-Reply-To: <54116204.6000403@linaro.org> On Thu, Sep 11, 2014 at 10:49:08AM +0200, Eric Auger wrote: > On 09/11/2014 05:10 AM, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 02:52:44PM +0200, Eric Auger wrote: [...] > >> + > >> +It is up to the caller of this API to make sure the IRQ is not > >> +outstanding when the FORWARD/UNFORWARD is called. This could lead to > > > > outstanding? can you be specific? > active? and I should add *physical* IRQ > > > > don't refer to FOWARD/UNFORWARD, either refer to these attributes by > > their full name or use a clear reference in proper English. > ok > > > >> +some inconsistency on who is going to complete the IRQ. > > > > This sounds like the whole thing is fragile and if userspace doesn't do > > things right, IRQ handling of a piece of hardware is going to be > > inconsistent? Is this the case? If so, we need some stronger > > semantics. If not, this should be rephrased. > Actually the KVM-VFIO device rejects any attempt to change the > forwarding mode if the physical IRQ is active. So I hope this is robust > and will change the explanation. > ok, so what is the proposed method if the IRQ is indeed active, should user space loop around and try or can user space make sure somehow? If user space should simply retry for a number of times, we should probalby return a proper error code for this case -EINTR? -Christoffer
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall) To: linux-arm-kernel@lists.infradead.org Subject: [RFC v2 5/9] KVM: KVM-VFIO: update user API to program forwarded IRQ Date: Thu, 11 Sep 2014 19:08:13 +0200 [thread overview] Message-ID: <20140911170813.GC5535@lvm> (raw) In-Reply-To: <54116204.6000403@linaro.org> On Thu, Sep 11, 2014 at 10:49:08AM +0200, Eric Auger wrote: > On 09/11/2014 05:10 AM, Christoffer Dall wrote: > > On Mon, Sep 01, 2014 at 02:52:44PM +0200, Eric Auger wrote: [...] > >> + > >> +It is up to the caller of this API to make sure the IRQ is not > >> +outstanding when the FORWARD/UNFORWARD is called. This could lead to > > > > outstanding? can you be specific? > active? and I should add *physical* IRQ > > > > don't refer to FOWARD/UNFORWARD, either refer to these attributes by > > their full name or use a clear reference in proper English. > ok > > > >> +some inconsistency on who is going to complete the IRQ. > > > > This sounds like the whole thing is fragile and if userspace doesn't do > > things right, IRQ handling of a piece of hardware is going to be > > inconsistent? Is this the case? If so, we need some stronger > > semantics. If not, this should be rephrased. > Actually the KVM-VFIO device rejects any attempt to change the > forwarding mode if the physical IRQ is active. So I hope this is robust > and will change the explanation. > ok, so what is the proposed method if the IRQ is indeed active, should user space loop around and try or can user space make sure somehow? If user space should simply retry for a number of times, we should probalby return a proper error code for this case -EINTR? -Christoffer
next prev parent reply other threads:[~2014-09-11 17:08 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-01 12:52 [RFC v2 0/9] KVM-VFIO IRQ forward control Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-01 12:52 ` [RFC v2 1/9] KVM: ARM: VGIC: fix multiple injection of level sensitive forwarded IRQ Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:09 ` Christoffer Dall 2014-09-11 3:09 ` Christoffer Dall 2014-09-11 18:17 ` Eric Auger 2014-09-11 18:17 ` Eric Auger 2014-09-11 22:14 ` Christoffer Dall 2014-09-11 22:14 ` Christoffer Dall 2014-09-01 12:52 ` [RFC v2 2/9] KVM: ARM: VGIC: add forwarded irq rbtree lock Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:09 ` Christoffer Dall 2014-09-11 3:09 ` Christoffer Dall 2014-09-11 17:31 ` Eric Auger 2014-09-11 17:31 ` Eric Auger 2014-09-01 12:52 ` [RFC v2 3/9] ARM: KVM: Enable the KVM-VFIO device Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-01 12:52 ` [RFC v2 4/9] VFIO: platform: handler tests whether the IRQ is forwarded Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 8:44 ` Eric Auger 2014-09-11 8:44 ` Eric Auger 2014-09-11 17:05 ` Christoffer Dall 2014-09-11 17:05 ` Christoffer Dall 2014-09-11 18:07 ` Alex Williamson 2014-09-11 18:07 ` Alex Williamson 2014-09-11 17:08 ` Antonios Motakis 2014-09-11 17:08 ` Antonios Motakis 2014-09-01 12:52 ` [RFC v2 5/9] KVM: KVM-VFIO: update user API to program forwarded IRQ Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 8:49 ` Eric Auger 2014-09-11 8:49 ` Eric Auger 2014-09-11 17:08 ` Christoffer Dall [this message] 2014-09-11 17:08 ` Christoffer Dall 2014-09-01 12:52 ` [RFC v2 6/9] VFIO: Extend external user API Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 8:50 ` Eric Auger 2014-09-11 8:50 ` Eric Auger 2014-09-01 12:52 ` [RFC v2 7/9] KVM: KVM-VFIO: add new VFIO external API hooks Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 8:51 ` Eric Auger 2014-09-11 8:51 ` Eric Auger 2014-09-01 12:52 ` [RFC v2 8/9] KVM: KVM-VFIO: generic KVM_DEV_VFIO_DEVICE command and IRQ forwarding control Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 5:05 ` Alex Williamson 2014-09-11 5:05 ` Alex Williamson 2014-09-11 5:05 ` Alex Williamson 2014-09-11 12:04 ` Eric Auger 2014-09-11 12:04 ` Eric Auger 2014-09-11 15:59 ` Alex Williamson 2014-09-11 15:59 ` Alex Williamson 2014-09-11 17:24 ` Christoffer Dall 2014-09-11 17:24 ` Christoffer Dall 2014-09-11 17:22 ` Christoffer Dall 2014-09-11 17:22 ` Christoffer Dall 2014-09-11 17:10 ` Christoffer Dall 2014-09-11 17:10 ` Christoffer Dall 2014-09-11 18:14 ` Alex Williamson 2014-09-11 18:14 ` Alex Williamson 2014-09-11 21:59 ` Christoffer Dall 2014-09-11 21:59 ` Christoffer Dall 2014-09-11 9:35 ` Eric Auger 2014-09-11 9:35 ` Eric Auger 2014-09-11 15:47 ` Alex Williamson 2014-09-11 15:47 ` Alex Williamson 2014-09-11 15:47 ` Alex Williamson 2014-09-11 17:32 ` Christoffer Dall 2014-09-11 17:32 ` Christoffer Dall 2014-09-01 12:52 ` [RFC v2 9/9] KVM: KVM-VFIO: ARM " Eric Auger 2014-09-01 12:52 ` Eric Auger 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 3:10 ` Christoffer Dall 2014-09-02 21:05 ` [RFC v2 0/9] KVM-VFIO IRQ forward control Alex Williamson 2014-09-02 21:05 ` Alex Williamson 2014-09-05 12:52 ` Eric Auger 2014-09-05 12:52 ` Eric Auger 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 3:10 ` Christoffer Dall 2014-09-11 5:09 ` Alex Williamson 2014-09-11 5:09 ` Alex Williamson 2014-11-17 11:25 ` Wu, Feng 2014-11-17 11:25 ` Wu, Feng 2014-11-17 11:25 ` Wu, Feng 2014-11-17 13:41 ` Eric Auger 2014-11-17 13:41 ` Eric Auger 2014-11-17 13:41 ` Eric Auger 2014-11-17 13:45 ` Wu, Feng 2014-11-17 13:45 ` Wu, Feng 2014-11-17 13:45 ` Wu, Feng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140911170813.GC5535@lvm \ --to=christoffer.dall@linaro.org \ --cc=a.motakis@virtualopensystems.com \ --cc=a.rigo@virtualopensystems.com \ --cc=alex.williamson@redhat.com \ --cc=eric.auger@linaro.org \ --cc=eric.auger@st.com \ --cc=gleb@kernel.org \ --cc=joel.schopp@amd.com \ --cc=john.liuli@huawei.com \ --cc=kim.phillips@freescale.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=patches@linaro.org \ --cc=paulus@samba.org \ --cc=pbonzini@redhat.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.