[PATCH] regmap:change struct regmap's internal locks as union

[PATCH] regmap:change struct regmap's internal locks as union

[Wang, Yalin]

this patch change struct regmap->mutex and struct regmap->spinlock
as an union, because these 2 members are only used one of them,
we change it to shrink the struct size.

Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
---
 drivers/base/regmap/internal.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index bfc90b8..0da5865 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -49,8 +49,10 @@ struct regmap_async {
 };
 
 struct regmap {
-	struct mutex mutex;
-	spinlock_t spinlock;
+	union {
+		struct mutex mutex;
+		spinlock_t spinlock;
+	};
 	unsigned long spinlock_flags;
 	regmap_lock lock;
 	regmap_unlock unlock;
-- 
2.1.0

[PATCH] regmap:change struct regmap's internal locks as union

[Wang, Yalin]

this patch change struct regmap->mutex and struct regmap->spinlock
as an union, because these 2 members are only used one of them,
we change it to shrink the struct size.

Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
---
 drivers/base/regmap/internal.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index bfc90b8..0da5865 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -49,8 +49,10 @@ struct regmap_async {
 };
 
 struct regmap {
-	struct mutex mutex;
-	spinlock_t spinlock;
+	union {
+		struct mutex mutex;
+		spinlock_t spinlock;
+	};
 	unsigned long spinlock_flags;
 	regmap_lock lock;
 	regmap_unlock unlock;
-- 
2.1.0

Re: [PATCH] regmap:change struct regmap's internal locks as union

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

On Thu, Sep 11, 2014 at 04:19:49PM +0800, Wang, Yalin wrote:
> this patch change struct regmap->mutex and struct regmap->spinlock
> as an union, because these 2 members are only used one of them,
> we change it to shrink the struct size.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[PATCH] regmap:change struct regmap's internal locks as union

[Mark Brown]

On Thu, Sep 11, 2014 at 04:19:49PM +0800, Wang, Yalin wrote:
> this patch change struct regmap->mutex and struct regmap->spinlock
> as an union, because these 2 members are only used one of them,
> we change it to shrink the struct size.

Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140912/da7860fd/attachment.sig>

[PATCH] regmap:change spinlock_flags into the union

[Wang, Yalin]

This patch move struct regmap.spinlock_flags into the union of
spinlock, so that we can shrink struct regmap size.

Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
---
 drivers/base/regmap/internal.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 0da5865..8e94584 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -51,9 +51,11 @@ struct regmap_async {
 struct regmap {
 	union {
 		struct mutex mutex;
-		spinlock_t spinlock;
+		struct {
+			spinlock_t spinlock;
+			unsigned long spinlock_flags;
+		};
 	};
-	unsigned long spinlock_flags;
 	regmap_lock lock;
 	regmap_unlock unlock;
 	void *lock_arg; /* This is passed to lock/unlock functions */
-- 
2.1.3

[PATCH] regmap:change spinlock_flags into the union

[Wang, Yalin]

This patch move struct regmap.spinlock_flags into the union of
spinlock, so that we can shrink struct regmap size.

Signed-off-by: Yalin Wang <yalin.wang@sonymobile.com>
---
 drivers/base/regmap/internal.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 0da5865..8e94584 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -51,9 +51,11 @@ struct regmap_async {
 struct regmap {
 	union {
 		struct mutex mutex;
-		spinlock_t spinlock;
+		struct {
+			spinlock_t spinlock;
+			unsigned long spinlock_flags;
+		};
 	};
-	unsigned long spinlock_flags;
 	regmap_lock lock;
 	regmap_unlock unlock;
 	void *lock_arg; /* This is passed to lock/unlock functions */
-- 
2.1.3

Re: [PATCH] regmap:change spinlock_flags into the union

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

On Mon, Dec 15, 2014 at 04:05:50PM +0800, Wang, Yalin wrote:
> This patch move struct regmap.spinlock_flags into the union of
> spinlock, so that we can shrink struct regmap size.

Applied, thanks.  Please always remember to CC your posts to the
relevant mailing lists - in the case of regmap that's linux-kernel.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[PATCH] regmap:change spinlock_flags into the union

[Mark Brown]

On Mon, Dec 15, 2014 at 04:05:50PM +0800, Wang, Yalin wrote:
> This patch move struct regmap.spinlock_flags into the union of
> spinlock, so that we can shrink struct regmap size.

Applied, thanks.  Please always remember to CC your posts to the
relevant mailing lists - in the case of regmap that's linux-kernel.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141215/8ad3b2a0/attachment-0001.sig>