From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Konstantin Khlebnikov <k.khlebnikov@samsung.com>,
Rafael Aquini <aquini@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH v2 4/6] mm: introduce common page state for ballooned memory
Date: Fri, 12 Sep 2014 22:42:21 -0700 [thread overview]
Message-ID: <20140912224221.9ee5888a.akpm@linux-foundation.org> (raw)
In-Reply-To: <CALYGNiM0Uh1KG8Z6pFEAn=uxZBRPfHDffXjKkKJoG-K0hCaqaA@mail.gmail.com>
On Sat, 13 Sep 2014 09:26:49 +0400 Konstantin Khlebnikov <koct9i@gmail.com> wrote:
> >
> > Did we really need to put the BalloonPages count into per-zone vmstat,
> > global vmstat and /proc/meminfo? Seems a bit overkillish - why so
> > important?
>
> Balloon grabs random pages, their distribution among numa nodes might
> be important.
> But I know nobody who uses numa-aware vm together with ballooning.
>
> Probably it's better to drop per-zone vmstat and line from meminfo,
> global vmstat counter should be enough.
Yes, the less we add the better - we can always add stuff later if
there is a demonstrated need.
> >
> > Consuming another page flag is a big deal. We keep on nearly running
> > out and one day we'll run out for real. page-flags-layout.h is
> > incomprehensible. How many flags do we have left (worst-case) with this
> > change? Is there no other way? Needs extraordinary justification,
> > please.
>
> PageBalloon is not a page flags, it's like PageBuddy -- special state
> of _mapcount (-256 in this case).
> The same was in v1 and is written in the comment above.
oop sorry, I got confused about KPF_BALLOON.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Konstantin Khlebnikov <k.khlebnikov@samsung.com>,
Rafael Aquini <aquini@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH v2 4/6] mm: introduce common page state for ballooned memory
Date: Fri, 12 Sep 2014 22:42:21 -0700 [thread overview]
Message-ID: <20140912224221.9ee5888a.akpm@linux-foundation.org> (raw)
In-Reply-To: <CALYGNiM0Uh1KG8Z6pFEAn=uxZBRPfHDffXjKkKJoG-K0hCaqaA@mail.gmail.com>
On Sat, 13 Sep 2014 09:26:49 +0400 Konstantin Khlebnikov <koct9i@gmail.com> wrote:
> >
> > Did we really need to put the BalloonPages count into per-zone vmstat,
> > global vmstat and /proc/meminfo? Seems a bit overkillish - why so
> > important?
>
> Balloon grabs random pages, their distribution among numa nodes might
> be important.
> But I know nobody who uses numa-aware vm together with ballooning.
>
> Probably it's better to drop per-zone vmstat and line from meminfo,
> global vmstat counter should be enough.
Yes, the less we add the better - we can always add stuff later if
there is a demonstrated need.
> >
> > Consuming another page flag is a big deal. We keep on nearly running
> > out and one day we'll run out for real. page-flags-layout.h is
> > incomprehensible. How many flags do we have left (worst-case) with this
> > change? Is there no other way? Needs extraordinary justification,
> > please.
>
> PageBalloon is not a page flags, it's like PageBuddy -- special state
> of _mapcount (-256 in this case).
> The same was in v1 and is written in the comment above.
oop sorry, I got confused about KPF_BALLOON.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-13 5:41 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-30 16:41 [PATCH v2 0/6] mm/balloon_compaction: fixes and cleanups Konstantin Khlebnikov
2014-08-30 16:41 ` Konstantin Khlebnikov
2014-08-30 16:41 ` [PATCH v2 1/6] mm/balloon_compaction: ignore anonymous pages Konstantin Khlebnikov
2014-08-30 16:41 ` Konstantin Khlebnikov
2014-09-02 12:29 ` Rafael Aquini
2014-09-02 12:29 ` Rafael Aquini
2014-08-30 16:41 ` [PATCH v2 2/6] mm/balloon_compaction: keep ballooned pages away from normal migration path Konstantin Khlebnikov
2014-08-30 16:41 ` Konstantin Khlebnikov
2014-09-02 12:31 ` Rafael Aquini
2014-09-02 12:31 ` Rafael Aquini
2014-08-30 16:41 ` [PATCH v2 3/6] mm/balloon_compaction: isolate balloon pages without lru_lock Konstantin Khlebnikov
2014-08-30 16:41 ` Konstantin Khlebnikov
2014-09-02 12:32 ` Rafael Aquini
2014-09-02 12:32 ` Rafael Aquini
2014-08-30 16:41 ` [PATCH v2 4/6] mm: introduce common page state for ballooned memory Konstantin Khlebnikov
2014-08-30 16:41 ` Konstantin Khlebnikov
2014-09-02 12:53 ` Rafael Aquini
2014-09-02 12:53 ` Rafael Aquini
2014-09-12 23:51 ` Andrew Morton
2014-09-12 23:51 ` Andrew Morton
2014-09-13 5:26 ` Konstantin Khlebnikov
2014-09-13 5:26 ` Konstantin Khlebnikov
2014-09-13 5:42 ` Andrew Morton [this message]
2014-09-13 5:42 ` Andrew Morton
2014-09-13 8:22 ` Konstantin Khlebnikov
2014-09-19 21:35 ` Andrew Morton
2014-09-19 21:35 ` Andrew Morton
2014-09-20 5:25 ` Konstantin Khlebnikov
2014-09-20 5:25 ` Konstantin Khlebnikov
2014-09-20 6:23 ` Andrew Morton
2014-09-20 6:23 ` Andrew Morton
2014-09-22 18:40 ` Konstantin Khlebnikov
2014-09-22 18:40 ` Konstantin Khlebnikov
2014-09-22 19:22 ` Rafael Aquini
2014-09-22 19:22 ` Rafael Aquini
2014-09-22 20:06 ` Konstantin Khlebnikov
2014-09-22 20:06 ` Konstantin Khlebnikov
2014-09-22 20:22 ` Rafael Aquini
2014-09-22 20:22 ` Rafael Aquini
2014-09-22 20:46 ` Konstantin Khlebnikov
2014-09-22 20:46 ` Konstantin Khlebnikov
2014-09-13 14:03 ` Sasha Levin
2014-09-13 14:03 ` Sasha Levin
2014-08-30 16:41 ` [PATCH v2 5/6] mm/balloon_compaction: use common page ballooning Konstantin Khlebnikov
2014-08-30 16:41 ` Konstantin Khlebnikov
2014-09-02 12:57 ` Rafael Aquini
2014-09-02 12:57 ` Rafael Aquini
2014-09-12 23:57 ` Andrew Morton
2014-09-12 23:57 ` Andrew Morton
2014-08-30 16:41 ` [PATCH v2 6/6] mm/balloon_compaction: general cleanup Konstantin Khlebnikov
2014-08-30 16:41 ` Konstantin Khlebnikov
2014-09-02 13:09 ` Rafael Aquini
2014-09-02 13:09 ` Rafael Aquini
2014-09-13 0:04 ` Andrew Morton
2014-09-13 0:04 ` Andrew Morton
2014-09-13 0:06 ` Andrew Morton
2014-09-13 0:06 ` Andrew Morton
2014-09-13 5:43 ` Konstantin Khlebnikov
2014-09-13 5:43 ` Konstantin Khlebnikov
2014-09-13 0:09 ` [PATCH v2 0/6] mm/balloon_compaction: fixes and cleanups Andrew Morton
2014-09-13 0:09 ` Andrew Morton
2014-09-13 5:01 ` Konstantin Khlebnikov
2014-09-13 5:01 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912224221.9ee5888a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=k.khlebnikov@samsung.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.