All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [slave-dma:for-linus 20/20] drivers/spi/spi-pxa2xx-pci.c:70:3: error: unknown field 'max_clk_rate' specified in initializer
       [not found] ` <20140911101750.GP13406@lahna.fi.intel.com>
@ 2014-09-13 17:00   ` Mark Brown
  2014-09-15  8:06     ` Mika Westerberg
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2014-09-13 17:00 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: kbuild test robot, Andy Shevchenko, Vinod Koul, kbuild-all, linux-next

[-- Attachment #1: Type: text/plain, Size: 1246 bytes --]

On Thu, Sep 11, 2014 at 01:17:50PM +0300, Mika Westerberg wrote:

> Vinod, this has dependency to the SPI tree. I suppose right way to
> handle this is to merge Mark's topic/pxa2xx branch into this. Or
> alternatively Mark can make an immutable branch containing the missing
> commit that you can merge.

I've tagged this here, please do remember to coordinate dependencies
when making this sort of multi-tree change:

The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9:

  Linux 3.17-rc1 (2014-08-16 10:40:26 -0600)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-pxa2xx-clk

for you to fetch changes up to afa93c9017fd48d4d5265854c75f5fcde0871548:

  spi/pxa2xx-pci: Add common clock framework support in PCI glue layer (2014-08-16 17:19:50 -0500)

----------------------------------------------------------------
spi/pxa2xx: Add clock support

----------------------------------------------------------------
Chew, Chiau Ee (1):
      spi/pxa2xx-pci: Add common clock framework support in PCI glue layer

 drivers/spi/Kconfig          |  2 +-
 drivers/spi/spi-pxa2xx-pci.c | 21 ++++++++++++++++++++-
 2 files changed, 21 insertions(+), 2 deletions(-)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [slave-dma:for-linus 20/20] drivers/spi/spi-pxa2xx-pci.c:70:3: error: unknown field 'max_clk_rate' specified in initializer
  2014-09-13 17:00   ` [slave-dma:for-linus 20/20] drivers/spi/spi-pxa2xx-pci.c:70:3: error: unknown field 'max_clk_rate' specified in initializer Mark Brown
@ 2014-09-15  8:06     ` Mika Westerberg
  2014-09-16  4:52       ` Vinod Koul
  0 siblings, 1 reply; 5+ messages in thread
From: Mika Westerberg @ 2014-09-15  8:06 UTC (permalink / raw)
  To: Mark Brown
  Cc: kbuild test robot, Andy Shevchenko, Vinod Koul, kbuild-all, linux-next

On Sat, Sep 13, 2014 at 10:00:53AM -0700, Mark Brown wrote:
> On Thu, Sep 11, 2014 at 01:17:50PM +0300, Mika Westerberg wrote:
> 
> > Vinod, this has dependency to the SPI tree. I suppose right way to
> > handle this is to merge Mark's topic/pxa2xx branch into this. Or
> > alternatively Mark can make an immutable branch containing the missing
> > commit that you can merge.
> 
> I've tagged this here, please do remember to coordinate dependencies
> when making this sort of multi-tree change:

Thanks Mark!

Vinod, can you pull this to your -next branch?

And sorry about this, we will make sure that next time we state all
the dependencies beforehand.

> 
> The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9:
> 
>   Linux 3.17-rc1 (2014-08-16 10:40:26 -0600)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-pxa2xx-clk
> 
> for you to fetch changes up to afa93c9017fd48d4d5265854c75f5fcde0871548:
> 
>   spi/pxa2xx-pci: Add common clock framework support in PCI glue layer (2014-08-16 17:19:50 -0500)
> 
> ----------------------------------------------------------------
> spi/pxa2xx: Add clock support
> 
> ----------------------------------------------------------------
> Chew, Chiau Ee (1):
>       spi/pxa2xx-pci: Add common clock framework support in PCI glue layer
> 
>  drivers/spi/Kconfig          |  2 +-
>  drivers/spi/spi-pxa2xx-pci.c | 21 ++++++++++++++++++++-
>  2 files changed, 21 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [slave-dma:for-linus 20/20] drivers/spi/spi-pxa2xx-pci.c:70:3: error: unknown field 'max_clk_rate' specified in initializer
  2014-09-15  8:06     ` Mika Westerberg
@ 2014-09-16  4:52       ` Vinod Koul
  2014-09-16  7:35         ` Andy Shevchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2014-09-16  4:52 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: Mark Brown, kbuild test robot, Andy Shevchenko, kbuild-all, linux-next

On Mon, Sep 15, 2014 at 11:06:40AM +0300, Mika Westerberg wrote:
> On Sat, Sep 13, 2014 at 10:00:53AM -0700, Mark Brown wrote:
> > On Thu, Sep 11, 2014 at 01:17:50PM +0300, Mika Westerberg wrote:
> > 
> > > Vinod, this has dependency to the SPI tree. I suppose right way to
> > > handle this is to merge Mark's topic/pxa2xx branch into this. Or
> > > alternatively Mark can make an immutable branch containing the missing
> > > commit that you can merge.
> > 
> > I've tagged this here, please do remember to coordinate dependencies
> > when making this sort of multi-tree change:
> 
> Thanks Mark!
> 
> Vinod, can you pull this to your -next branch?
Done, can you verify merge was okay as I had few conflicts.

-- 
~Vinod
> 
> And sorry about this, we will make sure that next time we state all
> the dependencies beforehand.
> 
> > 
> > The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9:
> > 
> >   Linux 3.17-rc1 (2014-08-16 10:40:26 -0600)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-pxa2xx-clk
> > 
> > for you to fetch changes up to afa93c9017fd48d4d5265854c75f5fcde0871548:
> > 
> >   spi/pxa2xx-pci: Add common clock framework support in PCI glue layer (2014-08-16 17:19:50 -0500)
> > 
> > ----------------------------------------------------------------
> > spi/pxa2xx: Add clock support
> > 
> > ----------------------------------------------------------------
> > Chew, Chiau Ee (1):
> >       spi/pxa2xx-pci: Add common clock framework support in PCI glue layer
> > 
> >  drivers/spi/Kconfig          |  2 +-
> >  drivers/spi/spi-pxa2xx-pci.c | 21 ++++++++++++++++++++-
> >  2 files changed, 21 insertions(+), 2 deletions(-)
> 
> 

-- 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [slave-dma:for-linus 20/20] drivers/spi/spi-pxa2xx-pci.c:70:3: error: unknown field 'max_clk_rate' specified in initializer
  2014-09-16  4:52       ` Vinod Koul
@ 2014-09-16  7:35         ` Andy Shevchenko
  2014-09-16  8:19           ` Vinod Koul
  0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2014-09-16  7:35 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Mika Westerberg, Mark Brown, kbuild test robot, Andy Shevchenko,
	kbuild-all, linux-next

On Tue, 2014-09-16 at 10:22 +0530, Vinod Koul wrote:
> On Mon, Sep 15, 2014 at 11:06:40AM +0300, Mika Westerberg wrote:
> > On Sat, Sep 13, 2014 at 10:00:53AM -0700, Mark Brown wrote:
> > > On Thu, Sep 11, 2014 at 01:17:50PM +0300, Mika Westerberg wrote:
> > > 
> > > > Vinod, this has dependency to the SPI tree. I suppose right way to
> > > > handle this is to merge Mark's topic/pxa2xx branch into this. Or
> > > > alternatively Mark can make an immutable branch containing the missing
> > > > commit that you can merge.
> > > 
> > > I've tagged this here, please do remember to coordinate dependencies
> > > when making this sort of multi-tree change:
> > 
> > Thanks Mark!
> > 
> > Vinod, can you pull this to your -next branch?
> Done, can you verify merge was okay as I had few conflicts.

There is one line missed:

+               .max_clk_rate = 50000000,

In the PORT_BYT section of the spi_info_configs[].

> 
> -- 
> ~Vinod
> > 
> > And sorry about this, we will make sure that next time we state all
> > the dependencies beforehand.
> > 
> > > 
> > > The following changes since commit 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9:
> > > 
> > >   Linux 3.17-rc1 (2014-08-16 10:40:26 -0600)
> > > 
> > > are available in the git repository at:
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-pxa2xx-clk
> > > 
> > > for you to fetch changes up to afa93c9017fd48d4d5265854c75f5fcde0871548:
> > > 
> > >   spi/pxa2xx-pci: Add common clock framework support in PCI glue layer (2014-08-16 17:19:50 -0500)
> > > 
> > > ----------------------------------------------------------------
> > > spi/pxa2xx: Add clock support
> > > 
> > > ----------------------------------------------------------------
> > > Chew, Chiau Ee (1):
> > >       spi/pxa2xx-pci: Add common clock framework support in PCI glue layer
> > > 
> > >  drivers/spi/Kconfig          |  2 +-
> > >  drivers/spi/spi-pxa2xx-pci.c | 21 ++++++++++++++++++++-
> > >  2 files changed, 21 insertions(+), 2 deletions(-)
> > 
> > 
> 


-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [slave-dma:for-linus 20/20] drivers/spi/spi-pxa2xx-pci.c:70:3: error: unknown field 'max_clk_rate' specified in initializer
  2014-09-16  7:35         ` Andy Shevchenko
@ 2014-09-16  8:19           ` Vinod Koul
  0 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2014-09-16  8:19 UTC (permalink / raw)
  Cc: Mika Westerberg, Mark Brown, kbuild test robot, Andy Shevchenko,
	kbuild-all, linux-next

On Tue, Sep 16, 2014 at 10:35:55AM +0300, Andy Shevchenko wrote:
> On Tue, 2014-09-16 at 10:22 +0530, Vinod Koul wrote:
> > On Mon, Sep 15, 2014 at 11:06:40AM +0300, Mika Westerberg wrote:
> > > On Sat, Sep 13, 2014 at 10:00:53AM -0700, Mark Brown wrote:
> > > > On Thu, Sep 11, 2014 at 01:17:50PM +0300, Mika Westerberg wrote:
> > > > 
> > > > > Vinod, this has dependency to the SPI tree. I suppose right way to
> > > > > handle this is to merge Mark's topic/pxa2xx branch into this. Or
> > > > > alternatively Mark can make an immutable branch containing the missing
> > > > > commit that you can merge.
> > > > 
> > > > I've tagged this here, please do remember to coordinate dependencies
> > > > when making this sort of multi-tree change:
> > > 
> > > Thanks Mark!
> > > 
> > > Vinod, can you pull this to your -next branch?
> > Done, can you verify merge was okay as I had few conflicts.
> 
> There is one line missed:
> 
> +               .max_clk_rate = 50000000,
> 
> In the PORT_BYT section of the spi_info_configs[].
Okay fixed this one..

-- 
~Vinod

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-09-16  8:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <5411735d.SAoL/AZyi+bJWC6n%fengguang.wu@intel.com>
     [not found] ` <20140911101750.GP13406@lahna.fi.intel.com>
2014-09-13 17:00   ` [slave-dma:for-linus 20/20] drivers/spi/spi-pxa2xx-pci.c:70:3: error: unknown field 'max_clk_rate' specified in initializer Mark Brown
2014-09-15  8:06     ` Mika Westerberg
2014-09-16  4:52       ` Vinod Koul
2014-09-16  7:35         ` Andy Shevchenko
2014-09-16  8:19           ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.