From: Maxime Ripard <maxime.ripard@free-electrons.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com> Cc: IIO <linux-iio@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, DEVICE TREE <devicetree@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>, Carlo Caione <carlo@caione.org>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Aaron Lu <aaron.lu@intel.com>, Alan Cox <alan@linux.intel.com>, Jean Delvare <khali@linux-fr.org>, Samuel Ortiz <sameo@linux.intel.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Grant Likely <grant.likely@linaro.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Hartmut Knaack <knaack.h@gmx.de>, Fugang Duan <B38611@freescale.com>, Arnd Bergmann <arnd@arndb.de>, Zubair Lutfullah <zubair.lutfullah@gmail.com>, Sebastian Reichel <sre@debian.org>, Johannes Thumshirn <johannes.thumshirn@men.de>, Philippe Reynes <tremyfr@yahoo.fr>, Angelo Compagnucci <angelo.compagnucci@gmail.com>, Doug Anderson <dianders@chromium.org>, Ramakrishna Pallala <ramakrishna.pallala@intel.com>, Peter Meerwald <pmeerw@pmeerw.net> Subject: Re: [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Date: Mon, 15 Sep 2014 11:02:55 +0200 [thread overview] Message-ID: <20140915090255.GD31276@lukather> (raw) In-Reply-To: <20140912123645.3bc6058f@ultegra> [-- Attachment #1: Type: text/plain, Size: 1971 bytes --] On Fri, Sep 12, 2014 at 12:36:45PM -0700, Jacob Pan wrote: > On Fri, 12 Sep 2014 17:18:24 +0200 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > On Thu, Sep 11, 2014 at 04:15:52PM -0700, Jacob Pan wrote: > > > XPowers AXP288 is a customized PMIC found on some Intel Baytrail-CR > > > platforms. It comes with sub-functions such as USB charging, fuel > > > gauge, ADC, and many LDO and BUCK channels. > > > > > > By extending the existing AXP20x driver, this patchset adds basic > > > support for AXP288 PMIC with GPADC as one MFD cell device driver. > > > It also adds hooks for ACPI opregion handler driver which can be > > > used to handle ACPI requests. > > > > > > Currently, the PMIC driver in this patchset does not support > > > platform data enumeration. But when ACPI _DSD and unified device > > > properties become available, cell devices with platform data will > > > be added. > > > > > > This patch does not use intel_soc_pmic core for i2c and regmap > > > handling in that axp288 shares similar programming interface with > > > other Xpower PMICs supported in axp20x.c. Therefore, extending > > > axp20x.c to include axp288 makes more sense. > > > > > > Changes > > > v3: - put all file rename changes in 1/5 > > > > The variables renaming are still not in 1/5.... > > > 1/5 is for file rename such that the follow up patches are more > readable. Which is exactly my point. So why don't you apply it to the variable renames as well? > There are so many details in variable rename, I think it > belongs to the patch that expands the new device support. This has nothing to do in this patch. Remember that one patch should do one thing. You're obviously doing 2 in the second patch, and just like you pointed out, the renaming just make the whole thing less readable. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> To: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Cc: IIO <linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, DEVICE TREE <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>, Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Aaron Lu <aaron.lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>, Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>, Fugang Duan <B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>, Zubair Lutfullah <zubair.lutfullah-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Sebastian Reichel <sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>, Johannes Thumshirn <johannes.thumshirn-csrFAY9JiS4@public.gmane.org>, Philippe Reynes <tremyfr-Qt13gs6zZMY@public.gmane.org> Subject: Re: [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Date: Mon, 15 Sep 2014 11:02:55 +0200 [thread overview] Message-ID: <20140915090255.GD31276@lukather> (raw) In-Reply-To: <20140912123645.3bc6058f@ultegra> [-- Attachment #1: Type: text/plain, Size: 2002 bytes --] On Fri, Sep 12, 2014 at 12:36:45PM -0700, Jacob Pan wrote: > On Fri, 12 Sep 2014 17:18:24 +0200 > Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote: > > > On Thu, Sep 11, 2014 at 04:15:52PM -0700, Jacob Pan wrote: > > > XPowers AXP288 is a customized PMIC found on some Intel Baytrail-CR > > > platforms. It comes with sub-functions such as USB charging, fuel > > > gauge, ADC, and many LDO and BUCK channels. > > > > > > By extending the existing AXP20x driver, this patchset adds basic > > > support for AXP288 PMIC with GPADC as one MFD cell device driver. > > > It also adds hooks for ACPI opregion handler driver which can be > > > used to handle ACPI requests. > > > > > > Currently, the PMIC driver in this patchset does not support > > > platform data enumeration. But when ACPI _DSD and unified device > > > properties become available, cell devices with platform data will > > > be added. > > > > > > This patch does not use intel_soc_pmic core for i2c and regmap > > > handling in that axp288 shares similar programming interface with > > > other Xpower PMICs supported in axp20x.c. Therefore, extending > > > axp20x.c to include axp288 makes more sense. > > > > > > Changes > > > v3: - put all file rename changes in 1/5 > > > > The variables renaming are still not in 1/5.... > > > 1/5 is for file rename such that the follow up patches are more > readable. Which is exactly my point. So why don't you apply it to the variable renames as well? > There are so many details in variable rename, I think it > belongs to the patch that expands the new device support. This has nothing to do in this patch. Remember that one patch should do one thing. You're obviously doing 2 in the second patch, and just like you pointed out, the renaming just make the whole thing less readable. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-15 9:05 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-11 23:15 [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Jacob Pan 2014-09-11 23:15 ` Jacob Pan 2014-09-11 23:15 ` [PATCH v3 1/5] mfd/axp20x: rename files to support more devices Jacob Pan 2014-09-11 23:15 ` Jacob Pan 2014-09-13 20:00 ` Jonathan Cameron 2014-09-13 20:00 ` Jonathan Cameron 2014-09-15 16:28 ` Jacob Pan 2014-09-15 16:28 ` Jacob Pan 2014-09-15 22:18 ` Lee Jones 2014-09-15 22:18 ` Lee Jones 2014-09-11 23:15 ` [PATCH v3 2/5] mfd/axp2xx: extend axp20x to support axp288 pmic Jacob Pan 2014-09-11 23:15 ` Jacob Pan 2014-09-15 22:22 ` Lee Jones 2014-09-15 22:22 ` Lee Jones 2014-09-15 22:32 ` Jacob Pan 2014-09-15 22:32 ` Jacob Pan 2014-09-15 23:34 ` Lee Jones 2014-09-15 23:34 ` Lee Jones 2014-09-11 23:15 ` [PATCH v3 3/5] regulator/axp20x: use axp2xx consolidated header Jacob Pan 2014-09-11 23:15 ` Jacob Pan 2014-09-13 20:01 ` Jonathan Cameron 2014-09-13 20:01 ` Jonathan Cameron 2014-09-11 23:15 ` [PATCH v3 4/5] iio/adc/axp288: add support for axp288 gpadc Jacob Pan 2014-09-11 23:15 ` Jacob Pan 2014-09-12 12:44 ` Peter Meerwald 2014-09-13 19:52 ` Jonathan Cameron 2014-09-14 13:09 ` Hartmut Knaack 2014-09-16 18:21 ` Jacob Pan 2014-09-16 22:24 ` Hartmut Knaack 2014-09-16 10:00 ` Jacob Pan 2014-09-11 23:15 ` [PATCH v3 5/5] iio: add documentation for current attribute Jacob Pan 2014-09-11 23:15 ` Jacob Pan 2014-09-13 19:55 ` Jonathan Cameron 2014-09-13 19:55 ` Jonathan Cameron 2014-09-14 13:13 ` Hartmut Knaack 2014-09-14 13:13 ` Hartmut Knaack 2014-09-15 20:29 ` Jacob Pan 2014-09-15 20:29 ` Jacob Pan 2014-09-12 15:18 ` [PATCH v3 0/5] Initial support for XPowers AXP288 PMIC Maxime Ripard 2014-09-12 15:18 ` Maxime Ripard 2014-09-12 19:36 ` Jacob Pan 2014-09-12 19:36 ` Jacob Pan 2014-09-15 9:02 ` Maxime Ripard [this message] 2014-09-15 9:02 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140915090255.GD31276@lukather \ --to=maxime.ripard@free-electrons.com \ --cc=B38611@freescale.com \ --cc=aaron.lu@intel.com \ --cc=alan@linux.intel.com \ --cc=angelo.compagnucci@gmail.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=carlo@caione.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=grant.likely@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=johannes.thumshirn@men.de \ --cc=khali@linux-fr.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=ramakrishna.pallala@intel.com \ --cc=robh+dt@kernel.org \ --cc=sameo@linux.intel.com \ --cc=sre@debian.org \ --cc=srinivas.pandruvada@linux.intel.com \ --cc=tremyfr@yahoo.fr \ --cc=zubair.lutfullah@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.