[U-Boot] [PATCH] usb: dfu: thor: gadget: Remove dead code

[U-Boot] [PATCH] usb: dfu: thor: gadget: Remove dead code

[Lukasz Majewski]

This code is not used anymore in the current DFU implementation and
can be safely removed.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
 drivers/usb/gadget/f_dfu.c  |  8 --------
 drivers/usb/gadget/f_thor.c | 10 ----------
 2 files changed, 18 deletions(-)

diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index 3e4f029..d040606 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -81,14 +81,6 @@ static struct usb_descriptor_header *dfu_runtime_descs[] = {
 	NULL,
 };
 
-static const struct usb_qualifier_descriptor dev_qualifier = {
-	.bLength =		sizeof dev_qualifier,
-	.bDescriptorType =	USB_DT_DEVICE_QUALIFIER,
-	.bcdUSB =		__constant_cpu_to_le16(0x0200),
-	.bDeviceClass =		USB_CLASS_VENDOR_SPEC,
-	.bNumConfigurations =	1,
-};
-
 static const char dfu_name[] = "Device Firmware Upgrade";
 
 /*
diff --git a/drivers/usb/gadget/f_thor.c b/drivers/usb/gadget/f_thor.c
index c85b0fb..78519fa 100644
--- a/drivers/usb/gadget/f_thor.c
+++ b/drivers/usb/gadget/f_thor.c
@@ -458,16 +458,6 @@ static struct usb_endpoint_descriptor hs_int_desc = {
 	.bInterval = 0x9,
 };
 
-static struct usb_qualifier_descriptor dev_qualifier = {
-	.bLength =		sizeof(dev_qualifier),
-	.bDescriptorType =	USB_DT_DEVICE_QUALIFIER,
-
-	.bcdUSB =		__constant_cpu_to_le16(0x0200),
-	.bDeviceClass =	USB_CLASS_VENDOR_SPEC,
-
-	.bNumConfigurations =	2,
-};
-
 /*
  * This attribute vendor descriptor is necessary for correct operation with
  * Windows version of THOR download program
-- 
2.0.0.rc2

[U-Boot] [PATCH] usb: dfu: thor: gadget: Remove dead code

[Marek Vasut]

On Thursday, September 11, 2014 at 03:26:10 PM, Lukasz Majewski wrote:
> This code is not used anymore in the current DFU implementation and
> can be safely removed.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>

How come the compiler didn't spew that this is unused ?

Best regards,
Marek Vasut

[U-Boot] [PATCH] usb: dfu: thor: gadget: Remove dead code

[Jeroen Hofstee]

Hello Marek,

On 11-09-14 17:47, Marek Vasut wrote:
> On Thursday, September 11, 2014 at 03:26:10 PM, Lukasz Majewski wrote:
>> This code is not used anymore in the current DFU implementation and
>> can be safely removed.
>>
>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> How come the compiler didn't spew that this is unused ?

gcc feature, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=13029.

Regards,
Jeroen

[U-Boot] [PATCH] usb: dfu: thor: gadget: Remove dead code

[Marek Vasut]

On Thursday, September 11, 2014 at 09:17:57 PM, Jeroen Hofstee wrote:
> Hello Marek,
> 
> On 11-09-14 17:47, Marek Vasut wrote:
> > On Thursday, September 11, 2014 at 03:26:10 PM, Lukasz Majewski wrote:
> >> This code is not used anymore in the current DFU implementation and
> >> can be safely removed.
> >> 
> >> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > 
> > How come the compiler didn't spew that this is unused ?
> 
> gcc feature, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=13029.

I see, thanks for pointing this out!

Best regards,
Marek Vasut

[U-Boot] [PATCH] usb: dfu: thor: gadget: Remove dead code

[Heiko Schocher]

Hello Lukasz,

Am 11.09.2014 15:26, schrieb Lukasz Majewski:
> This code is not used anymore in the current DFU implementation and
> can be safely removed.
>
> Signed-off-by: Lukasz Majewski<l.majewski@samsung.com>
> ---
>   drivers/usb/gadget/f_dfu.c  |  8 --------
>   drivers/usb/gadget/f_thor.c | 10 ----------
>   2 files changed, 18 deletions(-)

Thanks!

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[U-Boot] [PATCH] usb: dfu: thor: gadget: Remove dead code

[Lukasz Majewski]

Hi Lukasz,

> This code is not used anymore in the current DFU implementation and
> can be safely removed.

Applied to u-boot-dfu

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group