From: Mark Brown <broonie@kernel.org>
To: Jianqun <jay.xu@rock-chips.com>
Cc: heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.de, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, huangtao@rock-chips.com,
cf@rock-chips.com
Subject: Re: [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example
Date: Mon, 15 Sep 2014 09:45:50 -0700 [thread overview]
Message-ID: <20140915164550.GV7960@sirena.org.uk> (raw)
In-Reply-To: <1410665999-16718-1-git-send-email-jay.xu@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Sun, Sep 14, 2014 at 11:39:59AM +0800, Jianqun wrote:
> Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".
>
> Table 10-1 DMAC_BUS Request Mapping Table
> Req number Source Polarity
> 0 I2S tx High level
> 1 I2S rx High level
>
> Tested on RK3288 board.
>
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
> change since v1:
> - modify patch's changelog as Mark's suggestion
No, the patch has already been applied. Once a patch has been applied
don't resend it, it can't be re-applied. In this case the advice about
the changelog was something you should bear in mind for future
changelogs.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example
Date: Mon, 15 Sep 2014 09:45:50 -0700 [thread overview]
Message-ID: <20140915164550.GV7960@sirena.org.uk> (raw)
In-Reply-To: <1410665999-16718-1-git-send-email-jay.xu@rock-chips.com>
On Sun, Sep 14, 2014 at 11:39:59AM +0800, Jianqun wrote:
> Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".
>
> Table 10-1 DMAC_BUS Request Mapping Table
> Req number Source Polarity
> 0 I2S tx High level
> 1 I2S rx High level
>
> Tested on RK3288 board.
>
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
> change since v1:
> - modify patch's changelog as Mark's suggestion
No, the patch has already been applied. Once a patch has been applied
don't resend it, it can't be re-applied. In this case the advice about
the changelog was something you should bear in mind for future
changelogs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140915/efad01ea/attachment.sig>
next prev parent reply other threads:[~2014-09-15 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 1:04 [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number Jianqun
2014-09-13 1:04 ` Jianqun
2014-09-13 16:40 ` Mark Brown
2014-09-13 16:40 ` Mark Brown
2014-09-14 2:29 ` Jianqun
2014-09-14 2:29 ` Jianqun
2014-09-14 3:39 ` [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example Jianqun
2014-09-14 3:39 ` Jianqun
2014-09-15 16:45 ` Mark Brown [this message]
2014-09-15 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915164550.GV7960@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cf@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.