All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	shhuiw@163.com, qemu-devel@nongnu.org,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: delete cow block driver
Date: Wed, 17 Sep 2014 10:29:52 +0800	[thread overview]
Message-ID: <20140917022952.GB16646@fam-t430.nay.redhat.com> (raw)
In-Reply-To: <1410877464-20481-1-git-send-email-stefanha@redhat.com>

On Tue, 09/16 15:24, Stefan Hajnoczi wrote:
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index a685d02..56302c7 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -197,7 +197,7 @@
>  #       'file', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',
>  #       'host_floppy', 'http', 'https', 'nbd', 'parallels', 'qcow',
>  #       'qcow2', 'raw', 'tftp', 'vdi', 'vmdk', 'vpc', 'vvfat'
> -#       2.2: 'archipelago'
> +#       2.2: 'archipelago' added, 'cow' dropped
>  #
>  # @backing_file: #optional the name of the backing file (for copy-on-write)
>  #
> @@ -1149,7 +1149,7 @@
>  { 'enum': 'BlockdevDriver',
>    'data': [ 'archipelago', 'file', 'host_device', 'host_cdrom', 'host_floppy',
>              'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'blkdebug',
> -            'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels', 'qcow',
> +            'blkverify', 'bochs', 'cloop', 'dmg', 'parallels', 'qcow',
>              'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quorum' ] }
>  
>  ##
> @@ -1491,7 +1491,6 @@
>        'blkverify':  'BlockdevOptionsBlkverify',
>        'bochs':      'BlockdevOptionsGenericFormat',
>        'cloop':      'BlockdevOptionsGenericFormat',
> -      'cow':        'BlockdevOptionsGenericCOWFormat',
>        'dmg':        'BlockdevOptionsGenericFormat',
>        'parallels':  'BlockdevOptionsGenericFormat',
>        'qcow':       'BlockdevOptionsGenericCOWFormat',

Have a conflict with "[PATCH v7 0/3] block: Introduce "null" drivers" which you
applied, where these lists are sorted alphabetically.

Otherwise looks good to me.

Thanks,
Fam

  parent reply	other threads:[~2014-09-17  2:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 14:24 [Qemu-devel] [PATCH] block: delete cow block driver Stefan Hajnoczi
2014-09-16 15:56 ` Markus Armbruster
2014-09-17  2:29 ` Fam Zheng [this message]
2014-09-19  9:40 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140917022952.GB16646@fam-t430.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shhuiw@163.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.