From: Nishanth Menon <nm@ti.com> To: Sebastian Reichel <sre@kernel.org>, Lee Jones <lee.jones@linaro.org> Cc: Lee Jones <lee.jones@linaro.org>, Samuel Ortiz <sameo@linux.intel.com>, Tony Lindgren <tony@atomide.com>, <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Date: Wed, 17 Sep 2014 12:01:04 -0500 [thread overview] Message-ID: <20140917170104.GA26864@kahuna> (raw) In-Reply-To: <20140917165529.GA24699@earth.universe> On 18:55-20140917, Sebastian Reichel wrote: > On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > > ti,system-power-controller is more or less the standard way of > > > indicating that the PMIC is the system wide power controller and hence > > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > > many Maxim PMIC drivers follow the same style. > > > > > > So support 'ti,system-power-controller' in addition to the usual > > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > > switching off the system. > > > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > > --- > > > > > > V2: picked up documentation suggestion from Sebastien > > > > It would be good to get Sebastian's Ack. > > Acked-By: Sebastian Reichel <sre@kernel.org> Thanks. > > [...] > > > > +- ti,system-power-controller: This indicates that TWL4030 is the > > > + power supply master of the system. With this flag, the chip will > > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > > + system poweroffs. > > One minor thing: While the documentation is updated you may want to > fix the typo "will initiates" to "will initiate" (or just drop the > "will"). Updated v3 patch with your ack and correction to drop "will" below. I will assume I wont need to repost the following update. Do let me know if you'd like me to. ---8<--- >From ae3bcfc74080b14f9fd0178f6526bf8f34a8c865 Mon Sep 17 00:00:00 2001 From: Nishanth Menon <nm@ti.com> Date: Wed, 3 Sep 2014 13:55:02 -0500 Subject: [PATCH V3 1/2 ] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm@ti.com> Acked-By: Sebastian Reichel <sre@kernel.org> --- .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..15a63e6 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller: This indicates that TWL4030 is the + power supply master of the system. With this flag, the chip + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: &i2c1 { -- 1.7.9.5 -- Regards, Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> To: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Date: Wed, 17 Sep 2014 12:01:04 -0500 [thread overview] Message-ID: <20140917170104.GA26864@kahuna> (raw) In-Reply-To: <20140917165529.GA24699-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org> On 18:55-20140917, Sebastian Reichel wrote: > On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote: > > On Wed, 17 Sep 2014, Nishanth Menon wrote: > > > ti,system-power-controller is more or less the standard way of > > > indicating that the PMIC is the system wide power controller and hence > > > may be used to switch off the system. Almost ALL TI PMIC drivers and > > > many Maxim PMIC drivers follow the same style. > > > > > > So support 'ti,system-power-controller' in addition to the usual > > > 'ti,use_poweroff' to indicate that the PMIC instance has control for > > > switching off the system. > > > > > > Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> > > > --- > > > > > > V2: picked up documentation suggestion from Sebastien > > > > It would be good to get Sebastian's Ack. > > Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Thanks. > > [...] > > > > +- ti,system-power-controller: This indicates that TWL4030 is the > > > + power supply master of the system. With this flag, the chip will > > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the > > > + system poweroffs. > > One minor thing: While the documentation is updated you may want to > fix the typo "will initiates" to "will initiate" (or just drop the > "will"). Updated v3 patch with your ack and correction to drop "will" below. I will assume I wont need to repost the following update. Do let me know if you'd like me to. ---8<--- >From ae3bcfc74080b14f9fd0178f6526bf8f34a8c865 Mon Sep 17 00:00:00 2001 From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> Date: Wed, 3 Sep 2014 13:55:02 -0500 Subject: [PATCH V3 1/2 ] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control ti,system-power-controller is more or less the standard way of indicating that the PMIC is the system wide power controller and hence may be used to switch off the system. Almost ALL TI PMIC drivers and many Maxim PMIC drivers follow the same style. So support 'ti,system-power-controller' in addition to the usual 'ti,use_poweroff' to indicate that the PMIC instance has control for switching off the system. Signed-off-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> Acked-By: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> --- .../devicetree/bindings/mfd/twl4030-power.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/twl4030-power.txt b/Documentation/devicetree/bindings/mfd/twl4030-power.txt index b9ee7b9..15a63e6 100644 --- a/Documentation/devicetree/bindings/mfd/twl4030-power.txt +++ b/Documentation/devicetree/bindings/mfd/twl4030-power.txt @@ -23,8 +23,13 @@ down during off-idle. Note that this does not work on all boards depending on how the external oscillator is wired. Optional properties: -- ti,use_poweroff: With this flag, the chip will initiates an ACTIVE-to-OFF or - SLEEP-to-OFF transition when the system poweroffs. + +- ti,system-power-controller: This indicates that TWL4030 is the + power supply master of the system. With this flag, the chip + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the + system poweroffs. + +- ti,use_poweroff: Deprecated name for ti,system-power-controller Example: &i2c1 { -- 1.7.9.5 -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-17 17:01 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-17 12:34 [PATCH V2 0/2] mfd: twl4030-power: support ti,system-power-controller Nishanth Menon 2014-09-17 12:34 ` Nishanth Menon 2014-09-17 12:34 ` [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Nishanth Menon 2014-09-17 12:34 ` Nishanth Menon 2014-09-17 15:44 ` Lee Jones 2014-09-17 16:55 ` Sebastian Reichel 2014-09-17 16:55 ` Sebastian Reichel 2014-09-17 17:01 ` Nishanth Menon [this message] 2014-09-17 17:01 ` Nishanth Menon 2014-09-17 21:39 ` Lee Jones 2014-09-17 12:34 ` [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off Nishanth Menon 2014-09-17 12:34 ` Nishanth Menon 2014-09-17 21:39 ` Lee Jones 2014-09-17 21:39 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140917170104.GA26864@kahuna \ --to=nm@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=sameo@linux.intel.com \ --cc=sre@kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.