* [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
@ 2014-09-09 14:52 ` Mel Gorman
0 siblings, 0 replies; 8+ messages in thread
From: Mel Gorman @ 2014-09-09 14:52 UTC (permalink / raw)
To: Andrew Morton
Cc: Johannes Weiner, Rik van Riel, David Rientjes, linux-mm, linux-kernel
Since 2.6.24 there has been a paranoid check in move_freepages that looks
up the zone of two pages. This is a very slow path and the only time I've
seen this bug trigger recently is when memory initialisation was broken
during patch development. Despite the fact it's a slow path, this patch
converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0a7ed33..6fbd814 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1014,7 +1014,7 @@ int move_freepages(struct zone *zone,
* Remove at a later date when no bug reports exist related to
* grouping pages by mobility
*/
- BUG_ON(page_zone(start_page) != page_zone(end_page));
+ VM_BUG_ON(page_zone(start_page) != page_zone(end_page));
#endif
for (page = start_page; page <= end_page;) {
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
@ 2014-09-09 14:52 ` Mel Gorman
0 siblings, 0 replies; 8+ messages in thread
From: Mel Gorman @ 2014-09-09 14:52 UTC (permalink / raw)
To: Andrew Morton
Cc: Johannes Weiner, Rik van Riel, David Rientjes, linux-mm, linux-kernel
Since 2.6.24 there has been a paranoid check in move_freepages that looks
up the zone of two pages. This is a very slow path and the only time I've
seen this bug trigger recently is when memory initialisation was broken
during patch development. Despite the fact it's a slow path, this patch
converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0a7ed33..6fbd814 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1014,7 +1014,7 @@ int move_freepages(struct zone *zone,
* Remove at a later date when no bug reports exist related to
* grouping pages by mobility
*/
- BUG_ON(page_zone(start_page) != page_zone(end_page));
+ VM_BUG_ON(page_zone(start_page) != page_zone(end_page));
#endif
for (page = start_page; page <= end_page;) {
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
2014-09-09 14:52 ` Mel Gorman
@ 2014-09-10 19:02 ` David Rientjes
-1 siblings, 0 replies; 8+ messages in thread
From: David Rientjes @ 2014-09-10 19:02 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Johannes Weiner, Rik van Riel, linux-mm, linux-kernel
On Tue, 9 Sep 2014, Mel Gorman wrote:
> Since 2.6.24 there has been a paranoid check in move_freepages that looks
> up the zone of two pages. This is a very slow path and the only time I've
> seen this bug trigger recently is when memory initialisation was broken
> during patch development. Despite the fact it's a slow path, this patch
> converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
@ 2014-09-10 19:02 ` David Rientjes
0 siblings, 0 replies; 8+ messages in thread
From: David Rientjes @ 2014-09-10 19:02 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Johannes Weiner, Rik van Riel, linux-mm, linux-kernel
On Tue, 9 Sep 2014, Mel Gorman wrote:
> Since 2.6.24 there has been a paranoid check in move_freepages that looks
> up the zone of two pages. This is a very slow path and the only time I've
> seen this bug trigger recently is when memory initialisation was broken
> during patch development. Despite the fact it's a slow path, this patch
> converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
2014-09-09 14:52 ` Mel Gorman
@ 2014-09-10 20:32 ` Rik van Riel
-1 siblings, 0 replies; 8+ messages in thread
From: Rik van Riel @ 2014-09-10 20:32 UTC (permalink / raw)
To: Mel Gorman, Andrew Morton
Cc: Johannes Weiner, David Rientjes, linux-mm, linux-kernel
On 09/09/2014 10:52 AM, Mel Gorman wrote:
> Since 2.6.24 there has been a paranoid check in move_freepages that looks
> up the zone of two pages. This is a very slow path and the only time I've
> seen this bug trigger recently is when memory initialisation was broken
> during patch development. Despite the fact it's a slow path, this patch
> converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
@ 2014-09-10 20:32 ` Rik van Riel
0 siblings, 0 replies; 8+ messages in thread
From: Rik van Riel @ 2014-09-10 20:32 UTC (permalink / raw)
To: Mel Gorman, Andrew Morton
Cc: Johannes Weiner, David Rientjes, linux-mm, linux-kernel
On 09/09/2014 10:52 AM, Mel Gorman wrote:
> Since 2.6.24 there has been a paranoid check in move_freepages that looks
> up the zone of two pages. This is a very slow path and the only time I've
> seen this bug trigger recently is when memory initialisation was broken
> during patch development. Despite the fact it's a slow path, this patch
> converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
2014-09-09 14:52 ` Mel Gorman
@ 2014-09-17 18:30 ` Johannes Weiner
-1 siblings, 0 replies; 8+ messages in thread
From: Johannes Weiner @ 2014-09-17 18:30 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Rik van Riel, David Rientjes, linux-mm, linux-kernel
On Tue, Sep 09, 2014 at 03:52:28PM +0100, Mel Gorman wrote:
> Since 2.6.24 there has been a paranoid check in move_freepages that looks
> up the zone of two pages. This is a very slow path and the only time I've
> seen this bug trigger recently is when memory initialisation was broken
> during patch development. Despite the fact it's a slow path, this patch
> converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON
@ 2014-09-17 18:30 ` Johannes Weiner
0 siblings, 0 replies; 8+ messages in thread
From: Johannes Weiner @ 2014-09-17 18:30 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Rik van Riel, David Rientjes, linux-mm, linux-kernel
On Tue, Sep 09, 2014 at 03:52:28PM +0100, Mel Gorman wrote:
> Since 2.6.24 there has been a paranoid check in move_freepages that looks
> up the zone of two pages. This is a very slow path and the only time I've
> seen this bug trigger recently is when memory initialisation was broken
> during patch development. Despite the fact it's a slow path, this patch
> converts the check to a VM_BUG_ON anyway as it is served its purpose by now.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-09-17 18:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-09 14:52 [PATCH] mm: page_alloc: Make paranoid check in move_freepages a VM_BUG_ON Mel Gorman
2014-09-09 14:52 ` Mel Gorman
2014-09-10 19:02 ` David Rientjes
2014-09-10 19:02 ` David Rientjes
2014-09-10 20:32 ` Rik van Riel
2014-09-10 20:32 ` Rik van Riel
2014-09-17 18:30 ` Johannes Weiner
2014-09-17 18:30 ` Johannes Weiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.