* [PATCH] Add-Quark-X1000-PCI-desc-clock-and-register-data
@ 2014-09-19 0:55 Bryan O'Donoghue
2014-09-19 2:47 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bryan O'Donoghue @ 2014-09-19 0:55 UTC (permalink / raw)
To: gregkh, jslaby, heikki.krogerus, linux-kernel, linux-serial
Cc: Bryan O'Donoghue
Adds PCI identifier for the X1000
Adds clocking and register size and register shift
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
---
drivers/tty/serial/8250/8250_pci.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 61830b1..5e72959 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -1481,6 +1481,19 @@ byt_serial_setup(struct serial_private *priv,
return ret;
}
+#define PCI_DEVICE_ID_INTEL_QRK_UART 0x0936
+
+static int
+pci_intel_qrk_setup(struct serial_private *priv,
+ const struct pciserial_board *board,
+ struct uart_8250_port *port, int idx)
+{
+ unsigned int bar, offset = board->first_offset;
+
+ bar = FL_GET_BASE(board->flags);
+
+ return setup_port(priv, port, bar, offset, board->reg_shift);
+}
static int
pci_omegapci_setup(struct serial_private *priv,
const struct pciserial_board *board,
@@ -1898,6 +1911,13 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
.subdevice = PCI_ANY_ID,
.setup = byt_serial_setup,
},
+ {
+ .vendor = PCI_VENDOR_ID_INTEL,
+ .device = PCI_DEVICE_ID_INTEL_QRK_UART,
+ .subvendor = PCI_ANY_ID,
+ .subdevice = PCI_ANY_ID,
+ .setup = pci_intel_qrk_setup,
+ },
/*
* ITE
*/
@@ -2740,6 +2760,7 @@ enum pci_board_num_t {
pbn_ADDIDATA_PCIe_8_3906250,
pbn_ce4100_1_115200,
pbn_byt,
+ pbn_qrk,
pbn_omegapci,
pbn_NETMOS9900_2s_115200,
pbn_brcm_trumanage,
@@ -3490,6 +3511,12 @@ static struct pciserial_board pci_boards[] = {
.uart_offset = 0x80,
.reg_shift = 2,
},
+ [pbn_qrk] = {
+ .flags = FL_BASE0,
+ .num_ports = 1,
+ .base_baud = 2764800,
+ .reg_shift = 2,
+ },
[pbn_omegapci] = {
.flags = FL_BASE0,
.num_ports = 8,
@@ -5192,6 +5219,12 @@ static struct pci_device_id serial_pci_tbl[] = {
pbn_byt },
/*
+ * Intel Quark x1000
+ */
+ { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QRK_UART,
+ PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+ pbn_qrk },
+ /*
* Cronyx Omega PCI
*/
{ PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_CRONYX_OMEGA,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Add-Quark-X1000-PCI-desc-clock-and-register-data
2014-09-19 0:55 [PATCH] Add-Quark-X1000-PCI-desc-clock-and-register-data Bryan O'Donoghue
@ 2014-09-19 2:47 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-09-19 2:47 UTC (permalink / raw)
To: Bryan O'Donoghue; +Cc: jslaby, heikki.krogerus, linux-kernel, linux-serial
Your subject is very odd, please fix it up and use ' ' characters...
Also use a prefix with the area of the kernel you are modifying, for
this one it would be something like "serial: 8250:
Care to try it again please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-19 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-19 0:55 [PATCH] Add-Quark-X1000-PCI-desc-clock-and-register-data Bryan O'Donoghue
2014-09-19 2:47 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.