All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Zhang Haoyu <zhanghy@sangfor.com>
Cc: Amit Shah <amit.shah@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [question] virtio-blk performancedegradationhappened with virito-serial
Date: Tue, 23 Sep 2014 09:29:35 +0800	[thread overview]
Message-ID: <20140923012935.GA22678@fam-t430.nay.redhat.com> (raw)
In-Reply-To: <201409222123220404614@sangfor.com>

On Mon, 09/22 21:23, Zhang Haoyu wrote:
> >
> >Amit,
> >
> >It's related to the big number of ioeventfds used in virtio-serial-pci. With
> >virtio-serial-pci's ioeventfd=off, the performance is not affected no matter if
> >guest initializes it or not.
> >
> >In my test, there are 12 fds to poll in qemu_poll_ns before loading guest
> >virtio_console.ko, whereas 76 once modprobe virtio_console.
> >
> >Looks like the ppoll takes more time to poll more fds.
> >
> >Some trace data with systemtap:
> >
> >12 fds:
> >
> >time  rel_time      symbol
> >15    (+1)          qemu_poll_ns  [enter]
> >18    (+3)          qemu_poll_ns  [return]
> >
> >76 fd:
> >
> >12    (+2)          qemu_poll_ns  [enter]
> >18    (+6)          qemu_poll_ns  [return]
> >
> >I haven't looked at virtio-serial code, I'm not sure if we should reduce the
> >number of ioeventfds in virtio-serial-pci or focus on lower level efficiency.
> >
> Does ioeventfd=off hamper the performance of virtio-serial?

In theory it has an impact, but I have no data about this. If you have a
performance demand, it's best to try it against your use case to answer this
question.

Fam

WARNING: multiple messages have this Message-ID (diff)
From: Fam Zheng <famz@redhat.com>
To: Zhang Haoyu <zhanghy@sangfor.com>
Cc: Amit Shah <amit.shah@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [question] virtio-blk performancedegradationhappened with virito-serial
Date: Tue, 23 Sep 2014 09:29:35 +0800	[thread overview]
Message-ID: <20140923012935.GA22678@fam-t430.nay.redhat.com> (raw)
In-Reply-To: <201409222123220404614@sangfor.com>

On Mon, 09/22 21:23, Zhang Haoyu wrote:
> >
> >Amit,
> >
> >It's related to the big number of ioeventfds used in virtio-serial-pci. With
> >virtio-serial-pci's ioeventfd=off, the performance is not affected no matter if
> >guest initializes it or not.
> >
> >In my test, there are 12 fds to poll in qemu_poll_ns before loading guest
> >virtio_console.ko, whereas 76 once modprobe virtio_console.
> >
> >Looks like the ppoll takes more time to poll more fds.
> >
> >Some trace data with systemtap:
> >
> >12 fds:
> >
> >time  rel_time      symbol
> >15    (+1)          qemu_poll_ns  [enter]
> >18    (+3)          qemu_poll_ns  [return]
> >
> >76 fd:
> >
> >12    (+2)          qemu_poll_ns  [enter]
> >18    (+6)          qemu_poll_ns  [return]
> >
> >I haven't looked at virtio-serial code, I'm not sure if we should reduce the
> >number of ioeventfds in virtio-serial-pci or focus on lower level efficiency.
> >
> Does ioeventfd=off hamper the performance of virtio-serial?

In theory it has an impact, but I have no data about this. If you have a
performance demand, it's best to try it against your use case to answer this
question.

Fam

  reply	other threads:[~2014-09-23  1:29 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  7:45 [question] virtio-blk performance degradation happened with virito-serial Zhang Haoyu
2014-08-29  7:45 ` [Qemu-devel] " Zhang Haoyu
2014-08-29 14:38 ` Amit Shah
2014-09-01 12:38   ` [Qemu-devel] [question] virtio-blk performance degradationhappened " Zhang Haoyu
2014-09-01 12:46     ` Amit Shah
2014-09-01 12:57       ` [Qemu-devel] [question] virtio-blk performancedegradationhappened " Zhang Haoyu
2014-09-01 12:52     ` [Qemu-devel] [question] virtio-blk performance degradationhappened " Zhang Haoyu
2014-09-01 13:09       ` Christian Borntraeger
2014-09-01 13:12         ` Paolo Bonzini
2014-09-01 13:22           ` Christian Borntraeger
2014-09-01 13:29             ` Paolo Bonzini
2014-09-01 14:03               ` Christian Borntraeger
2014-09-01 14:15                 ` Christian Borntraeger
2014-09-04  7:56             ` [Qemu-devel] [question] virtio-blk performance degradationhappenedwith virito-serial Zhang Haoyu
2014-09-07  9:46               ` Zhang Haoyu
2014-09-07  9:46                 ` Zhang Haoyu
2014-09-11  6:11                 ` Amit Shah
2014-09-11  6:11                   ` Amit Shah
2014-09-12  3:21                   ` [question] virtio-blk performance degradation happened with virito-serial Zhang Haoyu
2014-09-12  3:21                     ` [Qemu-devel] " Zhang Haoyu
2014-09-12 12:38                     ` Stefan Hajnoczi
2014-09-12 12:38                       ` Stefan Hajnoczi
2014-09-13 17:22                       ` Max Reitz
2014-09-13 17:22                         ` Max Reitz
2014-09-16 14:59                     ` Zhang Haoyu
2014-09-16 14:59                       ` [Qemu-devel] " Zhang Haoyu
2014-09-02  6:36       ` [Qemu-devel] [question] virtio-blk performance degradationhappened " Amit Shah
2014-09-02 18:05         ` Andrey Korolyov
2014-09-02 18:11           ` Amit Shah
2014-09-02 18:11             ` [Qemu-devel] " Amit Shah
2014-09-02 18:27             ` Andrey Korolyov
2014-09-04  2:20         ` [Qemu-devel] [question] virtio-blk performancedegradationhappened " Zhang Haoyu
2014-09-19  5:53         ` [Qemu-devel] [question] virtio-blk performance degradationhappened " Fam Zheng
2014-09-19  5:53           ` Fam Zheng
2014-09-19 13:35           ` Paolo Bonzini
2014-09-19 13:35             ` [Qemu-devel] " Paolo Bonzini
2014-09-22 13:23           ` [Qemu-devel] [question] virtio-blk performancedegradationhappened " Zhang Haoyu
2014-09-22 13:23             ` Zhang Haoyu
2014-09-23  1:29             ` Fam Zheng [this message]
2014-09-23  1:29               ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923012935.GA22678@fam-t430.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhanghy@sangfor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.