[GIT PULL] cgroup fixes for v3.17-rc6

[GIT PULL] cgroup fixes for v3.17-rc6

[Tejun Heo]

Hello, Linus.

One late fix for cgroup.  I was waiting for another set of fixes for a
long-standing obscure cpuset bug but am not sure whether they'll be
ready before v3.17 release.  This one is a simple fix for a mutex
unlock balance bug, which is detected by coccinelle and probably won't
trigger in the wild, introduced during this devel cycle.

Thanks.

The following changes since commit aa32362f011c6e863132b16c1761487166a4bad2:

  cgroup: check cgroup liveliness before unbreaking kernfs (2014-09-05 01:36:19 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.17-fixes

for you to fetch changes up to eb4aec84d6bdf98d00cedb41c18000f7a31e648a:

  cgroup: fix unbalanced locking (2014-09-18 12:32:52 -0400)

----------------------------------------------------------------
Zefan Li (1):
      cgroup: fix unbalanced locking

 kernel/cgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 940aced..3a73f99 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3985,7 +3985,6 @@ static int pidlist_array_load(struct cgroup *cgrp, enum cgroup_filetype type,
 
 	l = cgroup_pidlist_find_create(cgrp, type);
 	if (!l) {
-		mutex_unlock(&cgrp->pidlist_mutex);
 		pidlist_free(array);
 		return -ENOMEM;
 	}

-- 
tejun

[GIT PULL] cgroup fixes for v3.17-rc6

[Tejun Heo]

Hello, Linus.

One late fix for cgroup.  I was waiting for another set of fixes for a
long-standing obscure cpuset bug but am not sure whether they'll be
ready before v3.17 release.  This one is a simple fix for a mutex
unlock balance bug, which is detected by coccinelle and probably won't
trigger in the wild, introduced during this devel cycle.

Thanks.

The following changes since commit aa32362f011c6e863132b16c1761487166a4bad2:

  cgroup: check cgroup liveliness before unbreaking kernfs (2014-09-05 01:36:19 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.17-fixes

for you to fetch changes up to eb4aec84d6bdf98d00cedb41c18000f7a31e648a:

  cgroup: fix unbalanced locking (2014-09-18 12:32:52 -0400)

----------------------------------------------------------------
Zefan Li (1):
      cgroup: fix unbalanced locking

 kernel/cgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 940aced..3a73f99 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3985,7 +3985,6 @@ static int pidlist_array_load(struct cgroup *cgrp, enum cgroup_filetype type,
 
 	l = cgroup_pidlist_find_create(cgrp, type);
 	if (!l) {
-		mutex_unlock(&cgrp->pidlist_mutex);
 		pidlist_free(array);
 		return -ENOMEM;
 	}

-- 
tejun

Re: [GIT PULL] cgroup fixes for v3.17-rc6

[Zefan Li]

On 2014/9/23 14:33, Tejun Heo wrote:
> Hello, Linus.
> 
> One late fix for cgroup.  I was waiting for another set of fixes for a
> long-standing obscure cpuset bug but am not sure whether they'll be
> ready before v3.17 release.  This one is a simple fix for a mutex
> unlock balance bug, which is detected by coccinelle and probably won't
> trigger in the wild, introduced during this devel cycle.
> 

It was introduced in 3.14, and it was detected by my eyes, not coccinelle. ;)

Re: [GIT PULL] cgroup fixes for v3.17-rc6

[Zefan Li]

On 2014/9/23 14:33, Tejun Heo wrote:
> Hello, Linus.
> 
> One late fix for cgroup.  I was waiting for another set of fixes for a
> long-standing obscure cpuset bug but am not sure whether they'll be
> ready before v3.17 release.  This one is a simple fix for a mutex
> unlock balance bug, which is detected by coccinelle and probably won't
> trigger in the wild, introduced during this devel cycle.
> 

It was introduced in 3.14, and it was detected by my eyes, not coccinelle. ;)

Re: [GIT PULL] cgroup fixes for v3.17-rc6

[Tejun Heo]

On Tue, Sep 23, 2014 at 02:45:27PM +0800, Zefan Li wrote:
> On 2014/9/23 14:33, Tejun Heo wrote:
> > Hello, Linus.
> > 
> > One late fix for cgroup.  I was waiting for another set of fixes for a
> > long-standing obscure cpuset bug but am not sure whether they'll be
> > ready before v3.17 release.  This one is a simple fix for a mutex
> > unlock balance bug, which is detected by coccinelle and probably won't
> > trigger in the wild, introduced during this devel cycle.
> > 
> 
> It was introduced in 3.14, and it was detected by my eyes, not coccinelle. ;)

Hah, I got it completely mixed up with another patch in my head.  Will
post an updated pull request.  My apologies.

Thanks.

-- 
tejun

Re: [GIT PULL] cgroup fixes for v3.17-rc6

[Tejun Heo]

On Tue, Sep 23, 2014 at 02:45:27PM +0800, Zefan Li wrote:
> On 2014/9/23 14:33, Tejun Heo wrote:
> > Hello, Linus.
> > 
> > One late fix for cgroup.  I was waiting for another set of fixes for a
> > long-standing obscure cpuset bug but am not sure whether they'll be
> > ready before v3.17 release.  This one is a simple fix for a mutex
> > unlock balance bug, which is detected by coccinelle and probably won't
> > trigger in the wild, introduced during this devel cycle.
> > 
> 
> It was introduced in 3.14, and it was detected by my eyes, not coccinelle. ;)

Hah, I got it completely mixed up with another patch in my head.  Will
post an updated pull request.  My apologies.

Thanks.

-- 
tejun

[GIT UPDATED PULL] cgroup fixes for v3.17-rc6

[Tejun Heo]

Hello, Linus.

One late fix for cgroup.  I was waiting for another set of fixes for a
long-standing obscure cpuset bug but am not sure whether they'll be
ready before v3.17 release.  This one is a simple fix for a mutex
unlock balance bug in an allocation failure path in
pidlist_array_load().  The bug was introduced in v3.14 and the fix is
tagged for -stable.

Thanks.

The following changes since commit aa32362f011c6e863132b16c1761487166a4bad2:

  cgroup: check cgroup liveliness before unbreaking kernfs (2014-09-05 01:36:19 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.17-fixes

for you to fetch changes up to eb4aec84d6bdf98d00cedb41c18000f7a31e648a:

  cgroup: fix unbalanced locking (2014-09-18 12:32:52 -0400)

----------------------------------------------------------------
Zefan Li (1):
      cgroup: fix unbalanced locking

 kernel/cgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 940aced..3a73f99 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3985,7 +3985,6 @@ static int pidlist_array_load(struct cgroup *cgrp, enum cgroup_filetype type,
 
 	l = cgroup_pidlist_find_create(cgrp, type);
 	if (!l) {
-		mutex_unlock(&cgrp->pidlist_mutex);
 		pidlist_free(array);
 		return -ENOMEM;
 	}

-- 
tejun

[GIT UPDATED PULL] cgroup fixes for v3.17-rc6

[Tejun Heo]

Hello, Linus.

One late fix for cgroup.  I was waiting for another set of fixes for a
long-standing obscure cpuset bug but am not sure whether they'll be
ready before v3.17 release.  This one is a simple fix for a mutex
unlock balance bug in an allocation failure path in
pidlist_array_load().  The bug was introduced in v3.14 and the fix is
tagged for -stable.

Thanks.

The following changes since commit aa32362f011c6e863132b16c1761487166a4bad2:

  cgroup: check cgroup liveliness before unbreaking kernfs (2014-09-05 01:36:19 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.17-fixes

for you to fetch changes up to eb4aec84d6bdf98d00cedb41c18000f7a31e648a:

  cgroup: fix unbalanced locking (2014-09-18 12:32:52 -0400)

----------------------------------------------------------------
Zefan Li (1):
      cgroup: fix unbalanced locking

 kernel/cgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 940aced..3a73f99 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -3985,7 +3985,6 @@ static int pidlist_array_load(struct cgroup *cgrp, enum cgroup_filetype type,
 
 	l = cgroup_pidlist_find_create(cgrp, type);
 	if (!l) {
-		mutex_unlock(&cgrp->pidlist_mutex);
 		pidlist_free(array);
 		return -ENOMEM;
 	}

-- 
tejun