From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Jiri Olsa <jolsa@redhat.com>,
Michael Ellerman <michaele@au1.ibm.com>,
linuxppc-dev@ozlabs.org, Anton Blanchard <anton@au1.ibm.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
ulrich.weigand@de.ibm.com, Maynard Johnson <mpjohn@us.ibm.com>
Subject: Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info
Date: Tue, 23 Sep 2014 09:26:23 -0700 [thread overview]
Message-ID: <20140923162623.GA1698@us.ibm.com> (raw)
In-Reply-To: <20140922213345.GB666@drone.musicnaut.iki.fi>
Aaro Koskinen [aaro.koskinen@iki.fi] wrote:
| Hi,
|
| On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote:
| > powerpc/perf: Adjust callchain based on DWARF debug info
| >
| > When saving the callchain on Power, the kernel conservatively saves excess
| > entries in the callchain. A few of these entries are needed in some cases
| > but not others. We should use the DWARF debug information to determine
| > when the entries are needed.
|
| This patch breaks perf compilation if DWARF support is not present.
| DWARF support is auto-detected early in the build, so IMHO either user
| should be informed to install the needed stuff, or the build should
| succeed with limited functionality.
|
| arch/powerpc/util/skip-callchain-idx.c:13:19: fatal error: dwarf.h: No such file or directory #include <dwarf.h>
| ^
| compilation terminated.
Yes. Sorry. Anton fixed this recently:
https://lkml.org/lkml/2014/9/19/29
Sukadev
WARNING: multiple messages have this Message-ID (diff)
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Michael Ellerman <michaele@au1.ibm.com>,
ulrich.weigand@de.ibm.com, Anton Blanchard <anton@au1.ibm.com>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linuxppc-dev@ozlabs.org, Maynard Johnson <mpjohn@us.ibm.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info
Date: Tue, 23 Sep 2014 09:26:23 -0700 [thread overview]
Message-ID: <20140923162623.GA1698@us.ibm.com> (raw)
In-Reply-To: <20140922213345.GB666@drone.musicnaut.iki.fi>
Aaro Koskinen [aaro.koskinen@iki.fi] wrote:
| Hi,
|
| On Wed, Jun 25, 2014 at 08:49:03AM -0700, Sukadev Bhattiprolu wrote:
| > powerpc/perf: Adjust callchain based on DWARF debug info
| >
| > When saving the callchain on Power, the kernel conservatively saves excess
| > entries in the callchain. A few of these entries are needed in some cases
| > but not others. We should use the DWARF debug information to determine
| > when the entries are needed.
|
| This patch breaks perf compilation if DWARF support is not present.
| DWARF support is auto-detected early in the build, so IMHO either user
| should be informed to install the needed stuff, or the build should
| succeed with limited functionality.
|
| arch/powerpc/util/skip-callchain-idx.c:13:19: fatal error: dwarf.h: No such file or directory #include <dwarf.h>
| ^
| compilation terminated.
Yes. Sorry. Anton fixed this recently:
https://lkml.org/lkml/2014/9/19/29
Sukadev
next prev parent reply other threads:[~2014-09-23 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 0:00 [PATCH v5 1/1] powerpc/perf: Adjust callchain based on DWARF debug info Sukadev Bhattiprolu
2014-06-25 0:00 ` Sukadev Bhattiprolu
2014-06-25 7:42 ` Jiri Olsa
2014-06-25 7:42 ` Jiri Olsa
2014-06-25 15:49 ` Sukadev Bhattiprolu
2014-06-25 15:49 ` Sukadev Bhattiprolu
2014-07-05 10:42 ` [tip:perf/core] perf tools powerpc: " tip-bot for Sukadev Bhattiprolu
2014-09-22 21:33 ` [PATCH v5 1/1] powerpc/perf: " Aaro Koskinen
2014-09-22 21:33 ` Aaro Koskinen
2014-09-23 6:59 ` Jiri Olsa
2014-09-23 6:59 ` Jiri Olsa
2014-09-23 16:26 ` Sukadev Bhattiprolu [this message]
2014-09-23 16:26 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923162623.GA1698@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=aaro.koskinen@iki.fi \
--cc=acme@kernel.org \
--cc=anton@au1.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mpjohn@us.ibm.com \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.