All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT
@ 2014-09-17 14:11 Laurent Pinchart
  2014-09-17 14:51 ` Geert Uytterhoeven
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Laurent Pinchart @ 2014-09-17 14:11 UTC (permalink / raw)
  To: linux-sh

Specify the DU output topology, enable the DU device and configure the
related pins.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 43 ++++++++++++++++++++++++++++++++---
 1 file changed, 40 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 178431d..19d7b36 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -209,6 +209,46 @@
 		states = <3300000 1
 			  1800000 0>;
 	};
+
+	panel {
+		compatible = "mitsubishi,aa104xd12", "panel-dpi";
+
+		width-mm = <210>;
+		height-mm = <158>;
+
+		panel-timing {
+			/* 1024x768 @65Hz */
+			clock-frequency = <65000000>;
+			hactive = <1024>;
+			vactive = <768>;
+			hsync-len = <136>;
+			hfront-porch = <20>;
+			hback-porch = <160>;
+			vfront-porch = <3>;
+			vback-porch = <29>;
+			vsync-len = <6>;
+		};
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&du_out_lvds0>;
+			};
+		};
+	};
+};
+
+&du {
+	pinctrl-0 = <&du_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	ports {
+		port@1 {
+			endpoint {
+				remote-endpoint = <&panel_in>;
+			};
+		};
+	};
 };
 
 &extal_clk {
@@ -216,9 +256,6 @@
 };
 
 &pfc {
-	pinctrl-0 = <&du_pins>;
-	pinctrl-names = "default";
-
 	i2c2_pins: i2c2 {
 		renesas,groups = "i2c2";
 		renesas,function = "i2c2";
-- 
1.8.5.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT
  2014-09-17 14:11 [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
@ 2014-09-17 14:51 ` Geert Uytterhoeven
  2014-09-18  9:07 ` Laurent Pinchart
  2014-09-24  9:02 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-09-17 14:51 UTC (permalink / raw)
  To: linux-sh

Hi Laurent,

On Wed, Sep 17, 2014 at 4:11 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -209,6 +209,46 @@
>                 states = <3300000 1
>                           1800000 0>;
>         };
> +
> +       panel {
> +               compatible = "mitsubishi,aa104xd12", "panel-dpi";

This device is not present on a stock Koelsch, so I don't think it belongs
in this DTS.

> +
> +               width-mm = <210>;
> +               height-mm = <158>;
> +
> +               panel-timing {
> +                       /* 1024x768 @65Hz */
> +                       clock-frequency = <65000000>;
> +                       hactive = <1024>;
> +                       vactive = <768>;
> +                       hsync-len = <136>;
> +                       hfront-porch = <20>;
> +                       hback-porch = <160>;
> +                       vfront-porch = <3>;
> +                       vback-porch = <29>;
> +                       vsync-len = <6>;
> +               };
> +
> +               port {
> +                       panel_in: endpoint {
> +                               remote-endpoint = <&du_out_lvds0>;
> +                       };
> +               };
> +       };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT
  2014-09-17 14:11 [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
  2014-09-17 14:51 ` Geert Uytterhoeven
@ 2014-09-18  9:07 ` Laurent Pinchart
  2014-09-24  9:02 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2014-09-18  9:07 UTC (permalink / raw)
  To: linux-sh

Hi Geert,

On Wednesday 17 September 2014 16:51:20 Geert Uytterhoeven wrote:
> On Wed, Sep 17, 2014 at 4:11 PM, Laurent Pinchart wrote:
> > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > @@ -209,6 +209,46 @@
> >                 states = <3300000 1
> >                           1800000 0>;
> >         };
> > +
> > +       panel {
> > +               compatible = "mitsubishi,aa104xd12", "panel-dpi";
> 
> This device is not present on a stock Koelsch, so I don't think it belongs
> in this DTS.

I agree. Still, it would be good to have support for that panel in mainline, 
as it's commonly used by Renesas with the Koelsch board (among others). I'll 
create a separate .dtsi file that developers can just include in their board 
file to hook up the panel.

> > +
> > +               width-mm = <210>;
> > +               height-mm = <158>;
> > +
> > +               panel-timing {
> > +                       /* 1024x768 @65Hz */
> > +                       clock-frequency = <65000000>;
> > +                       hactive = <1024>;
> > +                       vactive = <768>;
> > +                       hsync-len = <136>;
> > +                       hfront-porch = <20>;
> > +                       hback-porch = <160>;
> > +                       vfront-porch = <3>;
> > +                       vback-porch = <29>;
> > +                       vsync-len = <6>;
> > +               };
> > +
> > +               port {
> > +                       panel_in: endpoint {
> > +                               remote-endpoint = <&du_out_lvds0>;
> > +                       };
> > +               };
> > +       };

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT
  2014-09-17 14:11 [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
  2014-09-17 14:51 ` Geert Uytterhoeven
  2014-09-18  9:07 ` Laurent Pinchart
@ 2014-09-24  9:02 ` Simon Horman
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-09-24  9:02 UTC (permalink / raw)
  To: linux-sh

On Thu, Sep 18, 2014 at 12:07:48PM +0300, Laurent Pinchart wrote:
> Hi Geert,
> 
> On Wednesday 17 September 2014 16:51:20 Geert Uytterhoeven wrote:
> > On Wed, Sep 17, 2014 at 4:11 PM, Laurent Pinchart wrote:
> > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > > @@ -209,6 +209,46 @@
> > >                 states = <3300000 1
> > >                           1800000 0>;
> > >         };
> > > +
> > > +       panel {
> > > +               compatible = "mitsubishi,aa104xd12", "panel-dpi";
> > 
> > This device is not present on a stock Koelsch, so I don't think it belongs
> > in this DTS.
> 
> I agree. Still, it would be good to have support for that panel in mainline, 
> as it's commonly used by Renesas with the Koelsch board (among others). I'll 
> create a separate .dtsi file that developers can just include in their board 
> file to hook up the panel.

Thanks, that seems reasonable to me.

> > > +
> > > +               width-mm = <210>;
> > > +               height-mm = <158>;
> > > +
> > > +               panel-timing {
> > > +                       /* 1024x768 @65Hz */
> > > +                       clock-frequency = <65000000>;
> > > +                       hactive = <1024>;
> > > +                       vactive = <768>;
> > > +                       hsync-len = <136>;
> > > +                       hfront-porch = <20>;
> > > +                       hback-porch = <160>;
> > > +                       vfront-porch = <3>;
> > > +                       vback-porch = <29>;
> > > +                       vsync-len = <6>;
> > > +               };
> > > +
> > > +               port {
> > > +                       panel_in: endpoint {
> > > +                               remote-endpoint = <&du_out_lvds0>;
> > > +                       };
> > > +               };
> > > +       };
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-09-24  9:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-17 14:11 [PATCH 8/8] ARM: shmobile: koelsch: Enable DU device in DT Laurent Pinchart
2014-09-17 14:51 ` Geert Uytterhoeven
2014-09-18  9:07 ` Laurent Pinchart
2014-09-24  9:02 ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.