All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] misc: atmel-ssc: prepare clock only when request
@ 2014-09-24  8:56 ` Bo Shen
  0 siblings, 0 replies; 6+ messages in thread
From: Bo Shen @ 2014-09-24  8:56 UTC (permalink / raw)
  To: Mark Brown
  Cc: nicolas.ferre, boris.brezillon, linux-arm-kernel, linux-kernel, Bo Shen

Prepare SSC clock only when request SSC channel, the clock will be
enabled when initialize the SSC.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---

 drivers/misc/atmel-ssc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index 60843a2..f9807a7 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -57,7 +57,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
 	ssc->user++;
 	spin_unlock(&user_lock);
 
-	clk_prepare_enable(ssc->clk);
+	clk_prepare(ssc->clk);
 
 	return ssc;
 }
@@ -77,7 +77,7 @@ void ssc_free(struct ssc_device *ssc)
 	spin_unlock(&user_lock);
 
 	if (disable_clk)
-		clk_disable_unprepare(ssc->clk);
+		clk_unprepare(ssc->clk);
 }
 EXPORT_SYMBOL(ssc_free);
 
-- 
2.1.0.24.g4109c28


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] misc: atmel-ssc: prepare clock only when request
@ 2014-09-24  8:56 ` Bo Shen
  0 siblings, 0 replies; 6+ messages in thread
From: Bo Shen @ 2014-09-24  8:56 UTC (permalink / raw)
  To: linux-arm-kernel

Prepare SSC clock only when request SSC channel, the clock will be
enabled when initialize the SSC.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---

 drivers/misc/atmel-ssc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
index 60843a2..f9807a7 100644
--- a/drivers/misc/atmel-ssc.c
+++ b/drivers/misc/atmel-ssc.c
@@ -57,7 +57,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
 	ssc->user++;
 	spin_unlock(&user_lock);
 
-	clk_prepare_enable(ssc->clk);
+	clk_prepare(ssc->clk);
 
 	return ssc;
 }
@@ -77,7 +77,7 @@ void ssc_free(struct ssc_device *ssc)
 	spin_unlock(&user_lock);
 
 	if (disable_clk)
-		clk_disable_unprepare(ssc->clk);
+		clk_unprepare(ssc->clk);
 }
 EXPORT_SYMBOL(ssc_free);
 
-- 
2.1.0.24.g4109c28

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] misc: atmel-ssc: prepare clock only when request
  2014-09-24  8:56 ` Bo Shen
@ 2014-09-24  9:07   ` Mark Brown
  -1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-09-24  9:07 UTC (permalink / raw)
  To: Bo Shen; +Cc: nicolas.ferre, boris.brezillon, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

On Wed, Sep 24, 2014 at 04:56:59PM +0800, Bo Shen wrote:
> Prepare SSC clock only when request SSC channel, the clock will be
> enabled when initialize the SSC.

You should send this to the drivers/misc maintainer.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] misc: atmel-ssc: prepare clock only when request
@ 2014-09-24  9:07   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-09-24  9:07 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Sep 24, 2014 at 04:56:59PM +0800, Bo Shen wrote:
> Prepare SSC clock only when request SSC channel, the clock will be
> enabled when initialize the SSC.

You should send this to the drivers/misc maintainer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140924/8ad9d41e/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] misc: atmel-ssc: prepare clock only when request
  2014-09-24  9:07   ` Mark Brown
@ 2014-09-24  9:34     ` Bo Shen
  -1 siblings, 0 replies; 6+ messages in thread
From: Bo Shen @ 2014-09-24  9:34 UTC (permalink / raw)
  To: Mark Brown; +Cc: nicolas.ferre, boris.brezillon, linux-arm-kernel, linux-kernel

Hi Mark,

On 09/24/2014 05:07 PM, Mark Brown wrote:
> On Wed, Sep 24, 2014 at 04:56:59PM +0800, Bo Shen wrote:
>> Prepare SSC clock only when request SSC channel, the clock will be
>> enabled when initialize the SSC.
>
> You should send this to the drivers/misc maintainer.

Thanks, it has been done.

Best Regards,
Bo Shen


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] misc: atmel-ssc: prepare clock only when request
@ 2014-09-24  9:34     ` Bo Shen
  0 siblings, 0 replies; 6+ messages in thread
From: Bo Shen @ 2014-09-24  9:34 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Mark,

On 09/24/2014 05:07 PM, Mark Brown wrote:
> On Wed, Sep 24, 2014 at 04:56:59PM +0800, Bo Shen wrote:
>> Prepare SSC clock only when request SSC channel, the clock will be
>> enabled when initialize the SSC.
>
> You should send this to the drivers/misc maintainer.

Thanks, it has been done.

Best Regards,
Bo Shen

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-09-24  9:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-24  8:56 [PATCH] misc: atmel-ssc: prepare clock only when request Bo Shen
2014-09-24  8:56 ` Bo Shen
2014-09-24  9:07 ` Mark Brown
2014-09-24  9:07   ` Mark Brown
2014-09-24  9:34   ` Bo Shen
2014-09-24  9:34     ` Bo Shen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.