All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Michal Sojka <sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Linux LED Subsystem
	<linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	michal.vokac-veUE7cmDK2A@public.gmane.org
Subject: Re: [PATCH v6 3/4] usb: Rename usb-common.c
Date: Wed, 24 Sep 2014 18:15:11 -0500	[thread overview]
Message-ID: <20140924231511.GB27672@saruman> (raw)
In-Reply-To: <1411591401-5874-4-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote:
> In the next commit, we will want the usb-common module to be composed of
> two object files. Since Kbuild cannot "append" another object to an
> existing one, we need to rename usb-common.c to something
> else (common.c) and create usb-common.o by linking the wanted objects
> together. Currently, usb-common.o comprises only common.o.
> 
> Signed-off-by: Michal Sojka <sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>

for future reference, you can use git format-patch -M -C to detect
renames, the generated diff is far better ;-)

Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@ti.com>
To: Michal Sojka <sojka@merica.cz>
Cc: <linux-usb@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Bryan Wu <cooloney@gmail.com>, Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <michal.vokac@comap.cz>
Subject: Re: [PATCH v6 3/4] usb: Rename usb-common.c
Date: Wed, 24 Sep 2014 18:15:11 -0500	[thread overview]
Message-ID: <20140924231511.GB27672@saruman> (raw)
In-Reply-To: <1411591401-5874-4-git-send-email-sojka@merica.cz>

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote:
> In the next commit, we will want the usb-common module to be composed of
> two object files. Since Kbuild cannot "append" another object to an
> existing one, we need to rename usb-common.c to something
> else (common.c) and create usb-common.o by linking the wanted objects
> together. Currently, usb-common.o comprises only common.o.
> 
> Signed-off-by: Michal Sojka <sojka@merica.cz>

for future reference, you can use git format-patch -M -C to detect
renames, the generated diff is far better ;-)

Acked-by: Felipe Balbi <balbi@ti.com>

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-09-24 23:15 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  7:21 [PATCH v5 0/3] LED triggers for USB host and device Michal Sojka
2014-09-17  7:21 ` [PATCH v5 1/3] usb: gadget: Refactor request completion Michal Sojka
2014-09-17 15:28   ` Felipe Balbi
2014-09-17 15:28     ` Felipe Balbi
2014-09-23  8:09     ` Michal Sojka
2014-09-23  8:09       ` Michal Sojka
2014-09-24 14:48       ` Felipe Balbi
2014-09-24 14:48         ` Felipe Balbi
2014-09-24 15:08       ` Alan Stern
2014-09-24 15:08         ` Alan Stern
2014-09-24 20:43         ` [PATCH v6 0/4] LED triggers for USB host and device Michal Sojka
     [not found]           ` <1411591401-5874-1-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
2014-09-24 20:43             ` [PATCH v6 1/4] usb: gadget: Introduce usb_gadget_giveback_request() Michal Sojka
2014-09-24 20:43               ` Michal Sojka
     [not found]               ` <1411591401-5874-2-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
2014-09-24 21:00                 ` Felipe Balbi
2014-09-24 21:00                   ` Felipe Balbi
2014-09-24 20:59             ` [PATCH v6 0/4] LED triggers for USB host and device Felipe Balbi
2014-09-24 20:59               ` Felipe Balbi
2014-09-24 21:41               ` Greg Kroah-Hartman
     [not found]                 ` <20140924214155.GA30689-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-09-24 22:18                   ` Felipe Balbi
2014-09-24 22:18                     ` Felipe Balbi
2014-09-24 23:15                     ` Felipe Balbi
2014-09-24 23:15                       ` Felipe Balbi
2014-09-25 10:36                       ` Greg Kroah-Hartman
2014-09-25 13:56                         ` Felipe Balbi
2014-09-25 13:56                           ` Felipe Balbi
2014-09-25 14:56                           ` Greg Kroah-Hartman
2014-09-24 20:43           ` [PATCH v6 2/4] usb: gadget: Refactor request completion Michal Sojka
2014-09-24 23:14             ` Felipe Balbi
2014-09-24 23:14               ` Felipe Balbi
2014-09-29  8:50             ` Robert Baldyga
2014-09-29  9:13               ` Michal Sojka
2014-09-29 14:05               ` Felipe Balbi
2014-09-29 14:05                 ` Felipe Balbi
2014-09-24 20:43           ` [PATCH v6 3/4] usb: Rename usb-common.c Michal Sojka
     [not found]             ` <1411591401-5874-4-git-send-email-sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org>
2014-09-24 23:15               ` Felipe Balbi [this message]
2014-09-24 23:15                 ` Felipe Balbi
2014-09-25 15:03             ` Greg Kroah-Hartman
2014-09-25 15:48               ` project wide: git config entry for [diff] renames=true Joe Perches
2014-09-25 18:00                 ` Jeff King
2014-09-25 18:06                   ` Joe Perches
2014-09-25 18:43                     ` Junio C Hamano
     [not found]                   ` <20140925180005.GA11755-AdEPDUrAXsQ@public.gmane.org>
2014-09-25 18:53                     ` Junio C Hamano
2014-09-25 18:53                       ` Junio C Hamano
2014-09-25 18:55                       ` Junio C Hamano
2014-10-03  1:37                       ` [RFC/PATCH 0/2] Introduce safe-include config feature Rasmus Villemoes
2014-10-03  1:37                         ` [RFC/PATCH 1/2] config: Add safe-include directive Rasmus Villemoes
2014-10-03  5:27                           ` Junio C Hamano
2014-10-03  5:34                             ` Junio C Hamano
2014-10-03 18:52                             ` Junio C Hamano
2014-10-06  9:28                             ` Rasmus Villemoes
2014-10-06 17:58                               ` Junio C Hamano
2014-10-03  1:37                         ` [RFC/PATCH 2/2] config: Add test of safe-include feature Rasmus Villemoes
2014-09-24 20:43           ` [PATCH v6 4/4] usb: Add LED triggers for USB activity Michal Sojka
2014-09-24 20:56             ` Felipe Balbi
2014-09-24 20:56               ` Felipe Balbi
2014-09-17  7:21 ` [PATCH v5 2/3] usb: Rename usb-common.c Michal Sojka
2014-09-17  7:21 ` [PATCH v5 3/3] usb: Add LED triggers for USB activity Michal Sojka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924231511.GB27672@saruman \
    --to=balbi-l0cymroini0@public.gmane.org \
    --cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michal.vokac-veUE7cmDK2A@public.gmane.org \
    --cc=sojka-Knnw/vAvyUalVyrhU4qvOw@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.