All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fsx: increase number of logged operations
@ 2014-09-26 13:04 Christoph Hellwig
  2014-09-26 14:22 ` Theodore Ts'o
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2014-09-26 13:04 UTC (permalink / raw)
  To: fstests

1000 operations is nearly enough to debug complex data integrity
issues, so increase the log buffer by an order of magnitude.

Signed-off-by: Christoph Hellwig <hch@lst.de>

diff --git a/ltp/fsx.c b/ltp/fsx.c
index 47d3ee8..3709419 100644
--- a/ltp/fsx.c
+++ b/ltp/fsx.c
@@ -49,7 +49,7 @@ struct log_entry {
 	int	args[3];
 };
 
-#define	LOGSIZE	1000
+#define	LOGSIZE	10000
 
 struct log_entry	oplog[LOGSIZE];	/* the log */
 int			logptr = 0;	/* current position in log */

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] fsx: increase number of logged operations
  2014-09-26 13:04 [PATCH] fsx: increase number of logged operations Christoph Hellwig
@ 2014-09-26 14:22 ` Theodore Ts'o
  2014-09-26 15:43   ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Theodore Ts'o @ 2014-09-26 14:22 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: fstests

On Fri, Sep 26, 2014 at 06:04:30AM -0700, Christoph Hellwig wrote:
> 1000 operations is nearly enough to debug complex data integrity
                 ^^^^^

is not nearly enough?

> issues, so increase the log buffer by an order of magnitude.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Theodore Ts'o <tytso@mit.edu>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fsx: increase number of logged operations
  2014-09-26 14:22 ` Theodore Ts'o
@ 2014-09-26 15:43   ` Christoph Hellwig
  0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2014-09-26 15:43 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: fstests

On Fri, Sep 26, 2014 at 10:22:43AM -0400, Theodore Ts'o wrote:
> On Fri, Sep 26, 2014 at 06:04:30AM -0700, Christoph Hellwig wrote:
> > 1000 operations is nearly enough to debug complex data integrity
>                  ^^^^^
> 
> is not nearly enough?

Yes, obviously..  


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-26 15:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-26 13:04 [PATCH] fsx: increase number of logged operations Christoph Hellwig
2014-09-26 14:22 ` Theodore Ts'o
2014-09-26 15:43   ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.