All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jianqun <xjq@rock-chips.com>
Cc: Jianqun <jay.xu@rock-chips.com>,
	robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz,
	tiwai@suse.de, grant.likely@linaro.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, huangtao@rock-chips.com,
	cf@rock-chips.com
Subject: Re: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver
Date: Sun, 28 Sep 2014 11:48:51 +0100	[thread overview]
Message-ID: <20140928104851.GR27755@sirena.org.uk> (raw)
In-Reply-To: <54275C43.8010205@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

On Sun, Sep 28, 2014 at 08:54:27AM +0800, Jianqun wrote:

Please fix your mailer to word wrap within paragraphs.

> 在 09/12/2014 09:44 PM, Mark Brown 写道:
> > On Fri, Sep 12, 2014 at 03:30:36PM +0800, Jianqun wrote:
> >> Add documentation for rockchip-max98090 driver, which is need by rockchip
> >> board using a max98090.

> > Can this use simple-card (perhaps after a bit of extension)?
> I haven't ever try simple-card, is there any sample usage for me from other vendor ?

$ git grep -l simple-audio-card
Documentation/devicetree/bindings/sound/simple-card.txt
arch/arm/boot/dts/kirkwood-openrd-client.dts
arch/arm/boot/dts/kirkwood-t5325.dts
arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
arch/arm/boot/dts/vf610-twr.dts
sound/soc/generic/simple-card.c

> >> +- rockchip,audio-codec : The phandle of the MAX98090 audio codec.

> > Is the driver really specific to this CODEC?

> I think yes, we need to add two gpio for mic and hp detect, but simple-card driver hasn't them

That'd be the "possibly with some extensions" bit then...  if they're
just isolated GPIOs there's not really much board specific about having
them.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jianqun <xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: Jianqun <jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	perex-/Fr2/VpizcU@public.gmane.org,
	tiwai-l3A5Bk7waGM@public.gmane.org,
	grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver
Date: Sun, 28 Sep 2014 11:48:51 +0100	[thread overview]
Message-ID: <20140928104851.GR27755@sirena.org.uk> (raw)
In-Reply-To: <54275C43.8010205-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1218 bytes --]

On Sun, Sep 28, 2014 at 08:54:27AM +0800, Jianqun wrote:

Please fix your mailer to word wrap within paragraphs.

> 在 09/12/2014 09:44 PM, Mark Brown 写道:
> > On Fri, Sep 12, 2014 at 03:30:36PM +0800, Jianqun wrote:
> >> Add documentation for rockchip-max98090 driver, which is need by rockchip
> >> board using a max98090.

> > Can this use simple-card (perhaps after a bit of extension)?
> I haven't ever try simple-card, is there any sample usage for me from other vendor ?

$ git grep -l simple-audio-card
Documentation/devicetree/bindings/sound/simple-card.txt
arch/arm/boot/dts/kirkwood-openrd-client.dts
arch/arm/boot/dts/kirkwood-t5325.dts
arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
arch/arm/boot/dts/vf610-twr.dts
sound/soc/generic/simple-card.c

> >> +- rockchip,audio-codec : The phandle of the MAX98090 audio codec.

> > Is the driver really specific to this CODEC?

> I think yes, we need to add two gpio for mic and hp detect, but simple-card driver hasn't them

That'd be the "possibly with some extensions" bit then...  if they're
just isolated GPIOs there's not really much board specific about having
them.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver
Date: Sun, 28 Sep 2014 11:48:51 +0100	[thread overview]
Message-ID: <20140928104851.GR27755@sirena.org.uk> (raw)
In-Reply-To: <54275C43.8010205@rock-chips.com>

On Sun, Sep 28, 2014 at 08:54:27AM +0800, Jianqun wrote:

Please fix your mailer to word wrap within paragraphs.

> ? 09/12/2014 09:44 PM, Mark Brown ??:
> > On Fri, Sep 12, 2014 at 03:30:36PM +0800, Jianqun wrote:
> >> Add documentation for rockchip-max98090 driver, which is need by rockchip
> >> board using a max98090.

> > Can this use simple-card (perhaps after a bit of extension)?
> I haven't ever try simple-card, is there any sample usage for me from other vendor ?

$ git grep -l simple-audio-card
Documentation/devicetree/bindings/sound/simple-card.txt
arch/arm/boot/dts/kirkwood-openrd-client.dts
arch/arm/boot/dts/kirkwood-t5325.dts
arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
arch/arm/boot/dts/vf610-twr.dts
sound/soc/generic/simple-card.c

> >> +- rockchip,audio-codec : The phandle of the MAX98090 audio codec.

> > Is the driver really specific to this CODEC?

> I think yes, we need to add two gpio for mic and hp detect, but simple-card driver hasn't them

That'd be the "possibly with some extensions" bit then...  if they're
just isolated GPIOs there's not really much board specific about having
them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140928/d45d1b53/attachment.sig>

  reply	other threads:[~2014-09-28 10:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12  7:26 [PATCH 0/2] rockchip-max98090: add driver for rockchip board with max98090 Jianqun
2014-09-12  7:26 ` Jianqun
2014-09-12  7:30 ` [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver Jianqun
2014-09-12  7:30   ` Jianqun
2014-09-12  7:30   ` Jianqun
2014-09-12  9:10   ` Jianqun
2014-09-12  9:10     ` Jianqun
2014-09-12 10:04     ` Heiko Stübner
2014-09-12 10:04       ` Heiko Stübner
2014-09-12 10:04       ` Heiko Stübner
2014-09-12 10:12       ` Jianqun
2014-09-12 10:12         ` Jianqun
2014-09-12 13:44   ` Mark Brown
2014-09-12 13:44     ` Mark Brown
2014-09-28  0:54     ` Jianqun
2014-09-28  0:54       ` Jianqun
2014-09-28 10:48       ` Mark Brown [this message]
2014-09-28 10:48         ` Mark Brown
2014-09-28 10:48         ` Mark Brown
2014-09-28 11:05         ` Jianqun
2014-09-28 11:05           ` Jianqun
2014-09-12  7:32 ` [PATCH 2/2] ASoC: rockchip-max98090: add driver for rockchip board using a max98090 Jianqun
2014-09-12  7:32   ` Jianqun
2014-09-12  7:39 ` [PATCH] " Jianqun
2014-09-12  7:39   ` Jianqun
2014-09-12  7:39   ` Jianqun
2014-09-12 13:52   ` Mark Brown
2014-09-12 13:52     ` Mark Brown
2014-10-02  8:06     ` Jianqun
2014-10-02  8:06       ` Jianqun
2014-10-02  8:06       ` Jianqun
2014-09-12  7:43 ` [PATCH 2/2] " Jianqun
2014-09-12  7:43   ` Jianqun
2014-09-12  7:43   ` Jianqun
2014-10-02  8:36   ` [PATCH v2 " Jianqun
2014-10-02  8:36     ` Jianqun
2014-10-02  8:36     ` Jianqun
2014-10-02 10:22     ` Mark Brown
2014-10-02 10:22       ` Mark Brown
2014-10-02 10:22       ` Mark Brown
2014-09-12 13:42 ` [PATCH 0/2] rockchip-max98090: add driver for rockchip board with max98090 Mark Brown
2014-09-12 13:42   ` Mark Brown
2014-09-14  3:00   ` Jianqun
2014-09-14  3:00     ` Jianqun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140928104851.GR27755@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=cf@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jay.xu@rock-chips.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.de \
    --cc=xjq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.