All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/3] imx-usb-loader: new package
Date: Wed, 1 Oct 2014 18:16:26 +0200	[thread overview]
Message-ID: <20141001181626.64e6ef08@free-electrons.com> (raw)
In-Reply-To: <1412175826-9010-4-git-send-email-luca@lucaceresoli.net>

Dear Luca Ceresoli,

On Wed,  1 Oct 2014 17:03:46 +0200, Luca Ceresoli wrote:

> diff --git a/package/imx-usb-loader/Config.in.host b/package/imx-usb-loader/Config.in.host
> new file mode 100644
> index 0000000..2540ea9
> --- /dev/null
> +++ b/package/imx-usb-loader/Config.in.host
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_HOST_IMX_USB_LOADER
> +	bool "host imx-usb-loader"
> +	depends on BR2_arm || BR2_armeb
> +	select BR2_PACKAGE_LIBUSB # libusb >= 1.0 is required

Huh, no! BR2_PACKAGE_LIBUSB is the *target* libusb. If you depend on
host-libusb, you don't need to add any select here.

> diff --git a/package/imx-usb-loader/imx-usb-loader.mk b/package/imx-usb-loader/imx-usb-loader.mk
> new file mode 100644
> index 0000000..48ef35c
> --- /dev/null
> +++ b/package/imx-usb-loader/imx-usb-loader.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# imx-uxb-loader
> +#
> +################################################################################
> +
> +IMX_USB_LOADER_VERSION = f96aee286ea17c832b7ec922dd76842deb5ce299
> +IMX_USB_LOADER_SITE = $(call github,boundarydevices,imx_usb_loader,$(IMX_USB_LOADER_VERSION))
> +IMX_USB_LOADER_LICENSE = LGPLv2.1+, LGPL (getopt.*)

LGPL with no version specified?

> +IMX_USB_LOADER_LICENSE_FILES = COPYING
> +IMX_USB_LOADER_DEPENDENCIES = host-libusb
> +
> +define HOST_IMX_USB_LOADER_BUILD_CMDS
> +	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
> +endef
> +
> +define HOST_IMX_USB_LOADER_INSTALL_CMDS
> +    $(INSTALL) -D -m 0755 $(@D)/imx_usb $(HOST_DIR)/usr/bin
> +    $(INSTALL) -D -m 0755 $(@D)/imx_uart $(HOST_DIR)/usr/bin

Full path as the last argument.

Also: what about having this package enabled by default in the sabresd
defconfigs, if it makes sense to have this host tool enabled for those
configurations?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-10-01 16:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 15:03 [Buildroot] [PATCH v2 0/3] i.MX6 SABRESD improvements (using a Freescale kernel) Luca Ceresoli
2014-10-01 15:03 ` [Buildroot] [PATCH v2 1/3] freescale/imx6-sabresd: use global patch dir for U-Boot patches Luca Ceresoli
2014-10-01 15:03 ` [Buildroot] [PATCH v2 2/3] freescale/imx6-sabresd: lock down kernel headers to the kernel version Luca Ceresoli
2014-10-01 15:03 ` [Buildroot] [PATCH v2 3/3] imx-usb-loader: new package Luca Ceresoli
2014-10-01 16:16   ` Thomas Petazzoni [this message]
2014-10-01 16:55     ` Eric Nelson
2014-10-02  8:47     ` Luca Ceresoli
2014-10-02  9:17       ` Luca Ceresoli
2014-10-02  9:52       ` Thomas Petazzoni
2014-10-02 11:10         ` Luca Ceresoli
2014-10-02  9:13   ` Vincent Stehlé
2014-10-02 11:43     ` Luca Ceresoli
2014-10-01 17:37 ` [Buildroot] [PATCH v2 0/3] i.MX6 SABRESD improvements (using a Freescale kernel) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141001181626.64e6ef08@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.