All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vincent Stehlé" <vincent.stehle@freescale.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/3] imx-usb-loader: new package
Date: Thu, 2 Oct 2014 11:13:26 +0200	[thread overview]
Message-ID: <542D1736.70603@freescale.com> (raw)
In-Reply-To: <1412175826-9010-4-git-send-email-luca@lucaceresoli.net>

On 10/01/2014 05:03 PM, Luca Ceresoli wrote:
(snip)

Hi Luca,

Thank you for this imx_usb_loader "recipe".

I have just some small remarks for the configuration files (below), but
apart from that I could build the loader ok with 'make
host-imx-usb-loader', and boot through USB just fine. So thanks!

(..)
> diff --git a/package/imx-usb-loader/imx-usb-loader.mk b/package/imx-usb-loader/imx-usb-loader.mk
> new file mode 100644
> index 0000000..48ef35c
> --- /dev/null
> +++ b/package/imx-usb-loader/imx-usb-loader.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# imx-uxb-loader
> +#
> +################################################################################
> +
> +IMX_USB_LOADER_VERSION = f96aee286ea17c832b7ec922dd76842deb5ce299
> +IMX_USB_LOADER_SITE = $(call github,boundarydevices,imx_usb_loader,$(IMX_USB_LOADER_VERSION))
> +IMX_USB_LOADER_LICENSE = LGPLv2.1+, LGPL (getopt.*)
> +IMX_USB_LOADER_LICENSE_FILES = COPYING
> +IMX_USB_LOADER_DEPENDENCIES = host-libusb
> +
> +define HOST_IMX_USB_LOADER_BUILD_CMDS
> +	$(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
> +endef
> +
> +define HOST_IMX_USB_LOADER_INSTALL_CMDS
> +    $(INSTALL) -D -m 0755 $(@D)/imx_usb $(HOST_DIR)/usr/bin
> +    $(INSTALL) -D -m 0755 $(@D)/imx_uart $(HOST_DIR)/usr/bin

Wouldn't you want to install the supplied configurations files, too?
Like in:

  $(INSTALL) -D -m 0644 $(@D)/imx_usb.conf $(HOST_DIR)/etc/imx_usb.conf
  $(INSTALL) -D -m 0644 $(@D)/mx6_usb_work.conf
$(HOST_DIR)/etc/mx6_usb_work.conf

I feel they could be used as examples or, at least, starting points.

Maybe you want to patch a bit imx_usb, to change the default
configuration files path? It defaults to '/etc/imx-loader.d/' but I
think we could have something better in the buildroot case, like
"$(HOST_DIR)/etc".

> +endef
> +
> +$(eval $(host-generic-package))

Best regards,

V.

  parent reply	other threads:[~2014-10-02  9:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01 15:03 [Buildroot] [PATCH v2 0/3] i.MX6 SABRESD improvements (using a Freescale kernel) Luca Ceresoli
2014-10-01 15:03 ` [Buildroot] [PATCH v2 1/3] freescale/imx6-sabresd: use global patch dir for U-Boot patches Luca Ceresoli
2014-10-01 15:03 ` [Buildroot] [PATCH v2 2/3] freescale/imx6-sabresd: lock down kernel headers to the kernel version Luca Ceresoli
2014-10-01 15:03 ` [Buildroot] [PATCH v2 3/3] imx-usb-loader: new package Luca Ceresoli
2014-10-01 16:16   ` Thomas Petazzoni
2014-10-01 16:55     ` Eric Nelson
2014-10-02  8:47     ` Luca Ceresoli
2014-10-02  9:17       ` Luca Ceresoli
2014-10-02  9:52       ` Thomas Petazzoni
2014-10-02 11:10         ` Luca Ceresoli
2014-10-02  9:13   ` Vincent Stehlé [this message]
2014-10-02 11:43     ` Luca Ceresoli
2014-10-01 17:37 ` [Buildroot] [PATCH v2 0/3] i.MX6 SABRESD improvements (using a Freescale kernel) Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542D1736.70603@freescale.com \
    --to=vincent.stehle@freescale.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.