* [PATCH] ASoC: rt286: Fix compilation warning for !PM
@ 2014-10-02 7:27 Thierry Reding
2014-10-02 10:53 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2014-10-02 7:27 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, linux-kernel
From: Thierry Reding <treding@nvidia.com>
The rt286_index_sync() function is only called in the resume path. If PM
is disabled it becomes unused and shouldn't be built either.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
sound/soc/codecs/rt286.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/rt286.c b/sound/soc/codecs/rt286.c
index b86b426f159d..4aa555cbcca8 100644
--- a/sound/soc/codecs/rt286.c
+++ b/sound/soc/codecs/rt286.c
@@ -269,6 +269,7 @@ static int rt286_hw_read(void *context, unsigned int reg, unsigned int *value)
return 0;
}
+#ifdef CONFIG_PM
static void rt286_index_sync(struct snd_soc_codec *codec)
{
struct rt286_priv *rt286 = snd_soc_codec_get_drvdata(codec);
@@ -279,6 +280,7 @@ static void rt286_index_sync(struct snd_soc_codec *codec)
rt286->index_cache[i].def);
}
}
+#endif
static int rt286_support_power_controls[] = {
RT286_DAC_OUT1,
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: rt286: Fix compilation warning for !PM
2014-10-02 7:27 [PATCH] ASoC: rt286: Fix compilation warning for !PM Thierry Reding
@ 2014-10-02 10:53 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-10-02 10:53 UTC (permalink / raw)
To: Thierry Reding; +Cc: alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
On Thu, Oct 02, 2014 at 09:27:03AM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The rt286_index_sync() function is only called in the resume path. If PM
> is disabled it becomes unused and shouldn't be built either.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-02 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-02 7:27 [PATCH] ASoC: rt286: Fix compilation warning for !PM Thierry Reding
2014-10-02 10:53 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.