All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Alex Deucher <alexdeucher@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linuxppc-dev@ozlabs.org, Dave Airlie <airlied@linux.ie>,
	linux-pci@vger.kernel.org, Anton Blanchard <anton@au1.ibm.com>,
	Yijing Wang <wangyijing@huawei.com>, Takashi Iwai <tiwai@suse.de>,
	Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver
Date: Thu, 2 Oct 2014 11:53:38 +1000	[thread overview]
Message-ID: <20141002115338.3a0ae11f@canb.auug.org.au> (raw)
In-Reply-To: <1412210082.10667.2.camel@pasglop>

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Hi Ben,

On Thu, 02 Oct 2014 10:34:42 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index aa302fb..f91ba7f 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -296,7 +296,8 @@ enum {
>  
>  /* quirks for ATI/AMD HDMI */
>  #define AZX_DCAPS_PRESET_ATI_HDMI \
> -	(AZX_DCAPS_NO_TCSEL | AZX_DCAPS_SYNC_WRITE | AZX_DCAPS_POSFIX_LPIB)
> +	(AZX_DCAPS_NO_TCSEL | AZX_DCAPS_SYNC_WRITE | AZX_DCAPS_POSFIX_LPIB|\
> +	 AZX_DCAPS_NO_MSI64)
>  
>  /* quirks for Nvidia */
>  #define AZX_DCAPS_PRESET_NVIDIA \
> @@ -1505,9 +1506,14 @@ static int azx_first_init(struct azx *chip)
>  		return -ENXIO;
>  	}
>  
> -	if (chip->msi)
> +	if (chip->msi) {
> +		if (chip->driver_caps & AZX_DCAPS_NO_MSI64) {
> +			dev_dbg(card->dev, "Disabling 64bit MSI\n");
> +			pci->no_64bit_msi = true;

You get the idea :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Dave Airlie <airlied@linux.ie>,
	linux-pci@vger.kernel.org, Brian King <brking@linux.vnet.ibm.com>,
	Anton Blanchard <anton@au1.ibm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Yijing Wang <wangyijing@huawei.com>, Takashi Iwai <tiwai@suse.de>,
	Alex Deucher <alexdeucher@gmail.com>
Subject: Re: [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver
Date: Thu, 2 Oct 2014 11:53:38 +1000	[thread overview]
Message-ID: <20141002115338.3a0ae11f@canb.auug.org.au> (raw)
In-Reply-To: <1412210082.10667.2.camel@pasglop>

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Hi Ben,

On Thu, 02 Oct 2014 10:34:42 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index aa302fb..f91ba7f 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -296,7 +296,8 @@ enum {
>  
>  /* quirks for ATI/AMD HDMI */
>  #define AZX_DCAPS_PRESET_ATI_HDMI \
> -	(AZX_DCAPS_NO_TCSEL | AZX_DCAPS_SYNC_WRITE | AZX_DCAPS_POSFIX_LPIB)
> +	(AZX_DCAPS_NO_TCSEL | AZX_DCAPS_SYNC_WRITE | AZX_DCAPS_POSFIX_LPIB|\
> +	 AZX_DCAPS_NO_MSI64)
>  
>  /* quirks for Nvidia */
>  #define AZX_DCAPS_PRESET_NVIDIA \
> @@ -1505,9 +1506,14 @@ static int azx_first_init(struct azx *chip)
>  		return -ENXIO;
>  	}
>  
> -	if (chip->msi)
> +	if (chip->msi) {
> +		if (chip->driver_caps & AZX_DCAPS_NO_MSI64) {
> +			dev_dbg(card->dev, "Disabling 64bit MSI\n");
> +			pci->no_64bit_msi = true;

You get the idea :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-10-02  1:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02  0:34 [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver Benjamin Herrenschmidt
2014-10-02  0:34 ` Benjamin Herrenschmidt
2014-10-02  1:53 ` Stephen Rothwell [this message]
2014-10-02  1:53   ` Stephen Rothwell
2014-10-02  2:13 ` Alex Deucher
2014-10-02  2:13   ` Alex Deucher
2014-10-02  7:59   ` Takashi Iwai
2014-10-02  7:59     ` Takashi Iwai
2014-10-02 12:09     ` Benjamin Herrenschmidt
2014-10-02 12:09       ` Benjamin Herrenschmidt
2014-10-03  5:23   ` Benjamin Herrenschmidt
2014-10-03  5:23     ` Benjamin Herrenschmidt
2014-10-03 13:05     ` Alex Deucher
2014-10-03 13:05       ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002115338.3a0ae11f@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=airlied@linux.ie \
    --cc=alexdeucher@gmail.com \
    --cc=anton@au1.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tiwai@suse.de \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.