From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alfonso Acosta <fons@spotify.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Include ADV_IND report in Device Connected event
Date: Fri, 3 Oct 2014 13:20:23 +0300 [thread overview]
Message-ID: <20141003102023.GA8095@t440s.lan> (raw)
In-Reply-To: <7F79038B-2FA8-4DF5-B25A-D7E9AAE922A8@holtmann.org>
Hi,
On Fri, Oct 03, 2014, Marcel Holtmann wrote:
> > void mgmt_device_connected(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
> > u8 addr_type, u32 flags, u8 *name, u8 name_len,
> > - u8 *dev_class);
> > + u8 *dev_class, u8 *adv, u8 adv_len);
>
> I keep wondering if we might just handover hci_conn instead. Something
> Johan needs to comment on here.
That's something I was actually thinking of myself. I have no objections
to simplifying the parameter list by passing the whole hci_conn to this
function (this should however be done as a separate patch before this
one).
Johan
next prev parent reply other threads:[~2014-10-03 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 8:34 [PATCH] Bluetooth: Include ADV_IND report in Device Connected event Alfonso Acosta
2014-10-03 9:47 ` Marcel Holtmann
2014-10-03 10:20 ` Johan Hedberg [this message]
2014-10-03 12:16 ` Alfonso Acosta
2014-10-03 12:13 ` Alfonso Acosta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003102023.GA8095@t440s.lan \
--to=johan.hedberg@gmail.com \
--cc=fons@spotify.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.