All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alfonso Acosta <fons@spotify.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: BlueZ development <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Include ADV_IND report in Device Connected event
Date: Fri, 3 Oct 2014 14:13:19 +0200	[thread overview]
Message-ID: <CAHF=Y4qa5-2sNzS5z1h8uurqaNt2c-ykSbiLxZSGdm6SMKSp0w@mail.gmail.com> (raw)
In-Reply-To: <7F79038B-2FA8-4DF5-B25A-D7E9AAE922A8@holtmann.org>

Hi Marcel,

>> -     if (!test_and_set_bit(HCI_CONN_MGMT_CONNECTED, &conn->flags))
>> +     if (!test_and_set_bit(HCI_CONN_MGMT_CONNECTED, &conn->flags)) {
>>               mgmt_device_connected(hdev, &conn->dst, conn->type,
>> -                                   conn->dst_type, 0, NULL, 0, NULL);
>> +                                   conn->dst_type, 0, NULL, 0, NULL,
>> +                                   conn->le_pend_adv_data,
>> +                                   conn->le_pend_adv_len);
>> +             conn->le_pend_adv_len = 0;
>
> The reset to 0 seems like not a good idea. What is this trying to fix.

It just made it consistent with the naming (it's not pending anymore
once you send it). Now that the naming changed it doesn't make sense,
I will remove it.

All your remarks have been taken care of in patch version 2.


-- 
Alfonso Acosta

Embedded Systems Engineer at Spotify
Birger Jarlsgatan 61, Stockholm, Sweden
http://www.spotify.com

      parent reply	other threads:[~2014-10-03 12:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03  8:34 [PATCH] Bluetooth: Include ADV_IND report in Device Connected event Alfonso Acosta
2014-10-03  9:47 ` Marcel Holtmann
2014-10-03 10:20   ` Johan Hedberg
2014-10-03 12:16     ` Alfonso Acosta
2014-10-03 12:13   ` Alfonso Acosta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHF=Y4qa5-2sNzS5z1h8uurqaNt2c-ykSbiLxZSGdm6SMKSp0w@mail.gmail.com' \
    --to=fons@spotify.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.