* [Qemu-devel] [PATCH] qcow2: fix leak of Qcow2DiscardRegion in update_refcount_discard
@ 2014-10-11 8:35 Zhang Haoyu
2014-10-12 13:15 ` Max Reitz
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Haoyu @ 2014-10-11 8:35 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi
When the Qcow2DiscardRegion is adjacent to another one referenced by "d",
free this Qcow2DiscardRegion metadata referenced by "p" after
it was removed from s->discards queue.
Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
---
block/qcow2-refcount.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 2bcaaf9..c31d85a 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -524,6 +524,7 @@ found:
QTAILQ_REMOVE(&s->discards, p, next);
d->offset = MIN(d->offset, p->offset);
d->bytes += p->bytes;
+ g_free(p);
}
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: fix leak of Qcow2DiscardRegion in update_refcount_discard
2014-10-11 8:35 [Qemu-devel] [PATCH] qcow2: fix leak of Qcow2DiscardRegion in update_refcount_discard Zhang Haoyu
@ 2014-10-12 13:15 ` Max Reitz
0 siblings, 0 replies; 2+ messages in thread
From: Max Reitz @ 2014-10-12 13:15 UTC (permalink / raw)
To: Zhang Haoyu, qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi
Am 11.10.2014 um 10:35 schrieb Zhang Haoyu:
> When the Qcow2DiscardRegion is adjacent to another one referenced by "d",
> free this Qcow2DiscardRegion metadata referenced by "p" after
> it was removed from s->discards queue.
>
> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
> ---
> block/qcow2-refcount.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-12 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-11 8:35 [Qemu-devel] [PATCH] qcow2: fix leak of Qcow2DiscardRegion in update_refcount_discard Zhang Haoyu
2014-10-12 13:15 ` Max Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.