All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pcmcia: fix sign extension on 64bit machines
@ 2014-10-14 12:39 One Thousand Gnomes
  0 siblings, 0 replies; only message in thread
From: One Thousand Gnomes @ 2014-10-14 12:39 UTC (permalink / raw)
  To: linux-pcmcia, linux-kernel

If you try and run pcmcia on a 64bit box the upper 32bits of the resource
flags all end up set due to a sign extension bug in the PCMCIA core

Signed-off-by: Alan Cox <alan@linux.intel.com>

diff -u --new-file --recursive --exclude-from ac/.gitignore next/drivers/pcmcia/cs_internal.h ac/drivers/pcmcia/cs_internal.h
--- next/drivers/pcmcia/cs_internal.h	2013-10-28 11:40:29.717315588 +0000
+++ ac/drivers/pcmcia/cs_internal.h	2014-09-06 17:25:32.959662243 +0100
@@ -82,7 +82,7 @@
 extern int static_init(struct pcmcia_socket *s);
 extern struct resource *pcmcia_make_resource(unsigned long start,
 					unsigned long end,
-					int flags, const char *name);
+					unsigned long flags, const char *name);
 
 /*
  * Stuff internal to module "pcmcia_core":
diff -u --new-file --recursive --exclude-from ac/.gitignore next/drivers/pcmcia/rsrc_mgr.c ac/drivers/pcmcia/rsrc_mgr.c
--- next/drivers/pcmcia/rsrc_mgr.c	2013-10-28 11:40:29.721315588 +0000
+++ ac/drivers/pcmcia/rsrc_mgr.c	2014-09-06 17:24:51.671663325 +0100
@@ -31,7 +31,7 @@
 }
 
 struct resource *pcmcia_make_resource(unsigned long start, unsigned long end,
-				int flags, const char *name)
+				unsigned long flags, const char *name)
 {
 	struct resource *res = kzalloc(sizeof(*res), GFP_KERNEL);
 


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-10-14 12:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-14 12:39 [PATCH] pcmcia: fix sign extension on 64bit machines One Thousand Gnomes

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.