* [nf_tables PATCH] netfilter: nft_compat: fix wrong target lookup in nft_target_select_ops()
@ 2014-10-26 11:22 Arturo Borrero Gonzalez
2014-10-27 21:20 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero Gonzalez @ 2014-10-26 11:22 UTC (permalink / raw)
To: netfilter-devel; +Cc: pablo
The code looks for an already loaded target, and the correct list to search
is nft_target_list, not nft_match_list.
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
NOTE: Compile-tested only.
net/netfilter/nft_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_compat.c b/net/netfilter/nft_compat.c
index 7e2683c..4f28109 100644
--- a/net/netfilter/nft_compat.c
+++ b/net/netfilter/nft_compat.c
@@ -611,7 +611,7 @@ nft_target_select_ops(const struct nft_ctx *ctx,
family = ctx->afi->family;
/* Re-use the existing target if it's already loaded. */
- list_for_each_entry(nft_target, &nft_match_list, head) {
+ list_for_each_entry(nft_target, &nft_target_list, head) {
struct xt_target *target = nft_target->ops.data;
if (strcmp(target->name, tg_name) == 0 &&
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nf_tables PATCH] netfilter: nft_compat: fix wrong target lookup in nft_target_select_ops()
2014-10-26 11:22 [nf_tables PATCH] netfilter: nft_compat: fix wrong target lookup in nft_target_select_ops() Arturo Borrero Gonzalez
@ 2014-10-27 21:20 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-10-27 21:20 UTC (permalink / raw)
To: Arturo Borrero Gonzalez; +Cc: netfilter-devel
On Sun, Oct 26, 2014 at 12:22:40PM +0100, Arturo Borrero Gonzalez wrote:
> The code looks for an already loaded target, and the correct list to search
> is nft_target_list, not nft_match_list.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-27 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-26 11:22 [nf_tables PATCH] netfilter: nft_compat: fix wrong target lookup in nft_target_select_ops() Arturo Borrero Gonzalez
2014-10-27 21:20 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.