All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] git-svn: use SVN::Ra::get_dir2 when possible
@ 2014-10-31 10:15 Eric Wong
  2014-10-31 10:34 ` [PATCH v2] " Eric Wong
  2014-11-02 12:31 ` [PATCH] " Hin-Tak Leung
  0 siblings, 2 replies; 12+ messages in thread
From: Eric Wong @ 2014-10-31 10:15 UTC (permalink / raw)
  To: Hin-Tak Leung
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

This avoids the following failure with normal "get_dir" on newer
versions of SVN (tested with SVN 1.8.8-1ubuntu3.1):

  Incorrect parameters given: Could not convert '%ld' into a number

get_dir2 also has the potential to be more efficient by requesting
less data.

ref: <1414636504.45506.YahooMailBasic@web172304.mail.ir2.yahoo.com>
ref: <1414722617.89476.YahooMailBasic@web172305.mail.ir2.yahoo.com>

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
---
  This should fix the vbox clone problem.  SVN Perl binding
  breakage (again :<).  I shall revert the int() changes.

  > I added those two lines to my git and there is no improvement. It
  > still won't svn fetch the next revision. I think it may be
  > important/interesting to find out when or how it becomes non-int, so
  > I have tar'gz'ed my wont-fetch virtual box .git and in the middle of
  > uploading here: 
  >
  > http://sourceforge.net/projects/outmodedbonsai/files/R/

  > I am also uploading my old R clone also - maybe you'd like to see
  > why its .git/svn/.caches is so big compared to a recent one,

  Jakob's changes causes different access patterns, so it's expected the
  sizes vary.  I also changed the cherry pick cache and removed the
  _rev_list caching entirely, so it should be much smaller now.

  > as well as how and why there were an extra merge and two missing
  > merges compared to a recent clone?

  The different merges are fine, I think, as stated in
    http://mid.gmane.org/20141030230831.GA14160@dcvr.yhbt.net

 perl/Git/SVN/Ra.pm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index 82d6108..1e52709 100644
--- a/perl/Git/SVN/Ra.pm
+++ b/perl/Git/SVN/Ra.pm
@@ -177,7 +177,17 @@ sub get_dir {
 		}
 	}
 	my $pool = SVN::Pool->new;
-	my ($d, undef, $props) = $self->SUPER::get_dir($dir, $r, $pool);
+	my ($d, undef, $props);
+
+	if (defined &SVN::Ra::get_dir2) { # appeared in SVN 1.4
+		# n.b. in addition to being potentially more efficient,
+		# this works around what appears to be a bug in some
+		# SVN 1.8 versions
+		my $kind = 1; # SVN_DIRENT_KIND
+		($d, undef, $props) = $self->get_dir2($dir, $r, $kind, $pool);
+	} else {
+		($d, undef, $props) = $self->get_dir($dir, $r, $pool);
+	}
 	my %dirents = map { $_ => { kind => $d->{$_}->kind } } keys %$d;
 	$pool->clear;
 	if ($r != $cache->{r}) {
-- 
EW

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
  2014-10-31 10:15 [PATCH] git-svn: use SVN::Ra::get_dir2 when possible Eric Wong
@ 2014-10-31 10:34 ` Eric Wong
  2014-10-31 19:08   ` Eric Wong
  2014-11-02 12:31 ` [PATCH] " Hin-Tak Leung
  1 sibling, 1 reply; 12+ messages in thread
From: Eric Wong @ 2014-10-31 10:34 UTC (permalink / raw)
  To: Hin-Tak Leung
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

This avoids the following failure with normal "get_dir" on newer
versions of SVN (tested with SVN 1.8.8-1ubuntu3.1):

  Incorrect parameters given: Could not convert '%ld' into a number

get_dir2 also has the potential to be more efficient by requesting
less data.

ref: <1414636504.45506.YahooMailBasic@web172304.mail.ir2.yahoo.com>
ref: <1414722617.89476.YahooMailBasic@web172305.mail.ir2.yahoo.com>

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
---
 Sorry, waaay past my bed time.  This version doesn't infinite loop
 on autoload or older SVN(*) (at least I hope it doesn't)

 perl/Git/SVN/Ra.pm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
index 82d6108..496f430 100644
--- a/perl/Git/SVN/Ra.pm
+++ b/perl/Git/SVN/Ra.pm
@@ -177,7 +177,17 @@ sub get_dir {
 		}
 	}
 	my $pool = SVN::Pool->new;
-	my ($d, undef, $props) = $self->SUPER::get_dir($dir, $r, $pool);
+	my ($d, undef, $props);
+
+	if (::compare_svn_version('1.4.0') >= 0) {
+		# n.b. in addition to being potentially more efficient,
+		# this works around what appears to be a bug in some
+		# SVN 1.8 versions
+		my $kind = 1; # SVN_DIRENT_KIND
+		($d, undef, $props) = $self->get_dir2($dir, $r, $kind, $pool);
+	} else {
+		($d, undef, $props) = $self->SUPER::get_dir($dir, $r, $pool);
+	}
 	my %dirents = map { $_ => { kind => $d->{$_}->kind } } keys %$d;
 	$pool->clear;
 	if ($r != $cache->{r}) {
-- 
EW

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
  2014-10-31 10:34 ` [PATCH v2] " Eric Wong
@ 2014-10-31 19:08   ` Eric Wong
  0 siblings, 0 replies; 12+ messages in thread
From: Eric Wong @ 2014-10-31 19:08 UTC (permalink / raw)
  To: git
  Cc: stoklund, fabian.schmied, sam, stevenrwalter, waste.manager,
	amyrick, Hin-Tak Leung

Eric Wong <normalperson@yhbt.net> wrote:
> This avoids the following failure with normal "get_dir" on newer
> versions of SVN (tested with SVN 1.8.8-1ubuntu3.1):
> 
>   Incorrect parameters given: Could not convert '%ld' into a number

Filed a bug in Debian since I hit it in sid, too:
http://bugs.debian.org/767530

Thanks all.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] git-svn: use SVN::Ra::get_dir2 when possible
  2014-10-31 10:15 [PATCH] git-svn: use SVN::Ra::get_dir2 when possible Eric Wong
  2014-10-31 10:34 ` [PATCH v2] " Eric Wong
@ 2014-11-02 12:31 ` Hin-Tak Leung
  2014-11-02 23:04   ` Eric Wong
  1 sibling, 1 reply; 12+ messages in thread
From: Hin-Tak Leung @ 2014-11-02 12:31 UTC (permalink / raw)
  To: Eric Wong
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

Hmm, I see you are filing the problem against subversion. FWIW,
I am currently using subversion-perl-1.8.10-1.fc20.x86_64 package on fedora 20.
I'll possibly think about filing one under redhat's bugzilla and
let them take it upward too.

--------------------------------------------
On Fri, 31/10/14, Eric Wong <normalperson@yhbt.net> wrote:

 This avoids the following failure
 with normal "get_dir" on newer
 versions of SVN (tested with SVN 1.8.8-1ubuntu3.1):
 
   Incorrect parameters given: Could not convert '%ld'
 into a number
 
 get_dir2 also has the potential to be more efficient by
 requesting
 less data.
 
 ref: <1414636504.45506.YahooMailBasic@web172304.mail.ir2.yahoo.com>
 ref: <1414722617.89476.YahooMailBasic@web172305.mail.ir2.yahoo.com>
 
 Signed-off-by: Eric Wong <normalperson@yhbt.net>
 Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
 ---
   This should fix the vbox clone problem.  SVN
 Perl binding
   breakage (again :<).  I shall revert the
 int() changes.
 
   > I added those two lines to my git and there is
 no improvement. It
   > still won't svn fetch the next revision. I think
 it may be
   > important/interesting to find out when or how it
 becomes non-int, so
   > I have tar'gz'ed my wont-fetch virtual box .git
 and in the middle of
   > uploading here: 
   >
   > http://sourceforge.net/projects/outmodedbonsai/files/R/
 
   > I am also uploading my old R clone also - maybe
 you'd like to see
   > why its .git/svn/.caches is so big compared to a
 recent one,
 
   Jakob's changes causes different access patterns, so
 it's expected the
   sizes vary.  I also changed the cherry pick
 cache and removed the
   _rev_list caching entirely, so it should be much
 smaller now.
 
   > as well as how and why there were an extra merge
 and two missing
   > merges compared to a recent clone?
 
   The different merges are fine, I think, as stated in
     http://mid.gmane.org/20141030230831.GA14160@dcvr.yhbt.net
 
  perl/Git/SVN/Ra.pm | 12 +++++++++++-
  1 file changed, 11 insertions(+), 1 deletion(-)
 
 diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
 index 82d6108..1e52709 100644
 --- a/perl/Git/SVN/Ra.pm
 +++ b/perl/Git/SVN/Ra.pm
 @@ -177,7 +177,17 @@ sub get_dir {
          }
      }
      my $pool = SVN::Pool->new;
 -    my ($d, undef, $props) =
 $self->SUPER::get_dir($dir, $r, $pool);
 +    my ($d, undef, $props);
 +
 +    if (defined &SVN::Ra::get_dir2) { #
 appeared in SVN 1.4
 +        # n.b. in addition to
 being potentially more efficient,
 +        # this works around
 what appears to be a bug in some
 +        # SVN 1.8 versions
 +        my $kind = 1; #
 SVN_DIRENT_KIND
 +        ($d, undef, $props) =
 $self->get_dir2($dir, $r, $kind, $pool);
 +    } else {
 +        ($d, undef, $props) =
 $self->get_dir($dir, $r, $pool);
 +    }
      my %dirents = map { $_ => { kind
 => $d->{$_}->kind } } keys %$d;
      $pool->clear;
      if ($r != $cache->{r}) {
 -- 
 EW
 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] git-svn: use SVN::Ra::get_dir2 when possible
  2014-11-02 12:31 ` [PATCH] " Hin-Tak Leung
@ 2014-11-02 23:04   ` Eric Wong
  0 siblings, 0 replies; 12+ messages in thread
From: Eric Wong @ 2014-11-02 23:04 UTC (permalink / raw)
  To: Hin-Tak Leung
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

Hin-Tak Leung <htl10@users.sourceforge.net> wrote:
> Hmm, I see you are filing the problem against subversion. FWIW,
> I am currently using subversion-perl-1.8.10-1.fc20.x86_64 package on fedora 20.
> I'll possibly think about filing one under redhat's bugzilla and
> let them take it upward too.

This is another problem with the vbox repository:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767530#10

And forwarded upstream:
  http://mid.gmane.org/20141101182722.GB20951@freya.jamessan.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
  2014-11-01  3:13     ` Eric Wong
@ 2014-11-01  6:13       ` Hin-Tak Leung
  0 siblings, 0 replies; 12+ messages in thread
From: Hin-Tak Leung @ 2014-11-01  6:13 UTC (permalink / raw)
  To: Eric Wong
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

--------------------------------------------
On Sat, 1/11/14, Eric Wong <normalperson@yhbt.net> wrote:

 Hin-Tak Leung <htl10@users.sourceforge.net>
 wrote:
> > While my 2.10 + 11 patches
 continue to fetch, where it was stuck, now
 > it does "Couldn't find
 revmap..." - also, the single branch clone is doing
 > the 'trunk/branches/... thing - are
 these supposed to happen?
 
> I'm afraid this is a problem with the vbox
 repo not publishing anything
 but trunk, but
 their svn:mergeinfo refers to non-public branches.
 
> This shows only changes to
 trunk:
 
>     svn log -v http://www.virtualbox.org/svn/vbox
 
> I do not know what their
 development process is like.  From the looks of
 it, every change is made by a
 "vboxsync" user.  I suspect that's driven
 by an automated export script, and the real
 development happens in a
 different (private)
 repo...
 
They are Sun/Oracle technology so have that sort of style, I think.
(Think Java and everything to do with Java).

I did get a bit confused about that - their web code broswing interface
shows a number of merges and deleted branches.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
  2014-11-01  2:19   ` Hin-Tak Leung
@ 2014-11-01  3:13     ` Eric Wong
  2014-11-01  6:13       ` Hin-Tak Leung
  0 siblings, 1 reply; 12+ messages in thread
From: Eric Wong @ 2014-11-01  3:13 UTC (permalink / raw)
  To: Hin-Tak Leung
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

Hin-Tak Leung <htl10@users.sourceforge.net> wrote:
> While my 2.10 + 11 patches continue to fetch, where it was stuck, now
> it does "Couldn't find revmap..." - also, the single branch clone is doing
> the 'trunk/branches/... thing - are these supposed to happen?

I'm afraid this is a problem with the vbox repo not publishing anything
but trunk, but their svn:mergeinfo refers to non-public branches.

This shows only changes to trunk:

	svn log -v http://www.virtualbox.org/svn/vbox

I do not know what their development process is like.  From the looks of
it, every change is made by a "vboxsync" user.  I suspect that's driven
by an automated export script, and the real development happens in a
different (private) repo...

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
  2014-10-31 23:22 ` Eric Wong
@ 2014-11-01  2:19   ` Hin-Tak Leung
  2014-11-01  3:13     ` Eric Wong
  0 siblings, 1 reply; 12+ messages in thread
From: Hin-Tak Leung @ 2014-11-01  2:19 UTC (permalink / raw)
  To: Eric Wong
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick


--------------------------------------------
On Sat, 1/11/14, Eric Wong <normalperson@yhbt.net> wrote:
 
 Hin-Tak Leung <htl10@users.sourceforge.net>
 wrote:
> > Tested-by: Hin-Tak Leung <htl10@users.sourceforge.net>
 > 
 > Okay, this one on
 top of my "git 2.1.0 + 10 recent git svn improvement
 patches"
 > allow me to fetch
 further.
 > 
 > I
 suspect the problem must be elsewhere though, and this just
 band-aided
 > over it.
 > 
 > For me, reverting
 the additional patches and just use git 2.1.0 also allow
 > me to fetch further, so the problem appear
 to me to be associated with
 > the
 additional patches.
 
 > Junio
 already pulled all of those git-svn patches into git
 2.2.0-rc0:
 
> http://mid.gmane.org/xmqq7fzgt0q4.fsf@gitster.dls.corp.google.com
 
> Can you give that a try? 
 I've been able to complete the vbox
 fetch without problems.

While my 2.10 + 11 patches continue to fetch, where it was stuck, now
it does "Couldn't find revmap..." - also, the single branch clone is doing
the 'trunk/branches/... thing - are these supposed to happen?

--stdlayout:

$ git svn fetch --all
Index mismatch: d6c75bc195b1daad647322e2cc025bd31265c6b9 != 3927d05f6ab037fcf2b4d964c9633efade037d1b
rereading a65b5fc0077c2fa80a344833b65ac19ff4ae88b6
	M	src/VBox/Main/HostImpl.cpp
Checking svn:mergeinfo changes since r28923: 1 sources, 1 changed
Couldn't find revmap for http://www.virtualbox.org/svn/vbox/branches/VBox-3.0
r28924 = 4e01065451e00c725c88113584461ee3284e3952 (refs/remotes/origin/trunk)

without --stdlayout:

$ git svn fetch --all
Index mismatch: d6c75bc195b1daad647322e2cc025bd31265c6b9 != 3927d05f6ab037fcf2b4d964c9633efade037d1b
rereading a65b5fc0077c2fa80a344833b65ac19ff4ae88b6
	M	src/VBox/Main/HostImpl.cpp
Checking svn:mergeinfo changes since r28923: 1 sources, 1 changed
Couldn't find revmap for http://www.virtualbox.org/svn/vbox/trunk/branches/VBox-3.0
r28924 = 4e01065451e00c725c88113584461ee3284e3952 (refs/remotes/git-svn)
 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
  2014-10-31 21:53 Hin-Tak Leung
@ 2014-10-31 23:22 ` Eric Wong
  2014-11-01  2:19   ` Hin-Tak Leung
  0 siblings, 1 reply; 12+ messages in thread
From: Eric Wong @ 2014-10-31 23:22 UTC (permalink / raw)
  To: Hin-Tak Leung
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

Hin-Tak Leung <htl10@users.sourceforge.net> wrote:
> Tested-by: Hin-Tak Leung <htl10@users.sourceforge.net>
> 
> Okay, this one on top of my "git 2.1.0 + 10 recent git svn improvement patches"
> allow me to fetch further.
> 
> I suspect the problem must be elsewhere though, and this just band-aided
> over it.
> 
> For me, reverting the additional patches and just use git 2.1.0 also allow
> me to fetch further, so the problem appear to me to be associated with
> the additional patches.

Junio already pulled all of those git-svn patches into git 2.2.0-rc0:

http://mid.gmane.org/xmqq7fzgt0q4.fsf@gitster.dls.corp.google.com

Can you give that a try?  I've been able to complete the vbox
fetch without problems.

> But you are saying that git-svn on debian as shipped
> exhibit this problem? 

No, I'm saying unrelated, (old) functionality such as
"git svn show-ignore" also got broken by this SVN bug.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
@ 2014-10-31 21:53 Hin-Tak Leung
  2014-10-31 23:22 ` Eric Wong
  0 siblings, 1 reply; 12+ messages in thread
From: Hin-Tak Leung @ 2014-10-31 21:53 UTC (permalink / raw)
  To: normalperson
  Cc: stoklund, fabian.schmied, git, sam, stevenrwalter, waste.manager,
	amyrick

-------------------------
On Fri, Oct 31, 2014 10:34 GMT Eric Wong wrote:

>This avoids the following failure with normal "get_dir" on newer
>versions of SVN (tested with SVN 1.8.8-1ubuntu3.1):
>
>  Incorrect parameters given: Could not convert '%ld' into a number
>
>get_dir2 also has the potential to be more efficient by requesting
>less data.
>
>ref: <1414636504.45506.YahooMailBasic@web172304.mail.ir2.yahoo.com>
>ref: <1414722617.89476.YahooMailBasic@web172305.mail.ir2.yahoo.com>
>
>Signed-off-by: Eric Wong <normalperson@yhbt.net>
>Cc: Hin-Tak Leung <htl10@users.sourceforge.net>

Tested-by: Hin-Tak Leung <htl10@users.sourceforge.net>

Okay, this one on top of my "git 2.1.0 + 10 recent git svn improvement patches"
allow me to fetch further.

I suspect the problem must be elsewhere though, and this just band-aided
over it.

For me, reverting the additional patches and just use git 2.1.0 also allow
me to fetch further, so the problem appear to me to be associated with
the additional patches. But you are saying that git-svn on debian as shipped
exhibit this problem? 

>---
> Sorry, waaay past my bed time.  This version doesn't infinite loop
> on autoload or older SVN(*) (at least I hope it doesn't)
>
> perl/Git/SVN/Ra.pm | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
>index 82d6108..496f430 100644
>--- a/perl/Git/SVN/Ra.pm
>+++ b/perl/Git/SVN/Ra.pm
>@@ -177,7 +177,17 @@ sub get_dir {
>         }
>     }
>     my $pool = SVN::Pool->new;
>-    my ($d, undef, $props) = $self->SUPER::get_dir($dir, $r, $pool);
>+    my ($d, undef, $props);
>+
>+    if (::compare_svn_version('1.4.0') >= 0) {
>+        # n.b. in addition to being potentially more efficient,
>+        # this works around what appears to be a bug in some
>+        # SVN 1.8 versions
>+        my $kind = 1; # SVN_DIRENT_KIND
>+        ($d, undef, $props) = $self->get_dir2($dir, $r, $kind, $pool);
>+    } else {
>+        ($d, undef, $props) = $self->SUPER::get_dir($dir, $r, $pool);
>+    }
>     my %dirents = map { $_ => { kind => $d->{$_}->kind } } keys %$d;
>     $pool->clear;
>     if ($r != $cache->{r}) {
>-- 
>EW
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
  2014-10-31 21:09 [PATCH v2] " Hin-Tak Leung
@ 2014-10-31 21:42 ` Eric Wong
  0 siblings, 0 replies; 12+ messages in thread
From: Eric Wong @ 2014-10-31 21:42 UTC (permalink / raw)
  To: Hin-Tak Leung
  Cc: git, stoklund, fabian.schmied, sam, stevenrwalter, waste.manager,
	amyrick

Hin-Tak Leung <htl10@users.sourceforge.net> wrote:
> On Fri, Oct 31, 2014 19:08 GMT Eric Wong wrote:
> >Filed a bug in Debian since I hit it in sid, too:
> >http://bugs.debian.org/767530
> >
> >Thanks all.
> 
> Hmm, but why are you filing at debian? I had the error when i applied
> the dev code patches on top of 2.1.0, and the error disappeared as
> soon as I reverted the patches. So it looks like a issue for the
> upstream developers, rather than distro. Are you saying debian is
> shipping a dev snapshot of git svn?

I don't track SVN upstream development, so haven't checked if it affects
newer SVN, yet.  It is the distro maintainer's job to get this resolved.

This bug affects existing cases of "git svn show-ignore",
we just happened to find it with "git svn fetch", first.

Debian's bug tracker also has the lowest barrier to entry:
no login/registration is necessary (just like this git list).
If you want to handle this with upstream directly, please do.
I try to avoid logins/accounts as much as possible.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2] git-svn: use SVN::Ra::get_dir2 when possible
@ 2014-10-31 21:09 Hin-Tak Leung
  2014-10-31 21:42 ` Eric Wong
  0 siblings, 1 reply; 12+ messages in thread
From: Hin-Tak Leung @ 2014-10-31 21:09 UTC (permalink / raw)
  To: normalperson, git
  Cc: stoklund, fabian.schmied, sam, stevenrwalter, waste.manager, amyrick



------------------------------
On Fri, Oct 31, 2014 19:08 GMT Eric Wong wrote:

>Eric Wong <normalperson@yhbt.net> wrote:
>> This avoids the following failure with normal "get_dir" on newer
>> versions of SVN (tested with SVN 1.8.8-1ubuntu3.1):
>> 
>>   Incorrect parameters given: Could not convert '%ld' into a number
>
>Filed a bug in Debian since I hit it in sid, too:
>http://bugs.debian.org/767530
>
>Thanks all.


Hmm, but why are you filing at debian? I had the error when i applied the dev code patches on top of 2.1.0, and the error disappeared as soon as I reverted the patches. So it looks like a issue for the upstream developers, rather than distro. Are you saying debian is shipping a dev snapshot of git svn?

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2014-11-02 23:04 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-31 10:15 [PATCH] git-svn: use SVN::Ra::get_dir2 when possible Eric Wong
2014-10-31 10:34 ` [PATCH v2] " Eric Wong
2014-10-31 19:08   ` Eric Wong
2014-11-02 12:31 ` [PATCH] " Hin-Tak Leung
2014-11-02 23:04   ` Eric Wong
2014-10-31 21:09 [PATCH v2] " Hin-Tak Leung
2014-10-31 21:42 ` Eric Wong
2014-10-31 21:53 Hin-Tak Leung
2014-10-31 23:22 ` Eric Wong
2014-11-01  2:19   ` Hin-Tak Leung
2014-11-01  3:13     ` Eric Wong
2014-11-01  6:13       ` Hin-Tak Leung

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.