All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: tlv320aic23: depends on SPI
@ 2014-11-03 18:07 ` Sudip Mukherjee
  0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2014-11-03 18:07 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
  Cc: Sudip Mukherjee, alsa-devel, linux-kernel, Jim Davis

Fix build errors when CONFIG_SPI is not enabled by making the
driver depend on SPI.

ERROR: "spi_setup" [sound/soc/codecs/snd-soc-tlv320aic23-spi.ko] undefined!
ERROR: "devm_regmap_init_spi" [sound/soc/codecs/snd-soc-tlv320aic23-spi.ko] undefined!
ERROR: "spi_register_driver" [sound/soc/codecs/snd-soc-tlv320aic23-spi.ko] undefined!

Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

reference of mail by Jim Davis at https://lkml.org/lkml/2014/11/3/551

 sound/soc/codecs/Kconfig | 1 +

1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 6801b38..9a8ea56 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -603,6 +603,7 @@ config SND_SOC_TLV320AIC23_I2C
 
 config SND_SOC_TLV320AIC23_SPI
 	tristate "Texas Instruments TLV320AIC23 audio CODEC - SPI"
+	depends on SPI
 	select SND_SOC_TLV320AIC23
 
 config SND_SOC_TLV320AIC26
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ASoC: tlv320aic23: depends on SPI
@ 2014-11-03 18:07 ` Sudip Mukherjee
  0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2014-11-03 18:07 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
  Cc: Jim Davis, alsa-devel, Sudip Mukherjee, linux-kernel

Fix build errors when CONFIG_SPI is not enabled by making the
driver depend on SPI.

ERROR: "spi_setup" [sound/soc/codecs/snd-soc-tlv320aic23-spi.ko] undefined!
ERROR: "devm_regmap_init_spi" [sound/soc/codecs/snd-soc-tlv320aic23-spi.ko] undefined!
ERROR: "spi_register_driver" [sound/soc/codecs/snd-soc-tlv320aic23-spi.ko] undefined!

Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

reference of mail by Jim Davis at https://lkml.org/lkml/2014/11/3/551

 sound/soc/codecs/Kconfig | 1 +

1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 6801b38..9a8ea56 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -603,6 +603,7 @@ config SND_SOC_TLV320AIC23_I2C
 
 config SND_SOC_TLV320AIC23_SPI
 	tristate "Texas Instruments TLV320AIC23 audio CODEC - SPI"
+	depends on SPI
 	select SND_SOC_TLV320AIC23
 
 config SND_SOC_TLV320AIC26
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: tlv320aic23: depends on SPI
  2014-11-03 18:07 ` Sudip Mukherjee
  (?)
@ 2014-11-04  0:56 ` Mark Brown
  -1 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-11-04  0:56 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
	linux-kernel, Jim Davis

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

On Mon, Nov 03, 2014 at 11:37:59PM +0530, Sudip Mukherjee wrote:
> Fix build errors when CONFIG_SPI is not enabled by making the
> driver depend on SPI.

A version of this patch has already been applied.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-04  0:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-03 18:07 [PATCH] ASoC: tlv320aic23: depends on SPI Sudip Mukherjee
2014-11-03 18:07 ` Sudip Mukherjee
2014-11-04  0:56 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.