From: Gyungoh Yoo <gyungoh@gmail.com> To: Paul Bolle <pebolle@tiscali.nl> Cc: Mark Brown <broonie@kernel.org>, sameo@linux.intel.com, lee.jones@linaro.org, jg1.han@samsung.com, cooloney@gmail.com, lgirdwood@gmail.com, jack.yoo@skyworksinc.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, grant.likely@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, pawel.moll@arm.com, heiko@sntech.de, jason@lakedaemon.net, shawn.guo@freescale.com, treding@nvidia.com, florian.vaussard@epfl.ch, trivial@kernel.org, linux@roeck-us.net, andrew@lunn.ch, jic23@kernel.org Subject: Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding Date: Thu, 6 Nov 2014 13:45:34 +0900 [thread overview] Message-ID: <20141106044534.GB5068@jack-ThinkPad-T520> (raw) In-Reply-To: <1415051139.20372.85.camel@x220> On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: > On Fri, 2014-10-31 at 16:44 +0000, Mark Brown wrote: > > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyungoh@gmail.com wrote: > > > From: Gyungoh Yoo <jack.yoo@skyworksinc.com> > > > > > > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com> > > > > This doesn't apply against current code and depends on the MFD symbol > > rename - can you please check what's going on here? > > > > It would make sense to split the Kconfig symbol rename into a separate > > patch to ease merging, > > The relicensing (from GPL to GPL v2, thus dropping the "or later" > provision) is odd too. The header still uses GPL v2 or later, doesn't > it? Anyhow, that could be a separate patch too. I will modify the licensing text and resubmit it. Thank you for your comment. > > > it doesn't seem obviously related to the driver > > change and should probably be in the same patch as the MFD symbol rename > > for bisetion. > > I don't think there will be bisection problems (in mainline). Currently > this driver depends on SKY81452. But that symbol doesn't exist. Only > after both 1/8 and this patch will this driver become buildable, for the > first time. So it's not that this driver was buildable, became > unbuildable in 1/8 and buildable again in this patch. > > (I don't think it's much of a problem that the regulator driver got > merged, in v3.18-rc1, before the mfd driver on which it depends. > Avoiding that temporarily problem appears to be more trouble than it's > worth.) > > > Paul Bolle >
WARNING: multiple messages have this Message-ID (diff)
From: Gyungoh Yoo <gyungoh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org, treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, florian.vaussard-p8DiymsW2f8@public.gmane.org, trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Subject: Re: [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding Date: Thu, 6 Nov 2014 13:45:34 +0900 [thread overview] Message-ID: <20141106044534.GB5068@jack-ThinkPad-T520> (raw) In-Reply-To: <1415051139.20372.85.camel@x220> On Mon, Nov 03, 2014 at 10:45:39PM +0100, Paul Bolle wrote: > On Fri, 2014-10-31 at 16:44 +0000, Mark Brown wrote: > > On Fri, Oct 31, 2014 at 04:08:41PM +0900, gyungoh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > > > From: Gyungoh Yoo <jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org> > > > > > > Signed-off-by: Gyungoh Yoo <jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org> > > > > This doesn't apply against current code and depends on the MFD symbol > > rename - can you please check what's going on here? > > > > It would make sense to split the Kconfig symbol rename into a separate > > patch to ease merging, > > The relicensing (from GPL to GPL v2, thus dropping the "or later" > provision) is odd too. The header still uses GPL v2 or later, doesn't > it? Anyhow, that could be a separate patch too. I will modify the licensing text and resubmit it. Thank you for your comment. > > > it doesn't seem obviously related to the driver > > change and should probably be in the same patch as the MFD symbol rename > > for bisetion. > > I don't think there will be bisection problems (in mainline). Currently > this driver depends on SKY81452. But that symbol doesn't exist. Only > after both 1/8 and this patch will this driver become buildable, for the > first time. So it's not that this driver was buildable, became > unbuildable in 1/8 and buildable again in this patch. > > (I don't think it's much of a problem that the regulator driver got > merged, in v3.18-rc1, before the mfd driver on which it depends. > Avoiding that temporarily problem appears to be more trouble than it's > worth.) > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-06 4:45 UTC|newest] Thread overview: 163+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-08 9:08 [PATCH 1/3] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo 2014-08-08 9:08 ` Gyungoh Yoo 2014-08-12 1:51 ` GyungOh Yoo 2014-08-12 7:16 ` Lee Jones 2014-08-12 2:21 ` Gyungoh Yoo 2014-08-12 2:21 ` Gyungoh Yoo 2014-08-21 9:45 ` Lee Jones 2014-08-21 9:45 ` Lee Jones 2014-08-21 9:59 ` Thierry Reding 2014-08-21 11:19 ` Lee Jones 2014-08-21 11:19 ` Lee Jones 2014-08-25 7:06 ` Gyungoh Yoo 2014-08-25 7:06 ` Gyungoh Yoo 2014-08-26 8:22 ` Lee Jones 2014-08-26 8:22 ` Lee Jones 2014-08-27 4:06 ` Gyungoh Yoo 2014-08-27 4:06 ` Gyungoh Yoo 2014-08-27 8:39 ` Lee Jones 2014-08-27 8:39 ` Lee Jones 2014-08-28 1:29 ` Gyungoh Yoo 2014-08-28 10:38 ` [PATCH v2 0/7] Adding Skyworks SKY81452 device drivers Gyungoh Yoo 2014-08-28 10:38 ` Gyungoh Yoo 2014-08-28 10:43 ` [PATCH v2 1/7] Adding Skyworks SKY81452 MFD driver Gyungoh Yoo 2014-08-28 10:43 ` Gyungoh Yoo 2014-08-29 2:03 ` [PATCH v2.1 " Gyungoh Yoo 2014-08-29 2:03 ` Gyungoh Yoo 2014-09-04 9:28 ` Lee Jones 2014-09-05 4:24 ` [PATCH v2.2 1/7] regulator: sky81452: " Gyungoh Yoo 2014-09-05 4:24 ` Gyungoh Yoo 2014-08-28 10:46 ` [PATCH v2 2/7] Adding Skyworks SKY81452 regulator driver Gyungoh Yoo 2014-08-28 10:46 ` Gyungoh Yoo 2014-08-28 11:02 ` Mark Brown 2014-08-29 2:21 ` Gyungoh Yoo 2014-08-29 2:21 ` Gyungoh Yoo 2014-08-28 10:49 ` [PATCH v2 3/7] Adding Skyworks SKY81452 backlight driver Gyungoh Yoo 2014-08-28 10:49 ` Gyungoh Yoo 2014-08-28 10:49 ` Gyungoh Yoo 2014-08-28 10:56 ` [PATCH v2 4/7] Adding SKY81452 MFD device tree bindings document Gyungoh Yoo 2014-08-28 10:58 ` [PATCH v2 5/7] Adding SKY81452 regulator " Gyungoh Yoo 2014-08-28 10:58 ` Gyungoh Yoo 2014-09-01 2:46 ` Gyungoh Yoo 2014-09-01 2:46 ` Gyungoh Yoo 2014-08-28 11:00 ` [PATCH v2 6/7] Adding SKY81452 backlight " Gyungoh Yoo 2014-08-28 11:00 ` Gyungoh Yoo 2014-08-28 11:01 ` [PATCH v2 7/7] Adding SKY81452 backlight document Gyungoh Yoo 2014-10-07 4:55 ` [RESUBMIT PATCH v3 0/8] Adding Skyworks SKY81452 device drivers Gyungoh Yoo 2014-10-07 4:55 ` Gyungoh Yoo 2014-10-07 4:58 ` [RESUBMIT PATCH v3 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo 2014-10-07 8:12 ` Lee Jones 2014-10-07 8:23 ` Gyungoh Yoo 2014-10-07 8:23 ` Gyungoh Yoo 2014-10-07 5:01 ` [RESUBMIT PATCH v3 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo 2014-10-07 5:01 ` Gyungoh Yoo 2014-10-07 5:01 ` Gyungoh Yoo 2014-10-08 1:03 ` Jingoo Han 2014-10-08 1:03 ` Jingoo Han 2014-10-08 1:03 ` Jingoo Han 2014-10-08 8:55 ` Gyungoh Yoo 2014-10-08 8:55 ` Gyungoh Yoo 2014-10-07 5:04 ` [RESUBMIT PATCH v3 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo 2014-10-07 5:04 ` [RESUBMIT PATCH v3 4/8] devicetree: backlight: add new SKY81452 backlight binding Gyungoh Yoo 2014-10-07 5:04 ` Gyungoh Yoo 2014-10-07 5:06 ` [RESUBMIT PATCH v3 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo 2014-10-07 5:06 ` Gyungoh Yoo 2014-10-07 5:09 ` [RESUBMIT PATCH v3 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo 2014-10-07 5:09 ` Gyungoh Yoo 2014-10-07 5:11 ` [RESUBMIT PATCH v3 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo 2014-10-07 5:11 ` Gyungoh Yoo 2014-10-07 12:52 ` Mark Brown 2014-10-07 12:52 ` Mark Brown 2014-10-08 8:51 ` Gyungoh Yoo 2014-10-08 8:51 ` Gyungoh Yoo 2014-10-07 5:13 ` [RESUBMIT PATCH v3 8/8] devicetree: " Gyungoh Yoo 2014-10-07 5:13 ` Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 0/8] Add Skyworks SKY81452 device drivers Gyungoh Yoo 2014-10-13 5:47 ` Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 1/8] mfd: Add support for Skyworks SKY81452 driver Gyungoh Yoo 2014-10-21 12:30 ` Lee Jones 2014-10-21 12:30 ` Lee Jones 2014-10-23 3:16 ` Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 2/8] backlight: Add support Skyworks SKY81452 backlight driver Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 3/8] devicetree: mfd: Add new SKY81452 mfd binding Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 4/8] devicetree: backlight: Add new SKY81452 backlight binding Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding Gyungoh Yoo 2014-10-13 10:35 ` Mark Brown 2014-10-14 1:11 ` Gyungoh Yoo 2014-10-14 1:11 ` Gyungoh Yoo 2014-10-14 7:56 ` Mark Brown 2014-10-17 9:19 ` Gyungoh Yoo 2014-10-17 10:17 ` Mark Brown 2014-10-17 10:43 ` Gyungoh Yoo 2014-10-17 14:26 ` Mark Brown 2014-10-20 6:10 ` Gyungoh Yoo 2014-10-22 10:27 ` Mark Brown 2014-10-23 3:14 ` Gyungoh Yoo 2014-10-23 13:01 ` Mark Brown 2014-10-24 7:54 ` Gyungoh Yoo 2014-10-13 5:47 ` [RESUBMIT PATCH v4 8/8] devicetree: " Gyungoh Yoo 2014-10-27 7:02 ` [RESUBMIT PATCH v5 0/8] Add Skyworks SKY81452 device drivers gyungoh 2014-10-27 7:02 ` [RESUBMIT PATCH v5 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh 2014-10-27 7:02 ` [RESUBMIT PATCH v5 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh 2014-10-27 7:05 ` Varka Bhadram 2014-10-27 7:19 ` Gyungoh Yoo 2014-10-27 7:02 ` [RESUBMIT PATCH v5 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh 2014-10-27 7:02 ` [RESUBMIT PATCH v5 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh 2014-10-27 7:02 ` gyungoh-Re5JQEeQqe8AvxtiuMwx3w 2014-10-27 7:02 ` [RESUBMIT PATCH v5 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh 2014-10-27 7:02 ` [RESUBMIT PATCH v5 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh 2014-10-27 7:02 ` [RESUBMIT PATCH v5 7/8] regulator: sky81452: Add compatible string for device binding gyungoh 2014-10-27 7:02 ` [RESUBMIT PATCH v5 8/8] devicetree: " gyungoh 2014-10-31 7:08 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers gyungoh 2014-10-31 7:08 ` [RESUBMIT PATCH v6 1/8] mfd: Add support for Skyworks SKY81452 driver gyungoh 2014-11-03 17:14 ` Lee Jones 2014-11-03 17:14 ` Lee Jones 2014-11-03 21:28 ` Paul Bolle 2014-11-03 21:28 ` Paul Bolle 2014-11-03 22:30 ` Lee Jones 2014-11-03 22:30 ` Lee Jones 2014-11-04 9:05 ` Paul Bolle 2014-11-04 9:05 ` Paul Bolle 2014-11-04 9:16 ` Lee Jones 2014-11-04 9:16 ` Lee Jones 2014-11-04 11:38 ` Mark Brown 2014-11-04 11:38 ` Mark Brown 2014-11-04 14:35 ` Lee Jones 2014-11-04 14:35 ` Lee Jones 2014-11-04 10:54 ` Lee Jones 2014-11-04 9:17 ` Lee Jones 2014-11-04 9:17 ` Lee Jones 2014-10-31 7:08 ` [RESUBMIT PATCH v6 2/8] backlight: Add support Skyworks SKY81452 backlight driver gyungoh 2014-10-31 7:08 ` [RESUBMIT PATCH v6 3/8] devicetree: mfd: Add new SKY81452 mfd binding gyungoh 2014-10-31 16:36 ` Mark Brown 2014-11-03 17:06 ` Lee Jones 2014-11-03 17:06 ` Lee Jones 2014-10-31 7:08 ` [RESUBMIT PATCH v6 4/8] devicetree: backlight: Add new SKY81452 backlight binding gyungoh 2014-10-31 7:08 ` gyungoh-Re5JQEeQqe8AvxtiuMwx3w 2014-10-31 7:08 ` [RESUBMIT PATCH v6 5/8] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh 2014-11-03 17:07 ` Lee Jones 2014-11-03 17:07 ` Lee Jones 2014-10-31 7:08 ` [RESUBMIT PATCH v6 6/8] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh 2014-10-31 7:08 ` gyungoh-Re5JQEeQqe8AvxtiuMwx3w 2014-10-31 7:08 ` [RESUBMIT PATCH v6 7/8] regulator: sky81452: Add compatible string for device binding gyungoh 2014-10-31 16:44 ` Mark Brown 2014-11-03 21:45 ` Paul Bolle 2014-11-03 21:45 ` Paul Bolle 2014-11-04 0:55 ` Mark Brown 2014-11-06 4:45 ` Gyungoh Yoo [this message] 2014-11-06 4:45 ` Gyungoh Yoo 2014-11-04 0:43 ` Gyungoh Yoo 2014-11-04 0:43 ` Gyungoh Yoo 2014-11-04 0:53 ` Mark Brown 2014-11-04 0:53 ` Mark Brown 2014-11-04 5:45 ` Gyungoh Yoo 2014-11-04 5:45 ` Gyungoh Yoo 2014-11-04 11:41 ` Mark Brown 2014-11-04 11:41 ` Mark Brown 2014-11-06 4:38 ` Gyungoh Yoo 2014-11-06 4:38 ` Gyungoh Yoo 2014-10-31 7:08 ` [RESUBMIT PATCH v6 8/8] devicetree: " gyungoh 2014-11-11 11:10 ` [RESUBMIT PATCH v6 0/8] Add Skyworks SKY81452 device drivers Lee Jones 2014-11-13 13:20 ` Gyungoh Yoo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141106044534.GB5068@jack-ThinkPad-T520 \ --to=gyungoh@gmail.com \ --cc=andrew@lunn.ch \ --cc=broonie@kernel.org \ --cc=cooloney@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=florian.vaussard@epfl.ch \ --cc=galak@codeaurora.org \ --cc=grant.likely@linaro.org \ --cc=heiko@sntech.de \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jack.yoo@skyworksinc.com \ --cc=jason@lakedaemon.net \ --cc=jg1.han@samsung.com \ --cc=jic23@kernel.org \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=pebolle@tiscali.nl \ --cc=robh+dt@kernel.org \ --cc=sameo@linux.intel.com \ --cc=shawn.guo@freescale.com \ --cc=treding@nvidia.com \ --cc=trivial@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.