All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, hch@infradead.org, linux-scsi@vger.kernel.org,
	axboe@kernel.dk, sparclinux@vger.kernel.org
Subject: Re: blk_mq: suspicious RCU usage, rcu_read_lock() used illegally while idle!
Date: Fri, 7 Nov 2014 15:42:27 -0800	[thread overview]
Message-ID: <20141107234227.GD4901@linux.vnet.ibm.com> (raw)
In-Reply-To: <20141107.124558.1965251829673123349.davem@davemloft.net>

On Fri, Nov 07, 2014 at 12:45:58PM -0500, David Miller wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Date: Fri, 7 Nov 2014 07:06:28 -0800
> 
> > On Fri, Nov 07, 2014 at 12:50:02PM +0200, Meelis Roos wrote:
> >> Perhaps DaveM can tell which one is coreect or if there is any related 
> >> problem.
> > 
> > Happy to push either of them along, if appropriate.
> 
> We should use irq_enter()/irq_exit(), and we need to also add it to
> smp_call_function_single_client().
> 
> I'll code up a final patch for sparc64 and push it upstream, thanks!

Even better!  ;-)

> Some other architectures appear to have the same problem, for example
> alpha and IA64.  Someone should grep around generic_smp_call_function*
> under arch/ and do an audit.

I will send something along in a couple days if someone else doesn't
beat me to it.  ;-)

							Thanx, Paul


WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: mroos@linux.ee, hch@infradead.org, linux-scsi@vger.kernel.org,
	axboe@kernel.dk, sparclinux@vger.kernel.org
Subject: Re: blk_mq: suspicious RCU usage, rcu_read_lock() used illegally while idle!
Date: Fri, 07 Nov 2014 23:42:27 +0000	[thread overview]
Message-ID: <20141107234227.GD4901@linux.vnet.ibm.com> (raw)
In-Reply-To: <20141107.124558.1965251829673123349.davem@davemloft.net>

On Fri, Nov 07, 2014 at 12:45:58PM -0500, David Miller wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Date: Fri, 7 Nov 2014 07:06:28 -0800
> 
> > On Fri, Nov 07, 2014 at 12:50:02PM +0200, Meelis Roos wrote:
> >> Perhaps DaveM can tell which one is coreect or if there is any related 
> >> problem.
> > 
> > Happy to push either of them along, if appropriate.
> 
> We should use irq_enter()/irq_exit(), and we need to also add it to
> smp_call_function_single_client().
> 
> I'll code up a final patch for sparc64 and push it upstream, thanks!

Even better!  ;-)

> Some other architectures appear to have the same problem, for example
> alpha and IA64.  Someone should grep around generic_smp_call_function*
> under arch/ and do an audit.

I will send something along in a couple days if someone else doesn't
beat me to it.  ;-)

							Thanx, Paul


  reply	other threads:[~2014-11-07 23:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 15:45 blk_mq: suspicious RCU usage, rcu_read_lock() used illegally while idle! Meelis Roos
2014-11-06 15:46 ` Christoph Hellwig
2014-11-06 17:11   ` Paul E. McKenney
2014-11-07 10:50     ` Meelis Roos
2014-11-07 10:50       ` Meelis Roos
2014-11-07 15:06       ` Paul E. McKenney
2014-11-07 15:06         ` Paul E. McKenney
2014-11-07 17:45         ` David Miller
2014-11-07 17:45           ` David Miller
2014-11-07 23:42           ` Paul E. McKenney [this message]
2014-11-07 23:42             ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141107234227.GD4901@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.