From: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Mikko Perttunen <mikko.perttunen-/1wQRMveznE@public.gmane.org>, Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Ezequiel Garcia <ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>, Linux PM list <linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Vincenzo Frascino <vincenzo.frascino-qxv4g6HH51o@public.gmane.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Lukasz Majewski <l.majewski-AM3owJQeAb5mR6Xm/wNWPw@public.gmane.org>, Nobuhiro Iwamatsu <iwamatsu-+mkmVskJBflAfugRpC6u6w@public.gmane.org>, Mikko Perttunen <mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>, Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver Date: Mon, 17 Nov 2014 14:02:45 +0100 [thread overview] Message-ID: <20141117140245.51837653@amdc2363> (raw) In-Reply-To: <20141117120105.GH25699@ulmo> Hi Thierry, > On Mon, Nov 17, 2014 at 12:50:13PM +0100, Lukasz Majewski wrote: > > Hi Thierry, > > > > > On Fri, Nov 14, 2014 at 12:47:33PM +0200, Mikko Perttunen wrote: > > > > Tested-by: Mikko Perttunen <mikko.perttunen-/1wQRMveznE@public.gmane.org> > > > > > > > > One potential issue I can see is that if the cpufreq driver > > > > fails to probe then you'll never get the thermal driver either. > > > > For example, Tegra124 currently has no cpufreq driver, so if > > > > CONFIG_CPU_THERMAL was enabled, then the soctherm driver would > > > > never be able to probe. But I don't really have a solution for > > > > this either. > > > > > > It doesn't seem like there's any code whatsoever to deal with > > > cpufreq within the soctherm driver, so deferring probe based on > > > something we're not using anyway seems rather useless. > > > > So, If I understood you correctly - this patch is not needed in the > > /tegra_soctherm.c:[tegra_defconfig] driver and can be safely > > omitted in v2 of this driver. > > What I'm saying is that I don't think doing this mass conversion > wholesale is useful since none of the drivers register a cooling > device based on cpufreq. In other words: if you're not going to use a > feature there's no use testing for it. > It seems, like one option here would be to add deferred proble to cpufreq_cooling_register() or check which driver in its thermal probe is calling cpufreq_cooling_register() function. The latter option explains why in the imx_thermal.c file we check for deferred probe without #ifdefs for CONFIG_CPU_THERMAL. If no objections, I would like to stick to the code already available in imx_thermal.c. > Thierry -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Majewski <l.majewski@samsung.com> To: Thierry Reding <thierry.reding@gmail.com> Cc: Mikko Perttunen <mikko.perttunen@kapsi.fi>, Eduardo Valentin <edubezval@gmail.com>, Zhang Rui <rui.zhang@intel.com>, Ezequiel Garcia <ezequiel.garcia@free-electrons.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Linux PM list <linux-pm@vger.kernel.org>, Vincenzo Frascino <vincenzo.frascino@st.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Lukasz Majewski <l.majewski@majess.pl>, Nobuhiro Iwamatsu <iwamatsu@nigauri.org>, Mikko Perttunen <mperttunen@nvidia.com>, Stephen Warren <swarren@wwwdotorg.org>, Alexandre Courbot <gnurou@gmail.com>, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver Date: Mon, 17 Nov 2014 14:02:45 +0100 [thread overview] Message-ID: <20141117140245.51837653@amdc2363> (raw) In-Reply-To: <20141117120105.GH25699@ulmo> Hi Thierry, > On Mon, Nov 17, 2014 at 12:50:13PM +0100, Lukasz Majewski wrote: > > Hi Thierry, > > > > > On Fri, Nov 14, 2014 at 12:47:33PM +0200, Mikko Perttunen wrote: > > > > Tested-by: Mikko Perttunen <mikko.perttunen@kapsi.fi> > > > > > > > > One potential issue I can see is that if the cpufreq driver > > > > fails to probe then you'll never get the thermal driver either. > > > > For example, Tegra124 currently has no cpufreq driver, so if > > > > CONFIG_CPU_THERMAL was enabled, then the soctherm driver would > > > > never be able to probe. But I don't really have a solution for > > > > this either. > > > > > > It doesn't seem like there's any code whatsoever to deal with > > > cpufreq within the soctherm driver, so deferring probe based on > > > something we're not using anyway seems rather useless. > > > > So, If I understood you correctly - this patch is not needed in the > > /tegra_soctherm.c:[tegra_defconfig] driver and can be safely > > omitted in v2 of this driver. > > What I'm saying is that I don't think doing this mass conversion > wholesale is useful since none of the drivers register a cooling > device based on cpufreq. In other words: if you're not going to use a > feature there's no use testing for it. > It seems, like one option here would be to add deferred proble to cpufreq_cooling_register() or check which driver in its thermal probe is calling cpufreq_cooling_register() function. The latter option explains why in the imx_thermal.c file we check for deferred probe without #ifdefs for CONFIG_CPU_THERMAL. If no objections, I would like to stick to the code already available in imx_thermal.c. > Thierry -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2014-11-17 13:02 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-24 8:27 [PATCH 0/3] thermal: fix: Various fixes for thermal subsystem Lukasz Majewski 2014-09-24 8:27 ` [PATCH 1/3] thermal: step_wise: fix: Prevent from binary overflow when trend is dropping Lukasz Majewski 2014-10-02 21:13 ` Eduardo Valentin 2014-10-03 7:26 ` Lukasz Majewski 2014-10-09 3:14 ` Zhang Rui 2014-09-24 8:27 ` [PATCH 2/3] thermal: core: fix: Initialize the max_state variable to 0 Lukasz Majewski 2014-10-02 22:26 ` Eduardo Valentin 2014-10-03 8:26 ` Lukasz Majewski 2014-10-06 18:01 ` Eduardo Valentin 2014-09-24 8:27 ` [PATCH 3/3] thermal: core: fix: Check return code of the ->get_max_state() callback Lukasz Majewski 2014-10-02 22:24 ` Eduardo Valentin 2014-10-03 10:40 ` Lukasz Majewski 2014-10-09 3:15 ` Zhang Rui 2014-10-09 16:47 ` Lukasz Majewski 2014-10-02 14:40 ` [PATCH 0/3] thermal: fix: Various fixes for thermal subsystem Lukasz Majewski [not found] ` <1411547232-21493-1-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-11-13 17:02 ` [PATCH 0/8] thermal:cpu cooling:fix: Provide thermal core fixes with deferred probe for several drivers Lukasz Majewski 2014-11-13 17:02 ` Lukasz Majewski 2014-11-13 17:02 ` [PATCH 1/8] thermal:cpu cooling:armada: Provide deferred probing for armada driver Lukasz Majewski 2014-11-13 17:02 ` [PATCH 2/8] thermal:cpu cooling:kirkwood: Provide deferred probing for kirkwood driver Lukasz Majewski 2014-11-13 17:02 ` [PATCH 3/8] thermal:cpu cooling:rcar: Provide deferred probing for rcar driver Lukasz Majewski 2014-11-13 17:02 ` [PATCH 4/8] thermal:cpu cooling:spear: Provide deferred probing for spear driver Lukasz Majewski 2014-11-13 17:02 ` [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver Lukasz Majewski 2014-11-14 10:47 ` Mikko Perttunen 2014-11-14 11:24 ` Lukasz Majewski 2014-11-17 11:57 ` Thierry Reding 2014-11-17 12:51 ` Lukasz Majewski 2014-11-17 13:18 ` Thierry Reding [not found] ` <5465DDC5.6090301-/1wQRMveznE@public.gmane.org> 2014-11-17 11:43 ` Thierry Reding 2014-11-17 11:43 ` Thierry Reding 2014-11-17 11:50 ` Lukasz Majewski 2014-11-17 12:01 ` Thierry Reding 2014-11-17 12:01 ` Thierry Reding 2014-11-17 13:02 ` Lukasz Majewski [this message] 2014-11-17 13:02 ` Lukasz Majewski 2014-11-17 12:51 ` Mikko Perttunen 2014-11-17 12:51 ` Mikko Perttunen 2014-11-17 13:08 ` Thierry Reding 2014-11-17 13:24 ` Mikko Perttunen [not found] ` <1415898165-27406-6-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-11-17 11:40 ` Thierry Reding 2014-11-17 11:40 ` Thierry Reding 2014-11-13 17:02 ` [PATCH 6/8] thermal:cpu cooling:ti: Provide deferred probing for ti drivers Lukasz Majewski 2014-11-20 19:00 ` Eduardo Valentin 2014-11-13 17:02 ` [PATCH 7/8] thermal:core:fix: Initialize the max_state variable to 0 Lukasz Majewski 2014-11-18 10:16 ` [PATCH v2] thermal:core:fix: Check return code of the ->get_max_state() callback Lukasz Majewski [not found] ` <1416305790-27746-1-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-11-21 18:08 ` Eduardo Valentin 2014-11-21 18:08 ` Eduardo Valentin 2014-11-24 10:38 ` Lukasz Majewski 2014-11-24 11:00 ` Viresh Kumar 2014-11-24 11:00 ` Viresh Kumar 2014-11-24 14:24 ` Lukasz Majewski 2014-11-25 10:46 ` Viresh Kumar 2014-11-24 18:02 ` Eduardo Valentin 2014-11-24 18:02 ` Eduardo Valentin 2014-11-24 20:28 ` Lukasz Majewski [not found] ` <1415898165-27406-1-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-11-13 17:02 ` [PATCH 8/8] " Lukasz Majewski 2014-11-13 17:02 ` Lukasz Majewski 2014-11-20 18:54 ` [PATCH 0/8] thermal:cpu cooling:fix: Provide thermal core fixes with deferred probe for several drivers Eduardo Valentin 2014-11-20 18:54 ` Eduardo Valentin 2014-11-21 8:33 ` Lukasz Majewski 2014-11-21 2:47 ` Eduardo Valentin 2014-11-21 16:28 ` Lukasz Majewski 2014-11-21 16:28 ` Lukasz Majewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141117140245.51837653@amdc2363 \ --to=l.majewski-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \ --cc=b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \ --cc=edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \ --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=iwamatsu-+mkmVskJBflAfugRpC6u6w@public.gmane.org \ --cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \ --cc=l.majewski-AM3owJQeAb5mR6Xm/wNWPw@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mikko.perttunen-/1wQRMveznE@public.gmane.org \ --cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \ --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=vincenzo.frascino-qxv4g6HH51o@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.