[meta-oe][PATCH] tiptop: Add new recipe

[meta-oe][PATCH] tiptop: Add new recipe

[Qian Lei]

Tiptop is a performance monitoring tool for Linux. It provides a
dynamic real-time view of the tasks running in the system. Tiptop
is very similar to the top utility, but most of the information
displayed comes from hardware counters.

Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
---
 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb

diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
new file mode 100644
index 0000000..7f29ef3
--- /dev/null
+++ b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
@@ -0,0 +1,13 @@
+SUMMARY = "Hardware performance monitoring counters" 
+HOMEPAGE = "http://tiptop.gforge.inria.fr/" 
+LICENSE = "GPLv2" 
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" 
+DEPENDS = "ncurses libxml2" 
+
+SRC_URI = "http://tiptop.gforge.inria.fr/releases/tiptop-${PV}.tar.gz" 
+SRC_URI[md5sum] = "74255a29acf44569db021b080ad3e3f7" 
+SRC_URI[sha256sum] = "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d" 
+
+CFLAGS += "-I${STAGING_INCDIR}/libxml2"
+
+inherit autotools-brokensep
-- 
1.8.3.1

Re: [meta-oe][PATCH] tiptop: Add new recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

On Wed, Nov 19, 2014 at 11:44:05AM +0800, Qian Lei wrote:
> Tiptop is a performance monitoring tool for Linux. It provides a
> dynamic real-time view of the tasks running in the system. Tiptop
> is very similar to the top utility, but most of the information
> displayed comes from hardware counters.
> 
> Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
> ---
>  meta-oe/recipes-extended/tiptop/tiptop_2.2.bb | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> 
> diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> new file mode 100644
> index 0000000..7f29ef3
> --- /dev/null
> +++ b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> @@ -0,0 +1,13 @@
> +SUMMARY = "Hardware performance monitoring counters" 
> +HOMEPAGE = "http://tiptop.gforge.inria.fr/" 
> +LICENSE = "GPLv2" 
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" 
> +DEPENDS = "ncurses libxml2" 
> +
> +SRC_URI = "http://tiptop.gforge.inria.fr/releases/tiptop-${PV}.tar.gz" 

tiptop-${PV} -> ${BP}

all lines have trailing spaces

I've fixed both when cherry-picking to master-next

> +SRC_URI[md5sum] = "74255a29acf44569db021b080ad3e3f7" 
> +SRC_URI[sha256sum] = "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d" 
> +
> +CFLAGS += "-I${STAGING_INCDIR}/libxml2"
> +
> +inherit autotools-brokensep
> -- 
> 1.8.3.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

[PATCH v2] tiptop: Add new recipe

[Qian Lei]

Tiptop is a performance monitoring tool for Linux. It provides a
dynamic real-time view of the tasks running in the system. Tiptop
is very similar to the top utility, but most of the information
displayed comes from hardware counters.

Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
---
 .../files/tiptop-remove-path-of-libxml2.patch      | 28 ++++++++++++++++++++++
 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb      | 15 ++++++++++++
 2 files changed, 43 insertions(+)
 create mode 100644 meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
 create mode 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb

diff --git a/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch b/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
new file mode 100644
index 0000000..7499828
--- /dev/null
+++ b/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
@@ -0,0 +1,28 @@
+From 2f9cb586d6675371f9db8d4b62a4b339625d73a6 Mon Sep 17 00:00:00 2001
+From: Qian Lei <qianl.fnst@cn.fujitsu.com>
+Date: Thu, 20 Nov 2014 16:34:47 +0800
+Subject: [PATCH] tiptop: Remove the include path
+
+Remove the path and specify it in .bb file
+
+Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index 6a71782..7408f82 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -31,7 +31,7 @@ AC_CHECK_LIB([xml2], [xmlParseFile],
+                   [have_xml2=yes;
+                   AC_DEFINE([HAVE_LIBXML2], [1], [Define to 1 if you have the `libxml2' library (-lxml2).])
+                   LIBS="-lxml2 $LIBS"
+-                  CFLAGS="$CFLAGS -I/usr/include/libxml2"],
++                  CFLAGS="$CFLAGS"],
+              [have_xml2=no])
+ fi
+ 
+-- 
+1.8.3.1
+
diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
new file mode 100644
index 0000000..d8a0de4
--- /dev/null
+++ b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
@@ -0,0 +1,15 @@
+SUMMARY = "Hardware performance monitoring counters"
+HOMEPAGE = "http://tiptop.gforge.inria.fr/"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+DEPENDS = "ncurses libxml2"
+
+SRC_URI = "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz;name=tarball \
+           file://tiptop-remove-path-of-libxml2.patch \
+"
+SRC_URI[tarball.md5sum] = "74255a29acf44569db021b080ad3e3f7"
+SRC_URI[tarball.sha256sum] = "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d"
+
+EXTRA_OECONF = "CFLAGS="$CFLAGS -I${STAGING_INCDIR}/libxml2""
+
+inherit autotools-brokensep
-- 
1.8.3.1

Re: [meta-oe][PATCH] tiptop: Add new recipe

[Qian Lei]

Jansa:

Sorry there's a bug in my patch. Tiptop can not be compiled in the host with
libxml2 installed, because it will use libxml2 in the HOST first,rather than
the libxml2 we specified. 

Modified it in version 2, please apply this one.
Thanks.

-- 
Qian Lei

Re: [PATCH v2] tiptop: Add new recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 4290 bytes --]

On Thu, Nov 20, 2014 at 04:59:01PM +0800, Qian Lei wrote:
> Tiptop is a performance monitoring tool for Linux. It provides a
> dynamic real-time view of the tasks running in the system. Tiptop
> is very similar to the top utility, but most of the information
> displayed comes from hardware counters.
> 
> Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
> ---
>  .../files/tiptop-remove-path-of-libxml2.patch      | 28 ++++++++++++++++++++++
>  meta-oe/recipes-extended/tiptop/tiptop_2.2.bb      | 15 ++++++++++++
>  2 files changed, 43 insertions(+)
>  create mode 100644 meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
>  create mode 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> 
> diff --git a/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch b/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
> new file mode 100644
> index 0000000..7499828
> --- /dev/null
> +++ b/meta-oe/recipes-extended/tiptop/files/tiptop-remove-path-of-libxml2.patch
> @@ -0,0 +1,28 @@
> +From 2f9cb586d6675371f9db8d4b62a4b339625d73a6 Mon Sep 17 00:00:00 2001
> +From: Qian Lei <qianl.fnst@cn.fujitsu.com>
> +Date: Thu, 20 Nov 2014 16:34:47 +0800
> +Subject: [PATCH] tiptop: Remove the include path
> +
> +Remove the path and specify it in .bb file
> +
> +Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
> +---
> + configure.ac | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 6a71782..7408f82 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -31,7 +31,7 @@ AC_CHECK_LIB([xml2], [xmlParseFile],
> +                   [have_xml2=yes;
> +                   AC_DEFINE([HAVE_LIBXML2], [1], [Define to 1 if you have the `libxml2' library (-lxml2).])
> +                   LIBS="-lxml2 $LIBS"
> +-                  CFLAGS="$CFLAGS -I/usr/include/libxml2"],
> ++                  CFLAGS="$CFLAGS"],
> +              [have_xml2=no])
> + fi
> + 
> +-- 
> +1.8.3.1
> +
> diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> new file mode 100644
> index 0000000..d8a0de4
> --- /dev/null
> +++ b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> @@ -0,0 +1,15 @@
> +SUMMARY = "Hardware performance monitoring counters"
> +HOMEPAGE = "http://tiptop.gforge.inria.fr/"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +DEPENDS = "ncurses libxml2"
> +
> +SRC_URI = "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz;name=tarball \
> +           file://tiptop-remove-path-of-libxml2.patch \
> +"
> +SRC_URI[tarball.md5sum] = "74255a29acf44569db021b080ad3e3f7"
> +SRC_URI[tarball.sha256sum] = "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d"

Drop name=tarball and tarball. prefix.

Fails to build for qemuarm:

| In file included from target.c:17:0:
| target-x86.c: In function 'disp_family_model':
| target-x86.c:54:3: error: unknown register name '%edx' in 'asm'
|    asm("mov $1, %%eax; " /* a into eax */
|    ^
| target-x86.c:54:3: error: unknown register name '%ecx' in 'asm'
| target-x86.c:54:3: error: unknown register name '%ebx' in 'asm'
| target-x86.c:54:3: error: unknown register name '%eax' in 'asm'
| make[1]: *** [target.o] Error 1
| make[1]: *** Waiting for unfinished jobs....
| make[1]: Leaving directory `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/tiptop/2.2-r0/tiptop-2.2/src'
| make: *** [all] Error 2
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_compile (log file is located at /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/tiptop/2.2-r0/temp/log.do_compile.7484)
NOTE: recipe tiptop-2.2-r0: task do_compile: Failed


> +
> +EXTRA_OECONF = "CFLAGS="$CFLAGS -I${STAGING_INCDIR}/libxml2""
> +
> +inherit autotools-brokensep
> -- 
> 1.8.3.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

[meta-oe][PATCH v3] tiptop: Add new recipe

[Qian Lei]

Tiptop is a performance monitoring tool for Linux. It provides a
dynamic real-time view of the tasks running in the system. Tiptop
is very similar to the top utility, but most of the information
displayed comes from hardware counters.

Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com>
---
 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb

diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
new file mode 100644
index 0000000..126976c
--- /dev/null
+++ b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
@@ -0,0 +1,26 @@
+SUMMARY = "Hardware performance monitoring counters"
+HOMEPAGE = "http://tiptop.gforge.inria.fr/"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+DEPENDS = "ncurses libxml2"
+
+SRC_URI = "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz"
+SRC_URI[md5sum] = "74255a29acf44569db021b080ad3e3f7"
+SRC_URI[sha256sum] = "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d"
+
+inherit autotools-brokensep
+EXTRA_OECONF = "CFLAGS="$CFLAGS -I${STAGING_INCDIR}/libxml2""
+COMPATIBLE_HOST = "(i.86|x86_64|arm|powerpc).*-linux"
+
+do_configure_prepend () {
+    # Two bugs in configure.ac when cross-compiling.
+    # 1. The path of libxml2. Specify it in EXTRA_OECONF.
+    # 2. hw's value on other platforms. Replace it if the target is 
+    #    not i*86/x86_64.
+    if ( echo "${TARGET_ARCH}" | grep -q -e 'i.86' -e 'x86_64' ); then
+        sed -i 's= -I/usr/include/libxml2=='    ${S}/configure.ac
+    else
+        sed -i 's/hw=`uname -m`/hw="unknown"/'  ${S}/configure.ac
+        sed -i 's= -I/usr/include/libxml2=='    ${S}/configure.ac
+    fi
+}
-- 
1.8.3.1

Re: [PATCH v2] tiptop: Add new recipe

[Qian Lei]

On Fri, 21 Nov 2014 15:05:44 +0100
Martin Jansa <martin.jansa@gmail.com> wrote:

> > +SRC_URI[tarball.md5sum] = "74255a29acf44569db021b080ad3e3f7"
> > +SRC_URI[tarball.sha256sum] =
> > "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d"
> 
> Drop name=tarball and tarball. prefix.

Modified in v3.

> Fails to build for qemuarm:
> 
> | In file included from target.c:17:0:
> | target-x86.c: In function 'disp_family_model':
> | target-x86.c:54:3: error: unknown register name '%edx' in 'asm'
> |    asm("mov $1, %%eax; " /* a into eax */
> |    ^
> | target-x86.c:54:3: error: unknown register name '%ecx' in 'asm'
> | target-x86.c:54:3: error: unknown register name '%ebx' in 'asm'
> | target-x86.c:54:3: error: unknown register name '%eax' in 'asm'
> | make[1]: *** [target.o] Error 1
> | make[1]: *** Waiting for unfinished jobs....
> | make[1]: Leaving directory
> `/home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/tiptop/2.2-r0/tiptop-2.2/src'
> | make: *** [all] Error 2 | ERROR: oe_runmake failed
> | WARNING: exit code 1 from a shell command.
> | ERROR: Function failed: do_compile (log file is located
> at /home/jenkins/oe/world/shr-core/tmp-glibc/work/armv5te-oe-linux-gnueabi/tiptop/2.2-r0/temp/log.do_compile.7484)
> NOTE: recipe tiptop-2.2-r0: task do_compile: Failed

Fixed this issue in v3. Now it can be built successfully in my
environment(qemuarm & qemuppc). I also removed the
tiptop-remove-path-of-libxml2.patch in v2 because now it is implemented
in do_configure_prepend.

-- 
Qian Lei

Re: [meta-oe][PATCH v3] tiptop: Add new recipe

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Qian Lei schreef op 27-11-14 10:19:
> Tiptop is a performance monitoring tool for Linux. It provides a dynamic
> real-time view of the tasks running in the system. Tiptop is very similar
> to the top utility, but most of the information displayed comes from
> hardware counters.
> 
> Signed-off-by: Qian Lei <qianl.fnst@cn.fujitsu.com> --- 
> meta-oe/recipes-extended/tiptop/tiptop_2.2.bb | 26
> ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode
> 100644 meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> 
> diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb new file mode 100644 
> index 0000000..126976c --- /dev/null +++
> b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb @@ -0,0 +1,26 @@ +SUMMARY
> = "Hardware performance monitoring counters" +HOMEPAGE =
> "http://tiptop.gforge.inria.fr/" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM =
> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" +DEPENDS = "ncurses
> libxml2" + +SRC_URI =
> "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz" +SRC_URI[md5sum] =
> "74255a29acf44569db021b080ad3e3f7" +SRC_URI[sha256sum] =
> "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d" + 
> +inherit autotools-brokensep +EXTRA_OECONF = "CFLAGS="$CFLAGS
> -I${STAGING_INCDIR}/libxml2"" +COMPATIBLE_HOST =
> "(i.86|x86_64|arm|powerpc).*-linux"

What's broken on mips, armv8 and avr32?

> + +do_configure_prepend () { +    # Two bugs in configure.ac when
> cross-compiling. +    # 1. The path of libxml2. Specify it in
> EXTRA_OECONF. +    # 2. hw's value on other platforms. Replace it if the
> target is +    #    not i*86/x86_64. +    if ( echo "${TARGET_ARCH}" |
> grep -q -e 'i.86' -e 'x86_64' ); then +        sed -i 's=
> -I/usr/include/libxml2=='    ${S}/configure.ac +    else +        sed -i
> 's/hw=`uname -m`/hw="unknown"/'  ${S}/configure.ac +        sed -i 's=
> -I/usr/include/libxml2=='    ${S}/configure.ac +    fi +}

Drop the conditional, it should *never* use uname.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFUdvGrMkyGM64RGpERAia5AJwKkcp5N1xKAWHA1kCbReH+iwZsWwCfaWvi
5gv7MvkZZz3lICXG/L4O3Xo=
=oxk6
-----END PGP SIGNATURE-----

Re: [meta-oe][PATCH v3] tiptop: Add new recipe

[Qian Lei]

On Thu, 27 Nov 2014 10:40:59 +0100
Koen Kooi <koen@dominion.thruhere.net> wrote:

> > diff --git a/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb
> > b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb new file mode 100644 
> > index 0000000..126976c --- /dev/null +++
> > b/meta-oe/recipes-extended/tiptop/tiptop_2.2.bb @@ -0,0 +1,26 @@ +SUMMARY
> > = "Hardware performance monitoring counters" +HOMEPAGE =
> > "http://tiptop.gforge.inria.fr/" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM =
> > "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263" +DEPENDS = "ncurses
> > libxml2" + +SRC_URI =
> > "http://tiptop.gforge.inria.fr/releases/${BP}.tar.gz" +SRC_URI[md5sum] =
> > "74255a29acf44569db021b080ad3e3f7" +SRC_URI[sha256sum] =
> > "965cb99b16cb59df78363d83b62877ce8501b0aac1116a86bed8a16aa96b171d" + 
> > +inherit autotools-brokensep +EXTRA_OECONF = "CFLAGS="$CFLAGS
> > -I${STAGING_INCDIR}/libxml2"" +COMPATIBLE_HOST =
> > "(i.86|x86_64|arm|powerpc).*-linux"
> 
> What's broken on mips, armv8 and avr32?

It seems that tiptop is not supported on some architectures. The patch on
bugzilla[1] has only fixed part of this issue(mips not included). I failed to
build it on qemu-mips and have to use COMPATIBLE_HOST to limit the target
architectures. I have only built it on qemux-(x86|x86-64|arm|ppc|mips) and know
few about armv8, arv32. Any documents for them? How can I simulate them in qemu?

By the way, there are also some patches[2-3] on debian. Should I include them
in the next patch?

[1]https://bugzilla.redhat.com/show_bug.cgi?id=1122009
[2]http://anonscm.debian.org/cgit/collab-maint/tiptop.git/tree/debian/patches/0001-Fix-minor-problems-with-the-manpage.patch
[3]http://anonscm.debian.org/cgit/collab-maint/tiptop.git/tree/debian/patches/0002-Fix-linking-phase.patch

> 
> > + +do_configure_prepend () { +    # Two bugs in configure.ac when
> > cross-compiling. +    # 1. The path of libxml2. Specify it in
> > EXTRA_OECONF. +    # 2. hw's value on other platforms. Replace it if the
> > target is +    #    not i*86/x86_64. +    if ( echo "${TARGET_ARCH}" |
> > grep -q -e 'i.86' -e 'x86_64' ); then +        sed -i 's=
> > -I/usr/include/libxml2=='    ${S}/configure.ac +    else +        sed -i
> > 's/hw=`uname -m`/hw="unknown"/'  ${S}/configure.ac +        sed -i 's=
> > -I/usr/include/libxml2=='    ${S}/configure.ac +    fi +}
> 
> Drop the conditional, it should *never* use uname.

Ok, it will be modified in next patch, which will be submitted a few days later.

-- 
Qian Lei