From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
devicetree@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ARM: dts: dove: add DT LCD controllers
Date: Wed, 19 Nov 2014 16:47:13 +0000 [thread overview]
Message-ID: <20141119164713.GJ4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20141119174050.122a0cc0@armhf>
On Wed, Nov 19, 2014 at 05:40:50PM +0100, Jean-Francois Moine wrote:
> On Wed, 19 Nov 2014 11:32:29 +0000
> Russell King <rmk+kernel@arm.linux.org.uk> wrote:
>
> > + lcd1: lcd-controller@810000 {
> > + compatible = "marvell,dove-lcd";
> > + reg = <0x810000 0x1000>;
> > + interrupts = <46>;
> > + status = "disabled";
> > + };
>
> The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?
Actually, a more correct value would be 0x10000, if you read table 145.
Yes, the device may onlny have documented registers from 0x84 to 0x1c8,
but that isn't to say that we should say that the device resources
start at 0x810084 and have a size of 0x144, when the bus level decodes
a 64K chunk of memory.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: dove: add DT LCD controllers
Date: Wed, 19 Nov 2014 16:47:13 +0000 [thread overview]
Message-ID: <20141119164713.GJ4042@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20141119174050.122a0cc0@armhf>
On Wed, Nov 19, 2014 at 05:40:50PM +0100, Jean-Francois Moine wrote:
> On Wed, 19 Nov 2014 11:32:29 +0000
> Russell King <rmk+kernel@arm.linux.org.uk> wrote:
>
> > + lcd1: lcd-controller at 810000 {
> > + compatible = "marvell,dove-lcd";
> > + reg = <0x810000 0x1000>;
> > + interrupts = <46>;
> > + status = "disabled";
> > + };
>
> The I/O range of the LCDs is only 0x1c8. Why do you set it 0x1000?
Actually, a more correct value would be 0x10000, if you read table 145.
Yes, the device may onlny have documented registers from 0x84 to 0x1c8,
but that isn't to say that we should say that the device resources
start at 0x810084 and have a size of 0x144, when the bus level decodes
a 64K chunk of memory.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-11-19 16:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 11:32 [PATCH] ARM: dts: dove: add DT LCD controllers Russell King
2014-11-19 11:32 ` Russell King
2014-11-19 16:40 ` Jean-Francois Moine
2014-11-19 16:40 ` Jean-Francois Moine
2014-11-19 16:47 ` Russell King - ARM Linux [this message]
2014-11-19 16:47 ` Russell King - ARM Linux
[not found] ` <E1Xr3Ur-0005Qx-Fx-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2014-11-22 4:12 ` Jason Cooper
2014-11-22 4:12 ` Jason Cooper
-- strict thread matches above, loose matches on Subject: below --
2014-07-24 14:45 Russell King
2014-07-24 14:45 ` Russell King
[not found] ` <E1XAKGS-0004WE-8h-eh5Bv4kxaXIANfyc6IWni62ZND6+EDdj@public.gmane.org>
2014-07-24 15:09 ` Sebastian Hesselbarth
2014-07-24 15:09 ` Sebastian Hesselbarth
2014-07-25 0:10 ` Jason Cooper
2014-07-25 0:10 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119164713.GJ4042@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=moinejf@free.fr \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.