* [PATCH] kconfig: Fix compiler warning
@ 2014-11-20 5:44 Eddie Kovsky
2014-11-28 13:19 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Eddie Kovsky @ 2014-11-20 5:44 UTC (permalink / raw)
To: Yann E. MORIN, linux-kbuild; +Cc: trivial, linux-kernel
Fixes gcc warning when building linux-next:
In file included from scripts/kconfig/zconf.tab.c:2537:0:
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized]
jump->offset = strlen(r->s);
^
scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
struct jump_key *jump;
^
HOSTLD scripts/kconfig/conf
Moved the initialization of struct jump_key *jump outside the first
'if' branch so it can be available throughout the function.
Also uses the preferred pointer syntax for passing the size of a struct.
Tested on next-20141119.
Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index a26cc5d2a9b0..a728d23949e7 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -559,8 +559,8 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
if (location == NULL && accessible)
location = menu;
}
+ jump = xmalloc(sizeof(*jump));
if (head && location) {
- jump = xmalloc(sizeof(struct jump_key));
if (menu_is_visible(prop->menu)) {
/*
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kconfig: Fix compiler warning
2014-11-20 5:44 [PATCH] kconfig: Fix compiler warning Eddie Kovsky
@ 2014-11-28 13:19 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2014-11-28 13:19 UTC (permalink / raw)
To: Eddie Kovsky; +Cc: Yann E. MORIN, linux-kbuild, trivial, linux-kernel
On 2014-11-20 06:44, Eddie Kovsky wrote:
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index a26cc5d2a9b0..a728d23949e7 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -559,8 +559,8 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
> if (location == NULL && accessible)
> location = menu;
> }
> + jump = xmalloc(sizeof(*jump));
> if (head && location) {
> - jump = xmalloc(sizeof(struct jump_key));
This creates a memory leak, because 'jump' is allocated, but not added
to the list, if the following condition is not met.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-28 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-20 5:44 [PATCH] kconfig: Fix compiler warning Eddie Kovsky
2014-11-28 13:19 ` Michal Marek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.