All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Timo Kokkonen <timo.kokkonen@offcode.fi>,
	linux-arm-kernel@lists.infradead.org,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] at91sam9_wdt: Allow watchdog to reset device at early boot
Date: Fri, 28 Nov 2014 01:30:02 +0100	[thread overview]
Message-ID: <20141128003002.GN4508@piout.net> (raw)
In-Reply-To: <54777C18.3010609@roeck-us.net>

On 27/11/2014 at 11:31:36 -0800, Guenter Roeck wrote :
> On 11/27/2014 11:06 AM, Boris Brezillon wrote:
> >>As for DT not supposed to be used for configuration, that is really a
> >>tricky problem which is hard to solve. I seem to recall, though, that
> >>it may be now acceptable under certain conditions. A module parameter
> >>might be easier.
> >
> >I'm not a big fan of passing these kind information through module
> >params, cause it's kind of hard to assign parameters when you have
> >multiple device instances (it might not be applicable to watchdog
> >devices though).
> >Moreover, adding more module parameters will just expand the cmdline
> >and make it less and less readable.
> >
> Agreed but ...
> 
> >Anyway, this is not my call to make :-).
> 
> it isn't us who restrict the DT scope (though of course timeout-sec
> _is_ configuration, but that was before things got more restrictive).
> 

My understanding is that it is OK if this is something you need at boot
time versus something you can configure from userspace later. But I'm
not a DT expert ;)

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91sam9_wdt: Allow watchdog to reset device at early boot
Date: Fri, 28 Nov 2014 01:30:02 +0100	[thread overview]
Message-ID: <20141128003002.GN4508@piout.net> (raw)
In-Reply-To: <54777C18.3010609@roeck-us.net>

On 27/11/2014 at 11:31:36 -0800, Guenter Roeck wrote :
> On 11/27/2014 11:06 AM, Boris Brezillon wrote:
> >>As for DT not supposed to be used for configuration, that is really a
> >>tricky problem which is hard to solve. I seem to recall, though, that
> >>it may be now acceptable under certain conditions. A module parameter
> >>might be easier.
> >
> >I'm not a big fan of passing these kind information through module
> >params, cause it's kind of hard to assign parameters when you have
> >multiple device instances (it might not be applicable to watchdog
> >devices though).
> >Moreover, adding more module parameters will just expand the cmdline
> >and make it less and less readable.
> >
> Agreed but ...
> 
> >Anyway, this is not my call to make :-).
> 
> it isn't us who restrict the DT scope (though of course timeout-sec
> _is_ configuration, but that was before things got more restrictive).
> 

My understanding is that it is OK if this is something you need at boot
time versus something you can configure from userspace later. But I'm
not a DT expert ;)

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-11-28  0:30 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 10:40 [PATCH] at91sam9_wdt: Allow watchdog to reset device at early boot Timo Kokkonen
2014-10-23 10:40 ` Timo Kokkonen
2014-11-12  8:20 ` Timo Kokkonen
2014-11-12  8:20   ` Timo Kokkonen
2014-11-13  9:12   ` Nicolas Ferre
2014-11-13  9:12     ` Nicolas Ferre
2014-11-14  8:40     ` Timo Kokkonen
2014-11-14  8:40       ` Timo Kokkonen
2014-11-21 12:23       ` Timo Kokkonen
2014-11-21 12:23         ` Timo Kokkonen
2014-11-27  6:53         ` Timo Kokkonen
2014-11-27  6:53           ` Timo Kokkonen
2014-11-27  9:22           ` Nicolas Ferre
2014-11-27  9:22             ` Nicolas Ferre
2014-11-27 17:23             ` Guenter Roeck
2014-11-27 17:23               ` Guenter Roeck
2014-11-27 19:06               ` Boris Brezillon
2014-11-27 19:06                 ` Boris Brezillon
2014-11-27 19:31                 ` Guenter Roeck
2014-11-27 19:31                   ` Guenter Roeck
2014-11-28  0:30                   ` Alexandre Belloni [this message]
2014-11-28  0:30                     ` Alexandre Belloni
2014-11-28  6:40                   ` Timo Kokkonen
2014-11-28  6:40                     ` Timo Kokkonen
2014-11-27 19:00         ` Boris Brezillon
2014-11-27 19:00           ` Boris Brezillon
2014-11-28  6:42           ` Timo Kokkonen
2014-11-28  6:42             ` Timo Kokkonen
2014-12-05 12:57           ` Timo Kokkonen
2014-12-05 12:57             ` Timo Kokkonen
2014-12-05 14:12             ` Boris Brezillon
2014-12-05 14:12               ` Boris Brezillon
2014-12-05 18:42               ` Timo Kokkonen
2014-12-05 18:42                 ` Timo Kokkonen
2014-12-05 19:02                 ` Guenter Roeck
2014-12-05 19:02                   ` Guenter Roeck
2014-12-05 20:32                   ` Timo Kokkonen
2014-12-05 20:32                     ` Timo Kokkonen
2014-12-05 21:39                     ` Guenter Roeck
2014-12-05 21:39                       ` Guenter Roeck
2014-12-06 10:11                       ` Timo Kokkonen
2014-12-06 10:11                         ` Timo Kokkonen
2015-01-13 14:53                         ` Guenter Roeck
2015-01-13 14:53                           ` Guenter Roeck
2015-01-14  6:09                           ` Timo Kokkonen
2015-01-14  6:09                             ` Timo Kokkonen
2015-02-18 12:57                           ` [PATCHv3 0/2] watchdog: Introduce "early-timeout-sec" property Timo Kokkonen
2015-02-18 12:57                             ` Timo Kokkonen
2015-02-18 12:57                             ` [PATCH 1/2] devicetree: Document generic watchdog properties Timo Kokkonen
2015-02-18 12:57                               ` Timo Kokkonen
2015-02-18 12:57                             ` [PATCH 2/2] at91sam9_wdt: Allow watchdog to reset device at early boot Timo Kokkonen
2015-02-18 12:57                               ` Timo Kokkonen
2015-02-18 13:21                               ` Boris Brezillon
2015-02-18 13:21                                 ` Boris Brezillon
2015-02-18 13:59                               ` Guenter Roeck
2015-02-18 13:59                                 ` Guenter Roeck
2015-02-18 14:17                                 ` Boris Brezillon
2015-02-18 14:17                                   ` Boris Brezillon
2015-02-18 14:50                                   ` Guenter Roeck
2015-02-18 14:50                                     ` Guenter Roeck
2015-02-18 16:00                                     ` Alexandre Belloni
2015-02-18 16:00                                       ` Alexandre Belloni
2015-02-18 17:50                                       ` Guenter Roeck
2015-02-18 17:50                                         ` Guenter Roeck
2015-02-18 20:21                                         ` Boris Brezillon
2015-02-18 20:21                                           ` Boris Brezillon
2015-02-19  6:02                                           ` Timo Kokkonen
2015-02-19  6:02                                             ` Timo Kokkonen
2015-02-18 21:11                                       ` Rob Herring
2015-02-18 21:11                                         ` Rob Herring
2015-02-19  6:14                                         ` Timo Kokkonen
2015-02-19  6:14                                           ` Timo Kokkonen
2015-02-20 14:06                                           ` Rob Herring
2015-02-20 14:06                                             ` Rob Herring
2015-02-20 16:28                                             ` Guenter Roeck
2015-02-20 16:28                                               ` Guenter Roeck
2015-02-20 19:43                                               ` Boris Brezillon
2015-02-20 19:43                                                 ` Boris Brezillon
2015-02-20 20:04                                                 ` Guenter Roeck
2015-02-20 20:04                                                   ` Guenter Roeck
2015-02-20  7:48                               ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-20  7:48                                 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-20  7:51                                 ` Boris Brezillon
2015-02-20  7:51                                   ` Boris Brezillon
2015-02-20 16:33                                   ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-20 16:33                                     ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-20 17:16                                     ` Boris Brezillon
2015-02-20 17:16                                       ` Boris Brezillon
2015-02-20 18:06                                       ` Guenter Roeck
2015-02-20 18:06                                         ` Guenter Roeck
2015-02-23  7:29                                         ` Timo Kokkonen
2015-02-23  7:29                                           ` Timo Kokkonen
2015-02-23  8:51                                           ` Boris Brezillon
2015-02-23  8:51                                             ` Boris Brezillon
2015-02-23  9:11                                             ` Timo Kokkonen
2015-02-23  9:11                                               ` Timo Kokkonen
2015-02-23 16:19                                               ` Guenter Roeck
2015-02-23 16:19                                                 ` Guenter Roeck
2015-02-23 17:10                                                 ` Rob Herring
2015-02-23 17:10                                                   ` Rob Herring
2015-02-23 17:43                                                   ` Guenter Roeck
2015-02-23 17:43                                                     ` Guenter Roeck
2015-02-20  8:00                                 ` Timo Kokkonen
2015-02-20  8:00                                   ` Timo Kokkonen
2015-02-20 16:09                                 ` Guenter Roeck
2015-02-20 16:09                                   ` Guenter Roeck
2015-02-18 13:16                             ` [PATCHv3 0/2] watchdog: Introduce "early-timeout-sec" property Boris Brezillon
2015-02-18 13:16                               ` Boris Brezillon
2015-02-18 13:51                               ` Timo Kokkonen
2015-02-18 13:51                                 ` Timo Kokkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141128003002.GN4508@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nicolas.ferre@atmel.com \
    --cc=timo.kokkonen@offcode.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.