* [patch] USB: mos7720: delete some unneeded code
@ 2014-11-29 12:49 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-11-29 12:49 UTC (permalink / raw)
To: kernel-janitors
The "status" is uninitialized so this creates a static checker warning.
But it's harmless, we can just delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c
index 312b0fe..4f70df3 100644
--- a/drivers/usb/serial/mos7720.c
+++ b/drivers/usb/serial/mos7720.c
@@ -1299,8 +1299,6 @@ static void mos7720_throttle(struct tty_struct *tty)
mos7720_port->shadowMCR &= ~UART_MCR_RTS;
write_mos_reg(port->serial, port->port_number, MCR,
mos7720_port->shadowMCR);
- if (status != 0)
- return;
}
}
@@ -1331,8 +1329,6 @@ static void mos7720_unthrottle(struct tty_struct *tty)
mos7720_port->shadowMCR |= UART_MCR_RTS;
write_mos_reg(port->serial, port->port_number, MCR,
mos7720_port->shadowMCR);
- if (status != 0)
- return;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] USB: mos7720: delete some unneeded code
@ 2014-12-05 11:22 Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2014-12-05 11:22 UTC (permalink / raw)
To: kernel-janitors
On Sat, Nov 29, 2014 at 03:49:54PM +0300, Dan Carpenter wrote:
> The "status" is uninitialized so this creates a static checker warning.
> But it's harmless, we can just delete it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, Dan. I'll queue it up and apply once 3.19-rc1 is out.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-05 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-29 12:49 [patch] USB: mos7720: delete some unneeded code Dan Carpenter
2014-12-05 11:22 Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.