Re: [PATCH v9 3/8] devicetree: mfd: Add new SKY81452 mfd binding

[Gyungoh Yoo <gyungoh@gmail.com>]

On Tue, Dec 02, 2014 at 02:07:27PM +0000, Lee Jones wrote:
> This requires a DT Ack.

I think I need to double-check the recipients.
Thank you for the comment.

> 
> > From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> > 
> > Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> > ---
> > Changes v9:
> > Nothing
> > 
> > Changes v8:
> > Made up the example for backlight DT
> > 
> > Changes v7:
> > Nothing
> > 
> > Changes v6:
> > Nothing
> > 
> > Changes v5:
> > Changed DT for regulator : 'lout' node should be defined under 'regulator'
> > Removed compatible string from sky81452-regulator driver
> > 
> > Changes v4:
> > Nothing
> > 
> > Changes v3:
> > Nothing
> > 
> > Changes v2:
> > Added reg attribute for I2C slave address
> > 
> >  Documentation/devicetree/bindings/mfd/sky81452.txt | 36 ++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/sky81452.txt b/Documentation/devicetree/bindings/mfd/sky81452.txt
> > new file mode 100644
> > index 0000000..ab71473
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/sky81452.txt
> > @@ -0,0 +1,36 @@
> > +SKY81452 bindings
> > +
> > +Required properties:
> > +- compatible	: Must be "skyworks,sky81452"
> > +- reg		: I2C slave address
> > +
> > +Required child nodes:
> > +- backlight	: container node for backlight following the binding
> > +		in video/backlight/sky81452-backlight.txt
> > +- regulator	: container node for regulators following the binding
> > +		in regulator/sky81452-regulator.txt
> > +
> > +Example:
> > +
> > +	sky81452@2c {
> > +		compatible = "skyworks,sky81452";
> > +		reg = <0x2c>;
> > +
> > +		backlight {
> > +			compatible = "skyworks,sky81452-backlight";
> > +			name = "pwm-backlight";
> > +			skyworks,en-channels = <0x3f>;
> > +			skyworks,ignore-pwm;
> > +			skyworks,phase-shift;
> > +			skyworks,ovp-level = <20>;
> > +			skyworks,current-limit = <2300>;
> > +		};
> > +
> > +		regulator {
> > +			lout {
> > +				regulator-name = "sky81452-lout";
> > +				regulator-min-microvolt = <4500000>;
> > +				regulator-max-microvolt = <8000000>;
> > +			};
> > +		};
> > +	};
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog