From: Lee Jones <lee.jones@linaro.org>
To: Flora Fu <flora.fu@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Grant Likely <grant.likely@linaro.org>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
srv_heupstream@mediatek.com,
Eddie Huang <eddie.huang@mediatek.com>,
Dongdong Cheng <dongdong.cheng@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>
Subject: Re: [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD
Date: Wed, 3 Dec 2014 09:26:19 +0000 [thread overview]
Message-ID: <20141203092619.GA327@x1> (raw)
In-Reply-To: <1417596018.24267.62.camel@mtksdaap41>
On Wed, 03 Dec 2014, Flora Fu wrote:
> On Mon, 2014-12-01 at 11:47 +0000, Lee Jones wrote:
> > On Fri, 28 Nov 2014, Flora Fu wrote:
>
> >
> > > + if (!mt6397)
> > > + return -ENOMEM;
> > > +
> > > + mt6397->dev = &pdev->dev;
> >
> > Is this used else where? If not, I think you can remove it.
>
> No one is used it in this patch sets but it will be used for irq
> functions to get irq id or print logs for error case in the future.
> Can I keep it in the patch?
It's not uncommon for devices to do this and if you're sure it's going
to be used in the future you may as well keep it in.
> > > + mt6397->regmap = wrp->regmap;
> > > + platform_set_drvdata(pdev, mt6397);
> >
> > Then you can platform_set_drvdata(pdev, regmap);
> >
> > Although I don't see this being used either. Is it used in the child
> > devices?
> >
> Yes, it is used to provide regmap handle for its child device. In the
> patch set, regulator uses it.
Okay.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD
Date: Wed, 3 Dec 2014 09:26:19 +0000 [thread overview]
Message-ID: <20141203092619.GA327@x1> (raw)
In-Reply-To: <1417596018.24267.62.camel@mtksdaap41>
On Wed, 03 Dec 2014, Flora Fu wrote:
> On Mon, 2014-12-01 at 11:47 +0000, Lee Jones wrote:
> > On Fri, 28 Nov 2014, Flora Fu wrote:
>
> >
> > > + if (!mt6397)
> > > + return -ENOMEM;
> > > +
> > > + mt6397->dev = &pdev->dev;
> >
> > Is this used else where? If not, I think you can remove it.
>
> No one is used it in this patch sets but it will be used for irq
> functions to get irq id or print logs for error case in the future.
> Can I keep it in the patch?
It's not uncommon for devices to do this and if you're sure it's going
to be used in the future you may as well keep it in.
> > > + mt6397->regmap = wrp->regmap;
> > > + platform_set_drvdata(pdev, mt6397);
> >
> > Then you can platform_set_drvdata(pdev, regmap);
> >
> > Although I don't see this being used either. Is it used in the child
> > devices?
> >
> Yes, it is used to provide regmap handle for its child device. In the
> patch set, regulator uses it.
Okay.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-12-03 9:26 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 3:54 [PATCH v2 0/8] Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 3:54 ` [PATCH v2 1/8] soc: mediatek: Add PMIC wrapper for MT8135 and MT6397 SoC Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 15:32 ` Mark Brown
2014-11-28 15:32 ` Mark Brown
2014-11-28 15:32 ` Mark Brown
2014-11-28 3:54 ` [PATCH v2 2/8] mfd: MT6397: Add support for PMIC MT6397 MFD Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-12-01 11:47 ` Lee Jones
2014-12-01 11:47 ` Lee Jones
2014-12-01 11:47 ` Lee Jones
2014-12-03 8:40 ` Flora Fu
2014-12-03 8:40 ` Flora Fu
2014-12-03 9:26 ` Lee Jones [this message]
2014-12-03 9:26 ` Lee Jones
2014-11-28 3:54 ` [PATCH v2 3/8] regulator: MT6397: Add support for MT6397 regulator Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 15:22 ` Mark Brown
2014-11-28 15:22 ` Mark Brown
2014-11-28 15:22 ` Mark Brown
2014-12-01 2:51 ` Flora Fu
2014-12-01 2:51 ` Flora Fu
2014-12-01 16:12 ` Mark Brown
2014-12-01 16:12 ` Mark Brown
2014-12-01 16:12 ` Mark Brown
2014-11-28 3:54 ` [PATCH v2 4/8] dt-bindings:: Add document for MT8135 PMIC Wrapper Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 3:54 ` [PATCH v2 5/8] dt-bindings: Add document for MT6397 MFD Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 3:54 ` [PATCH v2 6/8] dt-bindings: Add document for MT6397 regulator Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 15:30 ` Mark Brown
2014-11-28 15:30 ` Mark Brown
2014-11-28 15:30 ` Mark Brown
2014-11-28 3:54 ` [PATCH v2 7/8] ARM: dts: mt8135: Add support for PMIC MT6397 MFD Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 3:54 ` [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator Flora Fu
2014-11-28 3:54 ` Flora Fu
2014-11-28 15:30 ` Mark Brown
2014-11-28 15:30 ` Mark Brown
2014-11-28 15:30 ` Mark Brown
2014-12-01 3:19 ` Flora Fu
2014-12-01 3:19 ` Flora Fu
2014-12-01 6:40 ` Sascha Hauer
2014-12-01 6:40 ` Sascha Hauer
2014-12-01 6:40 ` Sascha Hauer
2014-12-01 11:16 ` Mark Brown
2014-12-01 11:16 ` Mark Brown
2014-12-01 11:16 ` Mark Brown
2014-12-01 7:04 ` [PATCH v2 0/8] Add Support for MediaTek PMIC MT6397 MFD Core and Regulator Sascha Hauer
2014-12-01 7:04 ` Sascha Hauer
2014-12-01 7:04 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203092619.GA327@x1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=dongdong.cheng@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=flora.fu@mediatek.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.