All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
	sonnyrao@chromium.org, heiko@sntech.de,
	linux-arm-kernel@lists.infradead.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec
Date: Wed, 3 Dec 2014 19:20:24 +0000	[thread overview]
Message-ID: <20141203192024.GL7712@sirena.org.uk> (raw)
In-Reply-To: <1417591118-18695-3-git-send-email-jay.xu@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote:
> From: Sonny Rao <sonnyrao@chromium.org>
> 
> We need to claim the clock which is driving the codec so that when we enable
> clock gating, we continue to clock the codec when needed.  I make this an
> optional clock since there might be some applications where we don't need it
> but can still use the I2S block.

I would expect that the clock for the CODEC should be managed by the
CODEC if at all possible - that seems more logical than having the CPU
I2S controller request and manage it if it's a separate clock.  Why add
this to the CPU side driver?

We've not always done this for older systems due to the lack of a usable
clock API but that's starting to be addressed.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec
Date: Wed, 3 Dec 2014 19:20:24 +0000	[thread overview]
Message-ID: <20141203192024.GL7712@sirena.org.uk> (raw)
In-Reply-To: <1417591118-18695-3-git-send-email-jay.xu@rock-chips.com>

On Wed, Dec 03, 2014 at 03:18:38PM +0800, Jianqun Xu wrote:
> From: Sonny Rao <sonnyrao@chromium.org>
> 
> We need to claim the clock which is driving the codec so that when we enable
> clock gating, we continue to clock the codec when needed.  I make this an
> optional clock since there might be some applications where we don't need it
> but can still use the I2S block.

I would expect that the clock for the CODEC should be managed by the
CODEC if at all possible - that seems more logical than having the CPU
I2S controller request and manage it if it's a separate clock.  Why add
this to the CPU side driver?

We've not always done this for older systems due to the lack of a usable
clock API but that's starting to be addressed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141203/a1669c61/attachment.sig>

  reply	other threads:[~2014-12-03 19:20 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 14:49 [PATCH 0/2] rockchip: i2s: patches to add optional clock output from Jianqun Xu
2014-12-02 14:49 ` Jianqun Xu
2014-12-02 14:49 ` Jianqun Xu
2014-12-02 14:49 ` [PATCH 1/2] ASoC: rockchip-i2s: dt: add an optional property "i2s_clk_out" Jianqun Xu
2014-12-02 14:49   ` Jianqun Xu
2014-12-02 17:57   ` Doug Anderson
2014-12-02 17:57     ` Doug Anderson
2014-12-02 17:57     ` Doug Anderson
2014-12-02 14:52 ` [PATCH 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec Jianqun Xu
2014-12-02 14:52   ` Jianqun Xu
2014-12-02 14:52   ` Jianqun Xu
2014-12-02 17:54   ` Doug Anderson
2014-12-02 17:54     ` Doug Anderson
2014-12-02 17:54     ` Doug Anderson
2014-12-03  1:03     ` Jianqun
2014-12-03  1:03       ` Jianqun
2014-12-03  1:03       ` Jianqun
2014-12-03  5:18       ` Doug Anderson
2014-12-03  5:18         ` Doug Anderson
2014-12-03  5:18         ` Doug Anderson
2014-12-03 12:55         ` Mark Brown
2014-12-03 12:55           ` Mark Brown
2014-12-03 12:55           ` Mark Brown
2014-12-03  7:18 ` [PATCH v2 0/2] ASoC: rockchip: i2s: driver could output "i2s-clk-out" optionally Jianqun Xu
2014-12-03  7:18   ` Jianqun Xu
2014-12-03  7:18   ` Jianqun Xu
2014-12-03  7:18   ` [PATCH v2 1/2] ASoC: dt-bindings: rockchip-i2s: add an optional property "i2s_clk_out" Jianqun Xu
2014-12-03  7:18     ` Jianqun Xu
2014-12-03  7:18   ` [PATCH v2 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec Jianqun Xu
2014-12-03  7:18     ` Jianqun Xu
2014-12-03  7:18     ` Jianqun Xu
2014-12-03 19:20     ` Mark Brown [this message]
2014-12-03 19:20       ` Mark Brown
2014-12-03 19:38       ` Sonny Rao
2014-12-03 19:38         ` Sonny Rao
2014-12-03 19:38         ` Sonny Rao
2014-12-03 20:03         ` Mark Brown
2014-12-03 20:03           ` Mark Brown
2014-12-03 20:03           ` Mark Brown
2014-12-03 23:03           ` Sonny Rao
2014-12-03 23:03             ` Sonny Rao
2014-12-03 23:03             ` Sonny Rao
2014-12-03 23:22             ` [alsa-devel] " Dylan Reid
2014-12-03 23:22               ` Dylan Reid
2014-12-03 23:52               ` Sonny Rao
2014-12-03 23:52                 ` Sonny Rao
2014-12-03 23:52                 ` Sonny Rao
  -- strict thread matches above, loose matches on Subject: below --
2014-11-19  3:07 [PATCH " Jianqun Xu
2014-11-19  8:09 ` [PATCH v2 " Jianqun Xu
2014-11-19  8:09   ` Jianqun Xu
2014-11-19  8:09   ` Jianqun Xu
2014-11-19 10:17   ` Heiko Stübner
2014-11-19 10:17     ` Heiko Stübner
2014-11-19 10:27   ` Kever Yang
2014-11-19 10:27     ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203192024.GL7712@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jay.xu@rock-chips.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=perex@perex.cz \
    --cc=sonnyrao@chromium.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.