* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-11-26 20:27 ` Felipe Balbi
0 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-11-26 20:27 UTC (permalink / raw)
To: Tony Lindgren
Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
Felipe Balbi, Sebastian Reichel, Hans Verkuil,
Mauro Carvalho Chehab
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
si4713 platform data) updated board-rx51-peripherals.c
so that si4713 could be easily used on DT boot, but
it ended up introducing a build warning whenever
si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index d18a5cf..bda20c5 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
.gpio_reset = 60,
};
+#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
static struct si4713_platform_data rx51_si4713_platform_data = {
.is_platform_device = true
};
+#endif
static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
--
2.1.0.GIT
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-11-26 20:27 ` Felipe Balbi
0 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-11-26 20:27 UTC (permalink / raw)
To: Tony Lindgren
Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
Felipe Balbi, Sebastian Reichel, Hans Verkuil,
Mauro Carvalho Chehab
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
si4713 platform data) updated board-rx51-peripherals.c
so that si4713 could be easily used on DT boot, but
it ended up introducing a build warning whenever
si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index d18a5cf..bda20c5 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
.gpio_reset = 60,
};
+#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
static struct si4713_platform_data rx51_si4713_platform_data = {
.is_platform_device = true
};
+#endif
static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
--
2.1.0.GIT
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-11-26 20:27 ` Felipe Balbi
0 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-11-26 20:27 UTC (permalink / raw)
To: linux-arm-kernel
commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
si4713 platform data) updated board-rx51-peripherals.c
so that si4713 could be easily used on DT boot, but
it ended up introducing a build warning whenever
si4713 isn't enabled.
This patches fixes that warning:
arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
static struct si4713_platform_data rx51_si4713_platform_data = {
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index d18a5cf..bda20c5 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
.gpio_reset = 60,
};
+#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
static struct si4713_platform_data rx51_si4713_platform_data = {
.is_platform_device = true
};
+#endif
static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
--
2.1.0.GIT
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-11-26 20:27 ` Felipe Balbi
@ 2014-11-26 21:56 ` Sebastian Reichel
-1 siblings, 0 replies; 21+ messages in thread
From: Sebastian Reichel @ 2014-11-26 21:56 UTC (permalink / raw)
To: Felipe Balbi
Cc: Tony Lindgren, Linux OMAP Mailing List,
Linux ARM Kernel Mailing List, Hans Verkuil,
Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-11-26 21:56 ` Sebastian Reichel
0 siblings, 0 replies; 21+ messages in thread
From: Sebastian Reichel @ 2014-11-26 21:56 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141126/154769c8/attachment-0001.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-11-26 20:27 ` Felipe Balbi
@ 2014-11-27 7:41 ` Hans Verkuil
-1 siblings, 0 replies; 21+ messages in thread
From: Hans Verkuil @ 2014-11-27 7:41 UTC (permalink / raw)
To: Felipe Balbi, Tony Lindgren
Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
Sebastian Reichel, Hans Verkuil, Mauro Carvalho Chehab
On 11/26/2014 09:27 PM, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
> .gpio_reset = 60,
> };
>
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> static struct si4713_platform_data rx51_si4713_platform_data = {
> .is_platform_device = true
> };
> +#endif
>
> static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
> #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-11-27 7:41 ` Hans Verkuil
0 siblings, 0 replies; 21+ messages in thread
From: Hans Verkuil @ 2014-11-27 7:41 UTC (permalink / raw)
To: linux-arm-kernel
On 11/26/2014 09:27 PM, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
> .gpio_reset = 60,
> };
>
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> static struct si4713_platform_data rx51_si4713_platform_data = {
> .is_platform_device = true
> };
> +#endif
>
> static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
> #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-11-26 20:27 ` Felipe Balbi
@ 2014-12-04 15:24 ` Felipe Balbi
-1 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-12-04 15:24 UTC (permalink / raw)
To: Felipe Balbi
Cc: Tony Lindgren, Linux OMAP Mailing List,
Linux ARM Kernel Mailing List, Sebastian Reichel, Hans Verkuil,
Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]
On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
a gentle reminder on this one.
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
> .gpio_reset = 60,
> };
>
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> static struct si4713_platform_data rx51_si4713_platform_data = {
> .is_platform_device = true
> };
> +#endif
>
> static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
> #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> --
> 2.1.0.GIT
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-12-04 15:24 ` Felipe Balbi
0 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-12-04 15:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> si4713 platform data) updated board-rx51-peripherals.c
> so that si4713 could be easily used on DT boot, but
> it ended up introducing a build warning whenever
> si4713 isn't enabled.
>
> This patches fixes that warning:
>
> arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> static struct si4713_platform_data rx51_si4713_platform_data = {
>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
a gentle reminder on this one.
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index d18a5cf..bda20c5 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -997,9 +997,11 @@ static struct aic3x_pdata rx51_aic3x_data2 = {
> .gpio_reset = 60,
> };
>
> +#if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> static struct si4713_platform_data rx51_si4713_platform_data = {
> .is_platform_device = true
> };
> +#endif
>
> static struct i2c_board_info __initdata rx51_peripherals_i2c_board_info_2[] = {
> #if IS_ENABLED(CONFIG_I2C_SI4713) && IS_ENABLED(CONFIG_PLATFORM_SI4713)
> --
> 2.1.0.GIT
>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/2085bc1e/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-12-04 15:24 ` Felipe Balbi
@ 2014-12-04 15:41 ` Arnd Bergmann
-1 siblings, 0 replies; 21+ messages in thread
From: Arnd Bergmann @ 2014-12-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel, balbi
Cc: Mauro Carvalho Chehab, Tony Lindgren, Sebastian Reichel,
Hans Verkuil, Linux OMAP Mailing List
On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > si4713 platform data) updated board-rx51-peripherals.c
> > so that si4713 could be easily used on DT boot, but
> > it ended up introducing a build warning whenever
> > si4713 isn't enabled.
> >
> > This patches fixes that warning:
> >
> > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > static struct si4713_platform_data rx51_si4713_platform_data = {
> >
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>
> a gentle reminder on this one.
>
Let me add my
Acked-by: Arnd Bergmann <arnd@arndb.de>
You didn't say who you expect to pick up the patch. I assume Mauro
should take it because he took the patch that caused the problem,
but he might not be aware that he should look at this now.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-12-04 15:41 ` Arnd Bergmann
0 siblings, 0 replies; 21+ messages in thread
From: Arnd Bergmann @ 2014-12-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > si4713 platform data) updated board-rx51-peripherals.c
> > so that si4713 could be easily used on DT boot, but
> > it ended up introducing a build warning whenever
> > si4713 isn't enabled.
> >
> > This patches fixes that warning:
> >
> > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> > static struct si4713_platform_data rx51_si4713_platform_data = {
> >
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>
> a gentle reminder on this one.
>
Let me add my
Acked-by: Arnd Bergmann <arnd@arndb.de>
You didn't say who you expect to pick up the patch. I assume Mauro
should take it because he took the patch that caused the problem,
but he might not be aware that he should look at this now.
Arnd
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-12-04 15:41 ` Arnd Bergmann
@ 2014-12-04 15:48 ` Felipe Balbi
-1 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-12-04 15:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, balbi, Mauro Carvalho Chehab, Tony Lindgren,
Sebastian Reichel, Hans Verkuil, Linux OMAP Mailing List
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
Hi,
On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > si4713 platform data) updated board-rx51-peripherals.c
> > > so that si4713 could be easily used on DT boot, but
> > > it ended up introducing a build warning whenever
> > > si4713 isn't enabled.
> > >
> > > This patches fixes that warning:
> > >
> > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > >
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> >
> > a gentle reminder on this one.
> >
>
> Let me add my
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> You didn't say who you expect to pick up the patch. I assume Mauro
patch author now decides who takes the patch ? That's new :-)
> should take it because he took the patch that caused the problem,
> but he might not be aware that he should look at this now.
He is in Cc, let's ask him :-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-12-04 15:48 ` Felipe Balbi
0 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-12-04 15:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > si4713 platform data) updated board-rx51-peripherals.c
> > > so that si4713 could be easily used on DT boot, but
> > > it ended up introducing a build warning whenever
> > > si4713 isn't enabled.
> > >
> > > This patches fixes that warning:
> > >
> > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > >
> > > Cc: Sebastian Reichel <sre@kernel.org>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> >
> > a gentle reminder on this one.
> >
>
> Let me add my
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> You didn't say who you expect to pick up the patch. I assume Mauro
patch author now decides who takes the patch ? That's new :-)
> should take it because he took the patch that caused the problem,
> but he might not be aware that he should look at this now.
He is in Cc, let's ask him :-)
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/e8abb4a4/attachment-0001.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-12-04 15:48 ` Felipe Balbi
@ 2014-12-04 16:39 ` Tony Lindgren
-1 siblings, 0 replies; 21+ messages in thread
From: Tony Lindgren @ 2014-12-04 16:39 UTC (permalink / raw)
To: Felipe Balbi
Cc: Arnd Bergmann, linux-arm-kernel, Mauro Carvalho Chehab,
Sebastian Reichel, Hans Verkuil, Linux OMAP Mailing List
* Felipe Balbi <balbi@ti.com> [141204 07:50]:
> Hi,
>
> On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > so that si4713 could be easily used on DT boot, but
> > > > it ended up introducing a build warning whenever
> > > > si4713 isn't enabled.
> > > >
> > > > This patches fixes that warning:
> > > >
> > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > >
> > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > >
> > > a gentle reminder on this one.
> > >
> >
> > Let me add my
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > You didn't say who you expect to pick up the patch. I assume Mauro
>
> patch author now decides who takes the patch ? That's new :-)
>
> > should take it because he took the patch that caused the problem,
> > but he might not be aware that he should look at this now.
>
> He is in Cc, let's ask him :-)
Best that this one goes in along with the other si4713 patches
to avoid dependencies between trees:
Acked-by: Tony Lindgren <tony@atomide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-12-04 16:39 ` Tony Lindgren
0 siblings, 0 replies; 21+ messages in thread
From: Tony Lindgren @ 2014-12-04 16:39 UTC (permalink / raw)
To: linux-arm-kernel
* Felipe Balbi <balbi@ti.com> [141204 07:50]:
> Hi,
>
> On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > so that si4713 could be easily used on DT boot, but
> > > > it ended up introducing a build warning whenever
> > > > si4713 isn't enabled.
> > > >
> > > > This patches fixes that warning:
> > > >
> > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > >
> > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > >
> > > a gentle reminder on this one.
> > >
> >
> > Let me add my
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > You didn't say who you expect to pick up the patch. I assume Mauro
>
> patch author now decides who takes the patch ? That's new :-)
>
> > should take it because he took the patch that caused the problem,
> > but he might not be aware that he should look at this now.
>
> He is in Cc, let's ask him :-)
Best that this one goes in along with the other si4713 patches
to avoid dependencies between trees:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-12-04 16:39 ` Tony Lindgren
@ 2014-12-04 17:00 ` Mauro Carvalho Chehab
-1 siblings, 0 replies; 21+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-04 17:00 UTC (permalink / raw)
To: Tony Lindgren
Cc: Felipe Balbi, Arnd Bergmann, linux-arm-kernel, Sebastian Reichel,
Hans Verkuil, Linux OMAP Mailing List
Em Thu, 04 Dec 2014 08:39:31 -0800
Tony Lindgren <tony@atomide.com> escreveu:
> * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > Hi,
> >
> > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > so that si4713 could be easily used on DT boot, but
> > > > > it ended up introducing a build warning whenever
> > > > > si4713 isn't enabled.
> > > > >
> > > > > This patches fixes that warning:
> > > > >
> > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > >
> > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > >
> > > > a gentle reminder on this one.
> > > >
> > >
> > > Let me add my
> > >
> > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > >
> > > You didn't say who you expect to pick up the patch. I assume Mauro
> >
> > patch author now decides who takes the patch ? That's new :-)
Well, for patches that cross subsystem boundaries, like this one,
the best is to give a hint about whom you expect to pick it.
In this specific case, as commit 68a3c04 is in my tree, the best is
to merge the patch on it, as the patch may not even apply at Tony's
tree.
> >
> > > should take it because he took the patch that caused the problem,
> > > but he might not be aware that he should look at this now.
> >
> > He is in Cc, let's ask him :-)
>
> Best that this one goes in along with the other si4713 patches
> to avoid dependencies between trees:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Thanks! I'll merge it via my tree.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-12-04 17:00 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 21+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-04 17:00 UTC (permalink / raw)
To: linux-arm-kernel
Em Thu, 04 Dec 2014 08:39:31 -0800
Tony Lindgren <tony@atomide.com> escreveu:
> * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > Hi,
> >
> > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > so that si4713 could be easily used on DT boot, but
> > > > > it ended up introducing a build warning whenever
> > > > > si4713 isn't enabled.
> > > > >
> > > > > This patches fixes that warning:
> > > > >
> > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> > > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > >
> > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > >
> > > > a gentle reminder on this one.
> > > >
> > >
> > > Let me add my
> > >
> > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > >
> > > You didn't say who you expect to pick up the patch. I assume Mauro
> >
> > patch author now decides who takes the patch ? That's new :-)
Well, for patches that cross subsystem boundaries, like this one,
the best is to give a hint about whom you expect to pick it.
In this specific case, as commit 68a3c04 is in my tree, the best is
to merge the patch on it, as the patch may not even apply at Tony's
tree.
> >
> > > should take it because he took the patch that caused the problem,
> > > but he might not be aware that he should look at this now.
> >
> > He is in Cc, let's ask him :-)
>
> Best that this one goes in along with the other si4713 patches
> to avoid dependencies between trees:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Thanks! I'll merge it via my tree.
Regards,
Mauro
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-12-04 17:00 ` Mauro Carvalho Chehab
@ 2014-12-04 17:03 ` Felipe Balbi
-1 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:03 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Tony Lindgren, Felipe Balbi, Arnd Bergmann, linux-arm-kernel,
Sebastian Reichel, Hans Verkuil, Linux OMAP Mailing List
[-- Attachment #1: Type: text/plain, Size: 2586 bytes --]
Hi,
On Thu, Dec 04, 2014 at 03:00:12PM -0200, Mauro Carvalho Chehab wrote:
> Em Thu, 04 Dec 2014 08:39:31 -0800
> Tony Lindgren <tony@atomide.com> escreveu:
>
> > * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > > Hi,
> > >
> > > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > > so that si4713 could be easily used on DT boot, but
> > > > > > it ended up introducing a build warning whenever
> > > > > > si4713 isn't enabled.
> > > > > >
> > > > > > This patches fixes that warning:
> > > > > >
> > > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > > ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > >
> > > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > >
> > > > > a gentle reminder on this one.
> > > > >
> > > >
> > > > Let me add my
> > > >
> > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > You didn't say who you expect to pick up the patch. I assume Mauro
> > >
> > > patch author now decides who takes the patch ? That's new :-)
>
> Well, for patches that cross subsystem boundaries, like this one,
> the best is to give a hint about whom you expect to pick it.
>
> In this specific case, as commit 68a3c04 is in my tree, the best is
> to merge the patch on it, as the patch may not even apply at Tony's
> tree.
pointing to the commit that caused the problem really isn't enough ? The
commit short description (which is also on my commit log) clearly
mentions "[media]".
Anyway, I'll do that next time.
> > > > should take it because he took the patch that caused the problem,
> > > > but he might not be aware that he should look at this now.
> > >
> > > He is in Cc, let's ask him :-)
> >
> > Best that this one goes in along with the other si4713 patches
> > to avoid dependencies between trees:
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
>
> Thanks! I'll merge it via my tree.
tks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-12-04 17:03 ` Felipe Balbi
0 siblings, 0 replies; 21+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Thu, Dec 04, 2014 at 03:00:12PM -0200, Mauro Carvalho Chehab wrote:
> Em Thu, 04 Dec 2014 08:39:31 -0800
> Tony Lindgren <tony@atomide.com> escreveu:
>
> > * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > > Hi,
> > >
> > > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > > so that si4713 could be easily used on DT boot, but
> > > > > > it ended up introducing a build warning whenever
> > > > > > si4713 isn't enabled.
> > > > > >
> > > > > > This patches fixes that warning:
> > > > > >
> > > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > > ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> > > > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > >
> > > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > >
> > > > > a gentle reminder on this one.
> > > > >
> > > >
> > > > Let me add my
> > > >
> > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > You didn't say who you expect to pick up the patch. I assume Mauro
> > >
> > > patch author now decides who takes the patch ? That's new :-)
>
> Well, for patches that cross subsystem boundaries, like this one,
> the best is to give a hint about whom you expect to pick it.
>
> In this specific case, as commit 68a3c04 is in my tree, the best is
> to merge the patch on it, as the patch may not even apply at Tony's
> tree.
pointing to the commit that caused the problem really isn't enough ? The
commit short description (which is also on my commit log) clearly
mentions "[media]".
Anyway, I'll do that next time.
> > > > should take it because he took the patch that caused the problem,
> > > > but he might not be aware that he should look at this now.
> > >
> > > He is in Cc, let's ask him :-)
> >
> > Best that this one goes in along with the other si4713 patches
> > to avoid dependencies between trees:
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
>
> Thanks! I'll merge it via my tree.
tks
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/78c8be28/attachment.sig>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
2014-12-04 17:03 ` Felipe Balbi
@ 2014-12-04 17:12 ` Mauro Carvalho Chehab
-1 siblings, 0 replies; 21+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-04 17:12 UTC (permalink / raw)
To: Felipe Balbi
Cc: Tony Lindgren, Arnd Bergmann, linux-arm-kernel,
Sebastian Reichel, Hans Verkuil, Linux OMAP Mailing List
Em Thu, 04 Dec 2014 11:03:53 -0600
Felipe Balbi <balbi@ti.com> escreveu:
> Hi,
>
> On Thu, Dec 04, 2014 at 03:00:12PM -0200, Mauro Carvalho Chehab wrote:
> > Em Thu, 04 Dec 2014 08:39:31 -0800
> > Tony Lindgren <tony@atomide.com> escreveu:
> >
> > > * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > > > Hi,
> > > >
> > > > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > > > so that si4713 could be easily used on DT boot, but
> > > > > > > it ended up introducing a build warning whenever
> > > > > > > si4713 isn't enabled.
> > > > > > >
> > > > > > > This patches fixes that warning:
> > > > > > >
> > > > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > > > ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > > >
> > > > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > > >
> > > > > > a gentle reminder on this one.
> > > > > >
> > > > >
> > > > > Let me add my
> > > > >
> > > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > > >
> > > > > You didn't say who you expect to pick up the patch. I assume Mauro
> > > >
> > > > patch author now decides who takes the patch ? That's new :-)
> >
> > Well, for patches that cross subsystem boundaries, like this one,
> > the best is to give a hint about whom you expect to pick it.
> >
> > In this specific case, as commit 68a3c04 is in my tree, the best is
> > to merge the patch on it, as the patch may not even apply at Tony's
> > tree.
>
> pointing to the commit that caused the problem really isn't enough ? The
> commit short description (which is also on my commit log) clearly
> mentions "[media]".
>
> Anyway, I'll do that next time.
Ah, and please c/c linux-media ML next time, as I use patchwork there
to track patches for the media tree.
Thanks,
Mauro.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] arm: omap2: rx51-peripherals: fix build warning
@ 2014-12-04 17:12 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 21+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-04 17:12 UTC (permalink / raw)
To: linux-arm-kernel
Em Thu, 04 Dec 2014 11:03:53 -0600
Felipe Balbi <balbi@ti.com> escreveu:
> Hi,
>
> On Thu, Dec 04, 2014 at 03:00:12PM -0200, Mauro Carvalho Chehab wrote:
> > Em Thu, 04 Dec 2014 08:39:31 -0800
> > Tony Lindgren <tony@atomide.com> escreveu:
> >
> > > * Felipe Balbi <balbi@ti.com> [141204 07:50]:
> > > > Hi,
> > > >
> > > > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > > > so that si4713 could be easily used on DT boot, but
> > > > > > > it ended up introducing a build warning whenever
> > > > > > > si4713 isn't enabled.
> > > > > > >
> > > > > > > This patches fixes that warning:
> > > > > > >
> > > > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > > > ?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> > > > > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > > >
> > > > > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > > > >
> > > > > > a gentle reminder on this one.
> > > > > >
> > > > >
> > > > > Let me add my
> > > > >
> > > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > > >
> > > > > You didn't say who you expect to pick up the patch. I assume Mauro
> > > >
> > > > patch author now decides who takes the patch ? That's new :-)
> >
> > Well, for patches that cross subsystem boundaries, like this one,
> > the best is to give a hint about whom you expect to pick it.
> >
> > In this specific case, as commit 68a3c04 is in my tree, the best is
> > to merge the patch on it, as the patch may not even apply at Tony's
> > tree.
>
> pointing to the commit that caused the problem really isn't enough ? The
> commit short description (which is also on my commit log) clearly
> mentions "[media]".
>
> Anyway, I'll do that next time.
Ah, and please c/c linux-media ML next time, as I use patchwork there
to track patches for the media tree.
Thanks,
Mauro.
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2014-12-04 17:12 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-26 20:27 [PATCH] arm: omap2: rx51-peripherals: fix build warning Felipe Balbi
2014-11-26 20:27 ` Felipe Balbi
2014-11-26 20:27 ` Felipe Balbi
2014-11-26 21:56 ` Sebastian Reichel
2014-11-26 21:56 ` Sebastian Reichel
2014-11-27 7:41 ` Hans Verkuil
2014-11-27 7:41 ` Hans Verkuil
2014-12-04 15:24 ` Felipe Balbi
2014-12-04 15:24 ` Felipe Balbi
2014-12-04 15:41 ` Arnd Bergmann
2014-12-04 15:41 ` Arnd Bergmann
2014-12-04 15:48 ` Felipe Balbi
2014-12-04 15:48 ` Felipe Balbi
2014-12-04 16:39 ` Tony Lindgren
2014-12-04 16:39 ` Tony Lindgren
2014-12-04 17:00 ` Mauro Carvalho Chehab
2014-12-04 17:00 ` Mauro Carvalho Chehab
2014-12-04 17:03 ` Felipe Balbi
2014-12-04 17:03 ` Felipe Balbi
2014-12-04 17:12 ` Mauro Carvalho Chehab
2014-12-04 17:12 ` Mauro Carvalho Chehab
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.