All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tools/xenstore: fix link error with libsystemd
@ 2014-12-05 10:49 Olaf Hering
  2014-12-05 10:53 ` Ian Campbell
  0 siblings, 1 reply; 4+ messages in thread
From: Olaf Hering @ 2014-12-05 10:49 UTC (permalink / raw)
  To: xen-devel
  Cc: Olaf Hering, Wei Liu, Ian Campbell, Stefano Stabellini, Ian Jackson

Linking fails with undefined reference to the used systemd functions.
Move LDFLAGS after the object files to fix the failure.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/xenstore/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index bff9b25..11b6a06 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -74,10 +74,10 @@ endif
 init-xenstore-domain.o: CFLAGS += $(CFLAGS_libxenguest)
 
 init-xenstore-domain: init-xenstore-domain.o $(LIBXENSTORE)
-	$(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
 
 xenstored: $(XENSTORED_OBJS)
-	$(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
 
 xenstored.a: $(XENSTORED_OBJS)
 	$(AR) cr $@ $^
@@ -86,13 +86,13 @@ $(CLIENTS): xenstore
 	ln -f xenstore $@
 
 xenstore: xenstore_client.o $(LIBXENSTORE)
-	$(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
 
 xenstore-control: xenstore_control.o $(LIBXENSTORE)
-	$(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
+	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
 
 xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
-	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
+	$(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS)
 
 libxenstore.so: libxenstore.so.$(MAJOR)
 	ln -sf $< $@

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/xenstore: fix link error with libsystemd
  2014-12-05 10:49 [PATCH] tools/xenstore: fix link error with libsystemd Olaf Hering
@ 2014-12-05 10:53 ` Ian Campbell
  2014-12-05 17:19   ` Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2014-12-05 10:53 UTC (permalink / raw)
  To: Olaf Hering; +Cc: Wei Liu, Ian Jackson, Stefano Stabellini, xen-devel

On Fri, 2014-12-05 at 11:49 +0100, Olaf Hering wrote:
> Linking fails with undefined reference to the used systemd functions.
> Move LDFLAGS after the object files to fix the failure.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

This should go into 4.5.

FWIW my suspicion is that this relates to toolstacks using --as-needed
by default.

> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/xenstore/Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
> index bff9b25..11b6a06 100644
> --- a/tools/xenstore/Makefile
> +++ b/tools/xenstore/Makefile
> @@ -74,10 +74,10 @@ endif
>  init-xenstore-domain.o: CFLAGS += $(CFLAGS_libxenguest)
>  
>  init-xenstore-domain: init-xenstore-domain.o $(LIBXENSTORE)
> -	$(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
>  
>  xenstored: $(XENSTORED_OBJS)
> -	$(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
>  
>  xenstored.a: $(XENSTORED_OBJS)
>  	$(AR) cr $@ $^
> @@ -86,13 +86,13 @@ $(CLIENTS): xenstore
>  	ln -f xenstore $@
>  
>  xenstore: xenstore_client.o $(LIBXENSTORE)
> -	$(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
>  
>  xenstore-control: xenstore_control.o $(LIBXENSTORE)
> -	$(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
>  
>  xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
> -	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
> +	$(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS)
>  
>  libxenstore.so: libxenstore.so.$(MAJOR)
>  	ln -sf $< $@

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/xenstore: fix link error with libsystemd
  2014-12-05 10:53 ` Ian Campbell
@ 2014-12-05 17:19   ` Konrad Rzeszutek Wilk
  2014-12-09 15:06     ` Ian Campbell
  0 siblings, 1 reply; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2014-12-05 17:19 UTC (permalink / raw)
  To: Ian Campbell
  Cc: Wei Liu, Olaf Hering, Stefano Stabellini, Ian Jackson, xen-devel

On Fri, Dec 05, 2014 at 10:53:03AM +0000, Ian Campbell wrote:
> On Fri, 2014-12-05 at 11:49 +0100, Olaf Hering wrote:
> > Linking fails with undefined reference to the used systemd functions.
> > Move LDFLAGS after the object files to fix the failure.
> > 
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> This should go into 4.5.

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> FWIW my suspicion is that this relates to toolstacks using --as-needed
> by default.
> 
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > ---
> >  tools/xenstore/Makefile | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
> > index bff9b25..11b6a06 100644
> > --- a/tools/xenstore/Makefile
> > +++ b/tools/xenstore/Makefile
> > @@ -74,10 +74,10 @@ endif
> >  init-xenstore-domain.o: CFLAGS += $(CFLAGS_libxenguest)
> >  
> >  init-xenstore-domain: init-xenstore-domain.o $(LIBXENSTORE)
> > -	$(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
> > +	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)
> >  
> >  xenstored: $(XENSTORED_OBJS)
> > -	$(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> > +	$(CC) $^ $(LDFLAGS) $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> >  
> >  xenstored.a: $(XENSTORED_OBJS)
> >  	$(AR) cr $@ $^
> > @@ -86,13 +86,13 @@ $(CLIENTS): xenstore
> >  	ln -f xenstore $@
> >  
> >  xenstore: xenstore_client.o $(LIBXENSTORE)
> > -	$(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> > +	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> >  
> >  xenstore-control: xenstore_control.o $(LIBXENSTORE)
> > -	$(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> > +	$(CC) $< $(LDFLAGS) $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ $(APPEND_LDFLAGS)
> >  
> >  xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
> > -	$(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)
> > +	$(CC) $^ $(LDFLAGS) -o $@ $(APPEND_LDFLAGS)
> >  
> >  libxenstore.so: libxenstore.so.$(MAJOR)
> >  	ln -sf $< $@
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] tools/xenstore: fix link error with libsystemd
  2014-12-05 17:19   ` Konrad Rzeszutek Wilk
@ 2014-12-09 15:06     ` Ian Campbell
  0 siblings, 0 replies; 4+ messages in thread
From: Ian Campbell @ 2014-12-09 15:06 UTC (permalink / raw)
  To: Konrad Rzeszutek Wilk
  Cc: Wei Liu, Olaf Hering, Stefano Stabellini, Ian Jackson, xen-devel

On Fri, 2014-12-05 at 12:19 -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Dec 05, 2014 at 10:53:03AM +0000, Ian Campbell wrote:
> > On Fri, 2014-12-05 at 11:49 +0100, Olaf Hering wrote:
> > > Linking fails with undefined reference to the used systemd functions.
> > > Move LDFLAGS after the object files to fix the failure.
> > > 
> > > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > This should go into 4.5.
> 
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-09 15:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-05 10:49 [PATCH] tools/xenstore: fix link error with libsystemd Olaf Hering
2014-12-05 10:53 ` Ian Campbell
2014-12-05 17:19   ` Konrad Rzeszutek Wilk
2014-12-09 15:06     ` Ian Campbell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.