From: "Michael S. Tsirkin" <mst@redhat.com> To: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: thuth@linux.vnet.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0 Date: Tue, 9 Dec 2014 15:46:46 +0200 [thread overview] Message-ID: <20141209134646.GA6897@redhat.com> (raw) In-Reply-To: <1417525227-14051-15-git-send-email-cornelia.huck@de.ibm.com> On Tue, Dec 02, 2014 at 02:00:22PM +0100, Cornelia Huck wrote: > virtio-ccw should now have everything in place to operate virtio 1.0 > devices, so let's enable revision 1. > > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Looks like this will allow revision 1 for all devices, we only want this for virtio 1 devices. The following should fix it I think: Signed-off-by: Michael S. Tsirkin <mst@redhat.com> diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h index d40e3be..f5a1d3e 100644 --- a/hw/s390x/virtio-ccw.h +++ b/hw/s390x/virtio-ccw.h @@ -69,9 +69,6 @@ typedef struct VirtIOCCWDeviceClass { int (*exit)(VirtioCcwDevice *dev); } VirtIOCCWDeviceClass; -/* The maximum virtio revision we support. */ -#define VIRTIO_CCW_REV_MAX 1 - /* Performance improves when virtqueue kick processing is decoupled from the * vcpu thread using ioeventfd for some devices. */ #define VIRTIO_CCW_FLAG_USE_IOEVENTFD_BIT 1 @@ -104,6 +101,12 @@ struct VirtioCcwDevice { uint64_t ind_bit; }; +/* The maximum virtio revision we support. */ +static int virtio_ccw_rev_max(VirtioCcwDevice *dev) +{ + return dev->host_features & (1ULL << VIRTIO_F_VERSION_1) ? 1 : 0; +} + /* virtual css bus type */ typedef struct VirtualCssBus { BusState parent_obj; diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 3826074..922b021 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -693,7 +693,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) } cpu_physical_memory_read(ccw.cda, &revinfo, len); if (dev->revision >= 0 || - revinfo.revision > VIRTIO_CCW_REV_MAX) { + revinfo.revision > virtio_ccw_rev_max(dev)) { ret = -ENOSYS; break; }
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: thuth@linux.vnet.ibm.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [Qemu-devel] [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0 Date: Tue, 9 Dec 2014 15:46:46 +0200 [thread overview] Message-ID: <20141209134646.GA6897@redhat.com> (raw) In-Reply-To: <1417525227-14051-15-git-send-email-cornelia.huck@de.ibm.com> On Tue, Dec 02, 2014 at 02:00:22PM +0100, Cornelia Huck wrote: > virtio-ccw should now have everything in place to operate virtio 1.0 > devices, so let's enable revision 1. > > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Looks like this will allow revision 1 for all devices, we only want this for virtio 1 devices. The following should fix it I think: Signed-off-by: Michael S. Tsirkin <mst@redhat.com> diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h index d40e3be..f5a1d3e 100644 --- a/hw/s390x/virtio-ccw.h +++ b/hw/s390x/virtio-ccw.h @@ -69,9 +69,6 @@ typedef struct VirtIOCCWDeviceClass { int (*exit)(VirtioCcwDevice *dev); } VirtIOCCWDeviceClass; -/* The maximum virtio revision we support. */ -#define VIRTIO_CCW_REV_MAX 1 - /* Performance improves when virtqueue kick processing is decoupled from the * vcpu thread using ioeventfd for some devices. */ #define VIRTIO_CCW_FLAG_USE_IOEVENTFD_BIT 1 @@ -104,6 +101,12 @@ struct VirtioCcwDevice { uint64_t ind_bit; }; +/* The maximum virtio revision we support. */ +static int virtio_ccw_rev_max(VirtioCcwDevice *dev) +{ + return dev->host_features & (1ULL << VIRTIO_F_VERSION_1) ? 1 : 0; +} + /* virtual css bus type */ typedef struct VirtualCssBus { BusState parent_obj; diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 3826074..922b021 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -693,7 +693,7 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw) } cpu_physical_memory_read(ccw.cda, &revinfo, len); if (dev->revision >= 0 || - revinfo.revision > VIRTIO_CCW_REV_MAX) { + revinfo.revision > virtio_ccw_rev_max(dev)) { ret = -ENOSYS; break; }
next prev parent reply other threads:[~2014-12-09 13:46 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-12-02 13:00 [PATCH RFC v5 00/19] qemu: towards virtio-1 host support Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 01/19] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1 Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 02/19] virtio: cull virtio_bus_set_vdev_features Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 03/19] virtio: feature bit manipulation helpers Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 04/19] virtio: add feature checking helpers Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 05/19] virtio: support more feature bits Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-10 17:35 ` Cornelia Huck 2014-12-10 17:35 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 06/19] virtio: endianness checks for virtio 1.0 devices Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 07/19] virtio: allow virtio-1 queue layout Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 14:46 ` Michael S. Tsirkin 2014-12-02 14:46 ` [Qemu-devel] " Michael S. Tsirkin 2014-12-02 14:54 ` Cornelia Huck 2014-12-02 14:54 ` [Qemu-devel] " Cornelia Huck 2014-12-02 15:41 ` Cornelia Huck 2014-12-02 15:41 ` Cornelia Huck 2014-12-02 15:41 ` [Qemu-devel] " Cornelia Huck 2014-12-02 19:03 ` Michael S. Tsirkin 2014-12-02 19:03 ` [Qemu-devel] " Michael S. Tsirkin 2014-12-03 9:27 ` Cornelia Huck 2014-12-03 9:27 ` [Qemu-devel] " Cornelia Huck 2014-12-03 9:50 ` Cornelia Huck 2014-12-03 9:50 ` Cornelia Huck 2014-12-03 9:50 ` [Qemu-devel] " Cornelia Huck 2014-12-03 10:52 ` Michael S. Tsirkin 2014-12-03 10:52 ` [Qemu-devel] " Michael S. Tsirkin 2014-12-03 11:14 ` Cornelia Huck 2014-12-03 11:14 ` [Qemu-devel] " Cornelia Huck 2014-12-03 11:19 ` Michael S. Tsirkin 2014-12-03 11:19 ` [Qemu-devel] " Michael S. Tsirkin 2014-12-03 11:44 ` Cornelia Huck 2014-12-03 11:44 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 08/19] dataplane: allow virtio-1 devices Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 09/19] s390x/css: Add a callback for when subchannel gets disabled Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 10/19] s390x/virtio-ccw: add virtio set-revision call Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-04 16:20 ` Michael S. Tsirkin 2014-12-04 16:20 ` [Qemu-devel] " Michael S. Tsirkin 2014-12-04 16:43 ` Cornelia Huck 2014-12-04 16:43 ` [Qemu-devel] " Cornelia Huck 2014-12-04 16:20 ` Michael S. Tsirkin 2014-12-02 13:00 ` [PATCH RFC v5 11/19] s390x/virtio-ccw: support virtio-1 set_vq format Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 12/19] virtio: disallow late feature changes for virtio-1 Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 13/19] virtio: allow to fail setting status Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 14/19] s390x/virtio-ccw: enable virtio 1.0 Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-09 13:46 ` Michael S. Tsirkin [this message] 2014-12-09 13:46 ` Michael S. Tsirkin 2014-12-09 17:24 ` Cornelia Huck 2014-12-09 17:24 ` [Qemu-devel] " Cornelia Huck 2014-12-09 17:24 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 15/19] virtio-net: no writeable mac for virtio-1 Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 16/19] virtio-net: support longer header Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 17/19] virtio-net: enable virtio 1.0 Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 18/19] virtio: support revision-specific features Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-10 17:37 ` Cornelia Huck 2014-12-10 17:37 ` Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck 2014-12-02 13:00 ` [PATCH RFC v5 19/19] virtio-blk: revision specific feature bits Cornelia Huck 2014-12-02 13:00 ` [Qemu-devel] " Cornelia Huck 2014-12-02 13:00 ` Cornelia Huck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20141209134646.GA6897@redhat.com \ --to=mst@redhat.com \ --cc=cornelia.huck@de.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=qemu-devel@nongnu.org \ --cc=thuth@linux.vnet.ibm.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.