* Re: [PATCH net] be2net: Fix incorrect setting of tunnel offload flag in netdev features
2014-12-19 4:30 [PATCH net] be2net: Fix incorrect setting of tunnel offload flag in netdev features Sriharsha Basavapatna
@ 2014-12-18 17:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-12-18 17:51 UTC (permalink / raw)
To: sriharsha.basavapatna; +Cc: netdev
From: Sriharsha Basavapatna <sriharsha.basavapatna@emulex.com>
Date: Fri, 19 Dec 2014 10:00:18 +0530
> An earlier commit to resolve an issue with encapsulation offloads missed
> setting a bit in the outer netdev features flag. This results in loss of TSO
> feature on a VxLAN interface.
>
> Fixes: 630f4b70 ("Export tunnel offloads only when a VxLAN tunnel is created")
>
> Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@emulex.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH net] be2net: Fix incorrect setting of tunnel offload flag in netdev features
@ 2014-12-19 4:30 Sriharsha Basavapatna
2014-12-18 17:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sriharsha Basavapatna @ 2014-12-19 4:30 UTC (permalink / raw)
To: netdev
An earlier commit to resolve an issue with encapsulation offloads missed
setting a bit in the outer netdev features flag. This results in loss of TSO
feature on a VxLAN interface.
Fixes: 630f4b70 ("Export tunnel offloads only when a VxLAN tunnel is created")
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@emulex.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 2aacd47..1960731 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3138,6 +3138,7 @@ static void be_disable_vxlan_offloads(struct be_adapter *adapter)
netdev->hw_enc_features = 0;
netdev->hw_features &= ~(NETIF_F_GSO_UDP_TUNNEL);
+ netdev->features &= ~(NETIF_F_GSO_UDP_TUNNEL);
}
#endif
@@ -4429,6 +4430,7 @@ static void be_add_vxlan_port(struct net_device *netdev, sa_family_t sa_family,
NETIF_F_TSO | NETIF_F_TSO6 |
NETIF_F_GSO_UDP_TUNNEL;
netdev->hw_features |= NETIF_F_GSO_UDP_TUNNEL;
+ netdev->features |= NETIF_F_GSO_UDP_TUNNEL;
dev_info(dev, "Enabled VxLAN offloads for UDP port %d\n",
be16_to_cpu(port));
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-18 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-19 4:30 [PATCH net] be2net: Fix incorrect setting of tunnel offload flag in netdev features Sriharsha Basavapatna
2014-12-18 17:51 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.