* [PATCH 02/24] Add number of nodes to bitmap structure for clustering
@ 2014-12-18 16:15 Goldwyn Rodrigues
2015-02-23 1:38 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Goldwyn Rodrigues @ 2014-12-18 16:15 UTC (permalink / raw)
To: neilb; +Cc: lzhong, linux-raid
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
drivers/md/bitmap.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bitmap.h b/drivers/md/bitmap.h
index 30210b9..6872945 100644
--- a/drivers/md/bitmap.h
+++ b/drivers/md/bitmap.h
@@ -128,10 +128,11 @@ typedef struct bitmap_super_s {
__le32 chunksize; /* 52 the bitmap chunk size in bytes */
__le32 daemon_sleep; /* 56 seconds between disk flushes */
__le32 write_behind; /* 60 number of outstanding write-behind writes */
- __le32 sectors_reserved; /* 64 number of 512-byte sectors that are
+ __le32 nodes; /* 64 the maximum number of nodes in cluster. */
+ __le32 sectors_reserved; /* 68 number of 512-byte sectors that are
* reserved for the bitmap. */
- __u8 pad[256 - 68]; /* set to zero */
+ __u8 pad[256 - 72]; /* set to zero */
} bitmap_super_t;
/* notes:
--
2.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 02/24] Add number of nodes to bitmap structure for clustering
2014-12-18 16:15 [PATCH 02/24] Add number of nodes to bitmap structure for clustering Goldwyn Rodrigues
@ 2015-02-23 1:38 ` NeilBrown
2015-02-23 18:13 ` Goldwyn Rodrigues
0 siblings, 1 reply; 3+ messages in thread
From: NeilBrown @ 2015-02-23 1:38 UTC (permalink / raw)
To: Goldwyn Rodrigues; +Cc: lzhong, linux-raid
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
On Thu, 18 Dec 2014 10:15:23 -0600 Goldwyn Rodrigues <rgoldwyn@suse.de> wrote:
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
> drivers/md/bitmap.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/bitmap.h b/drivers/md/bitmap.h
> index 30210b9..6872945 100644
> --- a/drivers/md/bitmap.h
> +++ b/drivers/md/bitmap.h
> @@ -128,10 +128,11 @@ typedef struct bitmap_super_s {
> __le32 chunksize; /* 52 the bitmap chunk size in bytes */
> __le32 daemon_sleep; /* 56 seconds between disk flushes */
> __le32 write_behind; /* 60 number of outstanding write-behind writes */
> - __le32 sectors_reserved; /* 64 number of 512-byte sectors that are
> + __le32 nodes; /* 64 the maximum number of nodes in cluster. */
> + __le32 sectors_reserved; /* 68 number of 512-byte sectors that are
> * reserved for the bitmap. */
>
> - __u8 pad[256 - 68]; /* set to zero */
> + __u8 pad[256 - 72]; /* set to zero */
> } bitmap_super_t;
>
> /* notes:
Hi Goldwyn,
I was reviewing you latest series to make sure it wouldn't affect the
non-clustered use case at all, and I found this. I really should have
noticed it earlier....
You are changing the location of 'sectors_reserved' in the bitmap superblock.
That obviously cannot be allowed - new fields must always be added to the
end.
Can you update the series in git to fix that please? Then I will pull it in
for -next.
Thanks,
NeilBrown
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 02/24] Add number of nodes to bitmap structure for clustering
2015-02-23 1:38 ` NeilBrown
@ 2015-02-23 18:13 ` Goldwyn Rodrigues
0 siblings, 0 replies; 3+ messages in thread
From: Goldwyn Rodrigues @ 2015-02-23 18:13 UTC (permalink / raw)
To: NeilBrown; +Cc: lzhong, linux-raid
Hi Neil,
On 02/22/2015 07:38 PM, NeilBrown wrote:
> On Thu, 18 Dec 2014 10:15:23 -0600 Goldwyn Rodrigues <rgoldwyn@suse.de> wrote:
>
>> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>> ---
>> drivers/md/bitmap.h | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/bitmap.h b/drivers/md/bitmap.h
>> index 30210b9..6872945 100644
>> --- a/drivers/md/bitmap.h
>> +++ b/drivers/md/bitmap.h
>> @@ -128,10 +128,11 @@ typedef struct bitmap_super_s {
>> __le32 chunksize; /* 52 the bitmap chunk size in bytes */
>> __le32 daemon_sleep; /* 56 seconds between disk flushes */
>> __le32 write_behind; /* 60 number of outstanding write-behind writes */
>> - __le32 sectors_reserved; /* 64 number of 512-byte sectors that are
>> + __le32 nodes; /* 64 the maximum number of nodes in cluster. */
>> + __le32 sectors_reserved; /* 68 number of 512-byte sectors that are
>> * reserved for the bitmap. */
>>
>> - __u8 pad[256 - 68]; /* set to zero */
>> + __u8 pad[256 - 72]; /* set to zero */
>> } bitmap_super_t;
>>
>> /* notes:
>
> Hi Goldwyn,
> I was reviewing you latest series to make sure it wouldn't affect the
> non-clustered use case at all, and I found this. I really should have
> noticed it earlier....
>
> You are changing the location of 'sectors_reserved' in the bitmap superblock.
> That obviously cannot be allowed - new fields must always be added to the
> end.
Oops. Sorry.
>
> Can you update the series in git to fix that please? Then I will pull it in
> for -next.
I have done this and re-tested. However, I also rebased against
upstream. There were some conflicts with respect to md_personality. I
have re-done those patches, but it would be worth a second look. The one
which may need special review attention is "bitmap_create returns bitmap
pointer"
Regards,
--
Goldwyn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-23 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-18 16:15 [PATCH 02/24] Add number of nodes to bitmap structure for clustering Goldwyn Rodrigues
2015-02-23 1:38 ` NeilBrown
2015-02-23 18:13 ` Goldwyn Rodrigues
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.