All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: comedi: dmm32at: fix style issues
@ 2014-12-25 20:28 David Decotigny
  2014-12-27  7:00 ` Sudip Mukherjee
  2014-12-30 22:15 ` Ian Abbott
  0 siblings, 2 replies; 5+ messages in thread
From: David Decotigny @ 2014-12-25 20:28 UTC (permalink / raw)
  To: Greg Kroah-Hartman, devel, linux-kernel
  Cc: Jeremiah Mahler, Ian Abbott, H Hartley Sweeten, David Decotigny

Before:
      1 ERROR: code indent should use tabs where possible
      1 WARNING: please, no spaces at the start of a line

After:
  (none)

Signed-off-by: David Decotigny <ddecotig@gmail.com>
---
 drivers/staging/comedi/drivers/dmm32at.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
index 6df298a..31919b8 100644
--- a/drivers/staging/comedi/drivers/dmm32at.c
+++ b/drivers/staging/comedi/drivers/dmm32at.c
@@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
 	/* enable the ai conversion interrupt and the clock to start scans */
 	outb(DMM32AT_INTCLK_ADINT |
 	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
-             dev->iobase + DMM32AT_INTCLK_REG);
+	     dev->iobase + DMM32AT_INTCLK_REG);
 }
 
 static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
-- 
2.2.0.rc0.207.ga3a616c


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: comedi: dmm32at: fix style issues
  2014-12-25 20:28 [PATCH v2] staging: comedi: dmm32at: fix style issues David Decotigny
@ 2014-12-27  7:00 ` Sudip Mukherjee
  2014-12-29 23:18   ` David Decotigny
       [not found]   ` <CAG88wWZjqr8U=TtSaTGHnn=05d2QFQ3en7ndeK2sPq+-PFT=0w@mail.gmail.com>
  2014-12-30 22:15 ` Ian Abbott
  1 sibling, 2 replies; 5+ messages in thread
From: Sudip Mukherjee @ 2014-12-27  7:00 UTC (permalink / raw)
  To: David Decotigny
  Cc: Greg Kroah-Hartman, devel, linux-kernel, Jeremiah Mahler,
	Ian Abbott, H Hartley Sweeten

On Thu, Dec 25, 2014 at 12:28:28PM -0800, David Decotigny wrote:
> Before:
>       1 ERROR: code indent should use tabs where possible
>       1 WARNING: please, no spaces at the start of a line
> 
> After:
>   (none)
> 
> Signed-off-by: David Decotigny <ddecotig@gmail.com>
> ---
>  drivers/staging/comedi/drivers/dmm32at.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..31919b8 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>  	/* enable the ai conversion interrupt and the clock to start scans */
>  	outb(DMM32AT_INTCLK_ADINT |
>  	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +	     dev->iobase + DMM32AT_INTCLK_REG);

another suggestion:
if you do like the following patch (use 2 tabs) then you do not need to give spaces to indent the code.

diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
index 6df298a..cedf8ed 100644
--- a/drivers/staging/comedi/drivers/dmm32at.c
+++ b/drivers/staging/comedi/drivers/dmm32at.c
@@ -364,8 +364,8 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)

	/* enable the ai conversion interrupt and the clock to start scans */
	 outb(DMM32AT_INTCLK_ADINT |
-            DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
-             dev->iobase + DMM32AT_INTCLK_REG);
+		DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
+		dev->iobase + DMM32AT_INTCLK_REG);
 }

 static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)

	
thanks
sudip

>  }
>  
>  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> -- 
> 2.2.0.rc0.207.ga3a616c
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: comedi: dmm32at: fix style issues
  2014-12-27  7:00 ` Sudip Mukherjee
@ 2014-12-29 23:18   ` David Decotigny
       [not found]   ` <CAG88wWZjqr8U=TtSaTGHnn=05d2QFQ3en7ndeK2sPq+-PFT=0w@mail.gmail.com>
  1 sibling, 0 replies; 5+ messages in thread
From: David Decotigny @ 2014-12-29 23:18 UTC (permalink / raw)
  To: linux-kernel

thanks! I have a preference for the v2 I sent: my $EDITOR handles the
indentation for me; using 2 tabs forces me to manually override my
editor's behavior. But if there is a strong push for a v3 of this
patch with 2 tabs instead of current v2 indentation, I'll do it,
please let me know.

On Fri, Dec 26, 2014 at 11:00 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Thu, Dec 25, 2014 at 12:28:28PM -0800, David Decotigny wrote:
>> Before:
>>       1 ERROR: code indent should use tabs where possible
>>       1 WARNING: please, no spaces at the start of a line
>>
>> After:
>>   (none)
>>
>> Signed-off-by: David Decotigny <ddecotig@gmail.com>
>> ---
>>  drivers/staging/comedi/drivers/dmm32at.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
>> index 6df298a..31919b8 100644
>> --- a/drivers/staging/comedi/drivers/dmm32at.c
>> +++ b/drivers/staging/comedi/drivers/dmm32at.c
>> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>>       /* enable the ai conversion interrupt and the clock to start scans */
>>       outb(DMM32AT_INTCLK_ADINT |
>>            DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
>> -             dev->iobase + DMM32AT_INTCLK_REG);
>> +          dev->iobase + DMM32AT_INTCLK_REG);
>
> another suggestion:
> if you do like the following patch (use 2 tabs) then you do not need to give spaces to indent the code.
>
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..cedf8ed 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -364,8 +364,8 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>
>         /* enable the ai conversion interrupt and the clock to start scans */
>          outb(DMM32AT_INTCLK_ADINT |
> -            DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +               DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> +               dev->iobase + DMM32AT_INTCLK_REG);
>  }
>
>  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>
>
> thanks
> sudip
>
>>  }
>>
>>  static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>> --
>> 2.2.0.rc0.207.ga3a616c
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: comedi: dmm32at: fix style issues
       [not found]   ` <CAG88wWZjqr8U=TtSaTGHnn=05d2QFQ3en7ndeK2sPq+-PFT=0w@mail.gmail.com>
@ 2014-12-30  6:25     ` Sudip Mukherjee
  0 siblings, 0 replies; 5+ messages in thread
From: Sudip Mukherjee @ 2014-12-30  6:25 UTC (permalink / raw)
  To: David Decotigny
  Cc: Greg Kroah-Hartman, devel, linux-kernel, Jeremiah Mahler,
	Ian Abbott, H Hartley Sweeten

On Mon, Dec 29, 2014 at 03:12:53PM -0800, David Decotigny wrote:
> thanks! I have a preference for the v2 I sent: my $EDITOR handles the
> indentation for me; using 2 tabs forces me to manually override my editor's
> behavior. But if there is a strong push for a v3 of this patch with 2 tabs
> instead of current v2 indentation, I'll do it, please let me know.

well, if you check CodingStyle in Documentation, it clearly says: 
"Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation".

Sudip

> 
> On Fri, Dec 26, 2014 at 11:00 PM, Sudip Mukherjee <
> sudipm.mukherjee@gmail.com> wrote:
> 
> > On Thu, Dec 25, 2014 at 12:28:28PM -0800, David Decotigny wrote:
> > > Before:
> > >       1 ERROR: code indent should use tabs where possible
> > >       1 WARNING: please, no spaces at the start of a line
> > >
> > > After:
> > >   (none)
> > >
> > > Signed-off-by: David Decotigny <ddecotig@gmail.com>
> > > ---
> > >  drivers/staging/comedi/drivers/dmm32at.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/comedi/drivers/dmm32at.c
> > b/drivers/staging/comedi/drivers/dmm32at.c
> > > index 6df298a..31919b8 100644
> > > --- a/drivers/staging/comedi/drivers/dmm32at.c
> > > +++ b/drivers/staging/comedi/drivers/dmm32at.c
> > > @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device
> > *dev, unsigned int nansec)
> > >       /* enable the ai conversion interrupt and the clock to start scans
> > */
> > >       outb(DMM32AT_INTCLK_ADINT |
> > >            DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> > > -             dev->iobase + DMM32AT_INTCLK_REG);
> > > +          dev->iobase + DMM32AT_INTCLK_REG);
> >
> > another suggestion:
> > if you do like the following patch (use 2 tabs) then you do not need to
> > give spaces to indent the code.
> >
> > diff --git a/drivers/staging/comedi/drivers/dmm32at.c
> > b/drivers/staging/comedi/drivers/dmm32at.c
> > index 6df298a..cedf8ed 100644
> > --- a/drivers/staging/comedi/drivers/dmm32at.c
> > +++ b/drivers/staging/comedi/drivers/dmm32at.c
> > @@ -364,8 +364,8 @@ static void dmm32at_setaitimer(struct comedi_device
> > *dev, unsigned int nansec)
> >
> >         /* enable the ai conversion interrupt and the clock to start scans
> > */
> >          outb(DMM32AT_INTCLK_ADINT |
> > -            DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> > -             dev->iobase + DMM32AT_INTCLK_REG);
> > +               DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> > +               dev->iobase + DMM32AT_INTCLK_REG);
> >  }
> >
> >  static int dmm32at_ai_cmd(struct comedi_device *dev, struct
> > comedi_subdevice *s)
> >
> >
> > thanks
> > sudip
> >
> > >  }
> > >
> > >  static int dmm32at_ai_cmd(struct comedi_device *dev, struct
> > comedi_subdevice *s)
> > > --
> > > 2.2.0.rc0.207.ga3a616c
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> > in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at  http://www.tux.org/lkml/
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: comedi: dmm32at: fix style issues
  2014-12-25 20:28 [PATCH v2] staging: comedi: dmm32at: fix style issues David Decotigny
  2014-12-27  7:00 ` Sudip Mukherjee
@ 2014-12-30 22:15 ` Ian Abbott
  1 sibling, 0 replies; 5+ messages in thread
From: Ian Abbott @ 2014-12-30 22:15 UTC (permalink / raw)
  To: David Decotigny, Greg Kroah-Hartman, devel, linux-kernel
  Cc: Jeremiah Mahler, H Hartley Sweeten

On 25/12/14 20:28, David Decotigny wrote:
> Before:
>        1 ERROR: code indent should use tabs where possible
>        1 WARNING: please, no spaces at the start of a line
>
> After:
>    (none)
>
> Signed-off-by: David Decotigny <ddecotig@gmail.com>
> ---
>   drivers/staging/comedi/drivers/dmm32at.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..31919b8 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
>   	/* enable the ai conversion interrupt and the clock to start scans */
>   	outb(DMM32AT_INTCLK_ADINT |
>   	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> -             dev->iobase + DMM32AT_INTCLK_REG);
> +	     dev->iobase + DMM32AT_INTCLK_REG);
>   }
>
>   static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-30 22:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-25 20:28 [PATCH v2] staging: comedi: dmm32at: fix style issues David Decotigny
2014-12-27  7:00 ` Sudip Mukherjee
2014-12-29 23:18   ` David Decotigny
     [not found]   ` <CAG88wWZjqr8U=TtSaTGHnn=05d2QFQ3en7ndeK2sPq+-PFT=0w@mail.gmail.com>
2014-12-30  6:25     ` Sudip Mukherjee
2014-12-30 22:15 ` Ian Abbott

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.