All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kumagai-atsushi@mxc.nes.nec.co.jp,
	HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
	kexec@lists.infradead.org, ebiederm@xmission.com,
	anderson@redhat.com
Subject: Re: [PATCH v2] kdump, vmcoreinfo: report actual value of phys_base
Date: Fri, 2 Jan 2015 08:42:40 -0500	[thread overview]
Message-ID: <20150102134240.GD18785@redhat.com> (raw)
In-Reply-To: <20141215151120.b44112413e15a8c390d39147@linux-foundation.org>

On Mon, Dec 15, 2014 at 03:11:20PM -0800, Andrew Morton wrote:
> 
> (cc trimmed a bit)
> 
> On Thu, 13 Nov 2014 11:30:11 +0900 (JST) HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:
> 
> > Currently, VMCOREINFO note information reports the virtual address of
> > phys_base that is assigned to symbol phys_base. But this doesn't make
> > sense because to refer to phys_base, it's necessary to get the value
> > of phys_base itself we are now about to refer to.
> 
> Folks, could we please get a bit of reviewing, acking or nacking for
> this one?

To me this patch is more like a hack or a quick fix to get dump filtering
working when dump is generated using virsh-dump like tools. I feel there
should be discussion on what's the proper way to do this. I don't have
very specific ideas though at this point of time.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2015-01-02 13:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13  2:30 [PATCH v2] kdump, vmcoreinfo: report actual value of phys_base HATAYAMA Daisuke
2014-11-13  2:30 ` HATAYAMA Daisuke
2014-12-15 23:11 ` Andrew Morton
2015-01-02 13:42   ` Vivek Goyal [this message]
2015-01-05  8:49     ` Petr Tesarik
2014-12-19  2:39 ` Baoquan He
2014-12-19  2:39   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150102134240.GD18785@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=anderson@redhat.com \
    --cc=d.hatayama@jp.fujitsu.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.