All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
To: Stephan Mueller <smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org>
Cc: Daniel Borkmann
	<dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	'Quentin Gouchet'
	<quentin.gouchet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ABI/API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support
Date: Mon, 5 Jan 2015 21:31:59 +1100	[thread overview]
Message-ID: <20150105103159.GA24878@gondor.apana.org.au> (raw)
In-Reply-To: <1609020.xcc11L81HZ-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org>

On Fri, Jan 02, 2015 at 03:41:33PM +0100, Stephan Mueller wrote:
>
> +		if (!con.aead_assoclen)
> +			return -EINVAL;

AD being zero should be fine.

> +		/* aead_recvmsg limits the maximum AD size to one page */
> +		if (con.aead_assoclen > PAGE_SIZE)
> +			return -E2BIG;

I don't see any need to limit the size of the AD.

Cheers,
-- 
Email: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: Daniel Borkmann <dborkman@redhat.com>,
	"'Quentin Gouchet'" <quentin.gouchet@gmail.com>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	ABI/API <linux-api@vger.kernel.org>
Subject: Re: [PATCH v7 1/2] crypto: AF_ALG: add AEAD support
Date: Mon, 5 Jan 2015 21:31:59 +1100	[thread overview]
Message-ID: <20150105103159.GA24878@gondor.apana.org.au> (raw)
In-Reply-To: <1609020.xcc11L81HZ@tachyon.chronox.de>

On Fri, Jan 02, 2015 at 03:41:33PM +0100, Stephan Mueller wrote:
>
> +		if (!con.aead_assoclen)
> +			return -EINVAL;

AD being zero should be fine.

> +		/* aead_recvmsg limits the maximum AD size to one page */
> +		if (con.aead_assoclen > PAGE_SIZE)
> +			return -E2BIG;

I don't see any need to limit the size of the AD.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  parent reply	other threads:[~2015-01-05 10:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02 14:40 [PATCH v7 0/2] crypto: AF_ALG: add AEAD and RNG support Stephan Mueller
2015-01-02 14:40 ` Stephan Mueller
2015-01-02 14:41 ` [PATCH v7 1/2] crypto: AF_ALG: add AEAD support Stephan Mueller
     [not found]   ` <1609020.xcc11L81HZ-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org>
2015-01-05 10:31     ` Herbert Xu [this message]
2015-01-05 10:31       ` Herbert Xu
     [not found]       ` <20150105103159.GA24878-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-01-05 10:46         ` Stephan Mueller
2015-01-05 10:46           ` Stephan Mueller
     [not found]           ` <6798882.ly1QjqTYep-PJstQz4BMNNP20K/wil9xYQuADTiUCJX@public.gmane.org>
2015-01-05 10:51             ` Herbert Xu
2015-01-05 10:51               ` Herbert Xu
2015-01-05 10:54               ` Stephan Mueller
     [not found]               ` <20150105105105.GA25517-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-01-05 11:14                 ` Stephan Mueller
2015-01-05 11:14                   ` Stephan Mueller
2015-01-02 14:42 ` [PATCH v7 2/2] crypto: AF_ALG: enable AEAD interface compilation Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105103159.GA24878@gondor.apana.org.au \
    --to=herbert-loam2ak0srrlbo1qdeomrrpzq4s04n8q@public.gmane.org \
    --cc=dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=quentin.gouchet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.