All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Include i915_gem_evict.c kerneldoc into the drm docbook
@ 2015-01-05 13:37 Daniel Vetter
  2015-01-05 23:44 ` shuang.he
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2015-01-05 13:37 UTC (permalink / raw)
  To: Intel Graphics Development; +Cc: Daniel Vetter, Daniel Vetter

I've written these long before we've had a reasonable docbook
structure, and naturally they've gone stale. Fix this up asap.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/DocBook/drm.tmpl        | 11 +++++++++++
 drivers/gpu/drm/i915/i915_gem_evict.c |  8 ++++----
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index bd1456ad8460..38f7ef3933c4 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -4048,6 +4048,17 @@ int num_ioctls;</synopsis>
 !Pdrivers/gpu/drm/i915/i915_gem_gtt.c Global GTT views
 !Idrivers/gpu/drm/i915/i915_gem_gtt.c
       </sect2>
+      <sect2>
+        <title>Buffer Object Eviction</title>
+	<para>
+	  This section documents the interface function for evicting buffer
+	  objects to make space available in the virtual gpu address spaces.
+	  Note that this is mostly orthogonal to shrinking buffer objects
+	  caches, which has the goal to make main memory (shared with the gpu
+	  through the unified memory architecture) available.
+	</para>
+!Idrivers/gpu/drm/i915/i915_gem_evict.c
+      </sect2>
     </sect1>
 
     <sect1>
diff --git a/drivers/gpu/drm/i915/i915_gem_evict.c b/drivers/gpu/drm/i915/i915_gem_evict.c
index 886ff2ee7a28..d104c9120c4d 100644
--- a/drivers/gpu/drm/i915/i915_gem_evict.c
+++ b/drivers/gpu/drm/i915/i915_gem_evict.c
@@ -50,11 +50,12 @@ mark_free(struct i915_vma *vma, struct list_head *unwind)
  * i915_gem_evict_something - Evict vmas to make room for binding a new one
  * @dev: drm_device
  * @vm: address space to evict from
- * @size: size of the desired free space
+ * @min_size: size of the desired free space
  * @alignment: alignment constraint of the desired free space
  * @cache_level: cache_level for the desired space
- * @mappable: whether the free space must be mappable
- * @nonblocking: whether evicting active objects is allowed or not
+ * @start: start (inclusive) of the range from which to evict objects
+ * @end: end (exclusive) of the range from which to evict objects
+ * @flags: additional flags to control the eviction algorithm
  *
  * This function will try to evict vmas until a free space satisfying the
  * requirements is found. Callers must check first whether any such hole exists
@@ -196,7 +197,6 @@ found:
 
 /**
  * i915_gem_evict_vm - Evict all idle vmas from a vm
- *
  * @vm: Address space to cleanse
  * @do_idle: Boolean directing whether to idle first.
  *
-- 
2.1.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915: Include i915_gem_evict.c kerneldoc into the drm docbook
  2015-01-05 13:37 [PATCH] drm/i915: Include i915_gem_evict.c kerneldoc into the drm docbook Daniel Vetter
@ 2015-01-05 23:44 ` shuang.he
  2015-01-06  8:25   ` Daniel Vetter
  0 siblings, 1 reply; 3+ messages in thread
From: shuang.he @ 2015-01-05 23:44 UTC (permalink / raw)
  To: shuang.he, intel-gfx, daniel.vetter

Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
-------------------------------------Summary-------------------------------------
Platform          Delta          drm-intel-nightly          Series Applied
PNV                                  363/364              363/364
ILK                 -18              364/366              346/366
SNB              +4-23              443/450              424/450
IVB                                  496/498              496/498
BYT                                  288/289              288/289
HSW              +3-2              542/564              543/564
BDW                                  415/417              415/417
-------------------------------------Detailed-------------------------------------
Platform  Test                                drm-intel-nightly          Series Applied
 ILK  igt_kms_flip_nonexisting-fb      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_rcs-flip-vs-panning-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_rcs-wf_vblank-vs-dpms-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_render_direct-render      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_bcs-flip-vs-modeset-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_blocking-absolute-wf_vblank-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_busy-flip-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_flip-vs-dpms-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_flip-vs-panning      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_flip-vs-rmfb-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_plain-flip-fb-recreate-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_plain-flip-ts-check-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_rcs-flip-vs-dpms      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_rcs-flip-vs-modeset      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_rcs-flip-vs-panning      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_vblank-vs-hang      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_wf_vblank-ts-check      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 ILK  igt_kms_flip_wf_vblank-vs-modeset-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
 SNB  igt_kms_cursor_crc_cursor-size-change      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_kms_flip_dpms-vs-vblank-race      DMESG_WARN(2, M35M22)PASS(1, M35)      PASS(1, M35)
 SNB  igt_kms_flip_dpms-vs-vblank-race-interruptible      DMESG_WARN(2, M35M22)PASS(1, M35)      PASS(1, M35)
 SNB  igt_kms_flip_event_leak      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_kms_flip_modeset-vs-vblank-race      DMESG_WARN(3, M35)PASS(1, M35)      PASS(1, M35)
*SNB  igt_kms_flip_tiling_flip-changes-tiling      PASS(2, M35)      TIMEOUT(1, M35)
 SNB  igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_kms_mmio_vs_cs_flip_setplane_vs_cs_flip      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_kms_plane_plane-position-hole-pipe-B-plane-1      DMESG_WARN(1, M35)PASS(4, M35M22)      PASS(1, M35)
 SNB  igt_kms_rotation_crc_primary-rotation      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_kms_rotation_crc_sprite-rotation      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_cursor      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_cursor-dpms      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_dpms-mode-unset-non-lpsp      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_dpms-non-lpsp      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_drm-resources-equal      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_fences      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_fences-dpms      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_gem-execbuf      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_gem-mmap-cpu      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_gem-mmap-gtt      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_gem-pread      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_i2c      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_modeset-non-lpsp      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_pci-d3-state      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 SNB  igt_pm_rpm_rte      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
 HSW  igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset      DMESG_WARN(1, M40)PASS(4, M40M19)      DMESG_WARN(1, M40)
*HSW  igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset-interruptible      DMESG_WARN(2, M40)PASS(1, M19)      PASS(1, M40)
 HSW  igt_kms_plane_plane-panning-bottom-right-pipe-C-plane-1      TIMEOUT(3, M40)PASS(2, M19M40)      PASS(1, M40)
*HSW  igt_kms_plane_plane-panning-top-left-pipe-C-plane-2      PASS(2, M40)      DMESG_FAIL(1, M40)
 HSW  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(1, M19)DMESG_WARN(1, M40)PASS(3, M40)      PASS(1, M40)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915: Include i915_gem_evict.c kerneldoc into the drm docbook
  2015-01-05 23:44 ` shuang.he
@ 2015-01-06  8:25   ` Daniel Vetter
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2015-01-06  8:25 UTC (permalink / raw)
  To: shuang.he; +Cc: daniel.vetter, intel-gfx

On Mon, Jan 05, 2015 at 03:44:08PM -0800, shuang.he@intel.com wrote:
> Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
> -------------------------------------Summary-------------------------------------
> Platform          Delta          drm-intel-nightly          Series Applied
> PNV                                  363/364              363/364
> ILK                 -18              364/366              346/366
> SNB              +4-23              443/450              424/450
> IVB                                  496/498              496/498
> BYT                                  288/289              288/289
> HSW              +3-2              542/564              543/564
> BDW                                  415/417              415/417

This kind of report is a perfect example of why prts results aren't too
useful: The patch _only_ changes comments (for kerneldoc), so shouldn't
have any impact at all on the resulting binary. Still prts somehow detects
massive ammounts of changes.

He Shuang, can you please digg into this?

Thanks, Daniel

> -------------------------------------Detailed-------------------------------------
> Platform  Test                                drm-intel-nightly          Series Applied
>  ILK  igt_kms_flip_nonexisting-fb      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_rcs-flip-vs-panning-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_rcs-wf_vblank-vs-dpms-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_render_direct-render      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_bcs-flip-vs-modeset-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_blocking-absolute-wf_vblank-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_busy-flip-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_flip-vs-dpms-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_flip-vs-panning      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_flip-vs-rmfb-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_plain-flip-fb-recreate-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_plain-flip-ts-check-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_rcs-flip-vs-dpms      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_rcs-flip-vs-modeset      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_rcs-flip-vs-panning      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_vblank-vs-hang      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_wf_vblank-ts-check      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  ILK  igt_kms_flip_wf_vblank-vs-modeset-interruptible      DMESG_WARN(2, M26)PASS(1, M37)      DMESG_WARN(1, M26)
>  SNB  igt_kms_cursor_crc_cursor-size-change      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_kms_flip_dpms-vs-vblank-race      DMESG_WARN(2, M35M22)PASS(1, M35)      PASS(1, M35)
>  SNB  igt_kms_flip_dpms-vs-vblank-race-interruptible      DMESG_WARN(2, M35M22)PASS(1, M35)      PASS(1, M35)
>  SNB  igt_kms_flip_event_leak      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_kms_flip_modeset-vs-vblank-race      DMESG_WARN(3, M35)PASS(1, M35)      PASS(1, M35)
> *SNB  igt_kms_flip_tiling_flip-changes-tiling      PASS(2, M35)      TIMEOUT(1, M35)
>  SNB  igt_kms_mmio_vs_cs_flip_setcrtc_vs_cs_flip      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_kms_mmio_vs_cs_flip_setplane_vs_cs_flip      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_kms_plane_plane-position-hole-pipe-B-plane-1      DMESG_WARN(1, M35)PASS(4, M35M22)      PASS(1, M35)
>  SNB  igt_kms_rotation_crc_primary-rotation      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_kms_rotation_crc_sprite-rotation      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_cursor      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_cursor-dpms      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_dpms-mode-unset-non-lpsp      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_dpms-non-lpsp      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_drm-resources-equal      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_fences      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_fences-dpms      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_gem-execbuf      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_gem-mmap-cpu      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_gem-mmap-gtt      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_gem-pread      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_i2c      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_modeset-non-lpsp      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_pci-d3-state      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  SNB  igt_pm_rpm_rte      NSPT(1, M35)PASS(1, M35)      NSPT(1, M35)
>  HSW  igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset      DMESG_WARN(1, M40)PASS(4, M40M19)      DMESG_WARN(1, M40)
> *HSW  igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset-interruptible      DMESG_WARN(2, M40)PASS(1, M19)      PASS(1, M40)
>  HSW  igt_kms_plane_plane-panning-bottom-right-pipe-C-plane-1      TIMEOUT(3, M40)PASS(2, M19M40)      PASS(1, M40)
> *HSW  igt_kms_plane_plane-panning-top-left-pipe-C-plane-2      PASS(2, M40)      DMESG_FAIL(1, M40)
>  HSW  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(1, M19)DMESG_WARN(1, M40)PASS(3, M40)      PASS(1, M40)
> Note: You need to pay more attention to line start with '*'

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-06  8:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-05 13:37 [PATCH] drm/i915: Include i915_gem_evict.c kerneldoc into the drm docbook Daniel Vetter
2015-01-05 23:44 ` shuang.he
2015-01-06  8:25   ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.